You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/05/02 18:23:47 UTC
[GitHub] [tvm-vta] vegaluisjose opened a new pull request #26: [App][Verilator] change scalar add to parametric-vector-add
vegaluisjose opened a new pull request #26:
URL: https://github.com/apache/tvm-vta/pull/26
Hey guys,
This PR refactor the add example into a parametric-vector-add which can be used to evaluate MobileNet (at the moment) for multiple hardware configurations.
The actual MobileNet test/evaluation is going to be in TVM repo once this PR is merged in.
@tmoreau89 @liangfu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm-vta] tmoreau89 merged pull request #26: [App][Verilator] change scalar add to parametric-vector-add
Posted by GitBox <gi...@apache.org>.
tmoreau89 merged pull request #26:
URL: https://github.com/apache/tvm-vta/pull/26
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm-vta] tmoreau89 commented on a change in pull request #26: [App][Verilator] change scalar add to parametric-vector-add
Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on a change in pull request #26:
URL: https://github.com/apache/tvm-vta/pull/26#discussion_r624789600
##########
File path: apps/verilator/add/src/driver.cc
##########
@@ -28,14 +28,14 @@ namespace runtime {
namespace contrib {
extern "C" VerilatorHandle VerilatorAlloc() {
- Top *top = new Top;
+ Top* top = new Top;
Review comment:
Do we currently have these sources running under a linter @vegaluisjose ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm-vta] vegaluisjose commented on a change in pull request #26: [App][Verilator] change scalar add to parametric-vector-add
Posted by GitBox <gi...@apache.org>.
vegaluisjose commented on a change in pull request #26:
URL: https://github.com/apache/tvm-vta/pull/26#discussion_r624792843
##########
File path: apps/verilator/add/src/driver.cc
##########
@@ -28,14 +28,14 @@ namespace runtime {
namespace contrib {
extern "C" VerilatorHandle VerilatorAlloc() {
- Top *top = new Top;
+ Top* top = new Top;
Review comment:
Not really, I forgot running the previous one with the clang-formatter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org