You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by rmetzger <gi...@git.apache.org> on 2016/02/02 12:18:48 UTC

[GitHub] flink pull request: [FLINK-3287] [FLINK-3247] Fix curator shading ...

GitHub user rmetzger opened a pull request:

    https://github.com/apache/flink/pull/1573

    [FLINK-3287]	[FLINK-3247] Fix curator shading for Kafka connector

    Some maven versions are not properly evaluating star * excludes. Therefore, I've manually listed our shaded artifacts in the quickstart pom.
    
    Also, a user reported a version mismatch with curator on HDP. As a fix, I'm shading curator into the kafka connector.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rmetzger/flink flink3287

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1573.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1573
    
----
commit 02e33aaeb357d9a3ab6a282a0aabb87f2ac96032
Author: Robert Metzger <rm...@apache.org>
Date:   2016-01-28T14:16:16Z

    [FLINK-3287] Shade Curator dependency into flink-connector-kafka-0.8

commit c155758379906590d0b19412303cbdfcc0825d5c
Author: Robert Metzger <rm...@apache.org>
Date:   2016-02-02T11:04:26Z

    [FLINK-3247] Remove * exclude from quickstarts

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3287] [FLINK-3247] Fix curator shading ...

Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:

    https://github.com/apache/flink/pull/1573#issuecomment-178527480
  
    There is one issue I need to figure out, then, I'll merge it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3287] [FLINK-3247] Fix curator shading ...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1573#issuecomment-178518689
  
    Thanks for fixing this, this was a critical issue.
    
    +1 to merge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3287] [FLINK-3247] Fix curator shading ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/1573


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---