You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by mimaison <gi...@git.apache.org> on 2016/05/26 17:54:09 UTC

[GitHub] kafka pull request: MINOR: Fix tracing in KafkaApis.handle()

GitHub user mimaison opened a pull request:

    https://github.com/apache/kafka/pull/1435

    MINOR: Fix tracing in KafkaApis.handle()

    requestObj() returns null for the o.a.k.c.requests objects so use header() for these.
    
    Once all the requests will have been replaced by o.a.k.c.requests objects, we should be able to clean that up, but in the meantime it's useful to trace both.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mimaison/kafka kafkaapis_trace

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1435.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1435
    
----
commit 1fb627c8a5f57b4c8762f351564623034daf2158
Author: Mickael Maison <mi...@gmail.com>
Date:   2016-05-26T17:36:55Z

    MINOR: Fix tracing in KafkaApis.handle()
    
    requestObj returns null for the new Java request objects so use header for these.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request: MINOR: Fix tracing in KafkaApis.handle()

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/1435


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---