You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "git-hulk (via GitHub)" <gi...@apache.org> on 2024/01/12 10:18:27 UTC
[I] Implement WAL iterator for migrating by WAL logs [kvrocks]
git-hulk opened a new issue, #2007:
URL: https://github.com/apache/kvrocks/issues/2007
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement WAL iterator for migrating by WAL logs [kvrocks]
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on issue #2007:
URL: https://github.com/apache/kvrocks/issues/2007#issuecomment-1902574340
@caipengbo Sounds good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement WAL iterator for migrating by WAL logs [kvrocks]
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk closed issue #2007: Implement WAL iterator for migrating by WAL logs
URL: https://github.com/apache/kvrocks/issues/2007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement WAL iterator for migrating by WAL logs [kvrocks]
Posted by "caipengbo (via GitHub)" <gi...@apache.org>.
caipengbo commented on issue #2007:
URL: https://github.com/apache/kvrocks/issues/2007#issuecomment-1902566080
In https://github.com/apache/kvrocks/pull/2004, we implement the unified key-value iterators, I want to change data to provide a unified iterators.
For incremental data, we need to call `rocksdb::WALIter` and then implement the `rocksdb::WriteBatch::Handler` interface.
I want to provide an interface that behaves similarly to `engine::DBIterator`:
https://github.com/apache/kvrocks/blob/c772109516a6698f8e74d50c1a43bb1c02a697c5/src/storage/iterator.h#L52-L81.
It will wrap `rocksdb::WALIter` and can return different value types. It is possible to implement their processing logic depending on the concrete type.
HDYT @git-hulk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org