You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/25 14:04:32 UTC
[GitHub] [arrow-rs] alamb opened a new pull request, #2166: Run actions on push to master, pull requests
alamb opened a new pull request, #2166:
URL: https://github.com/apache/arrow-rs/pull/2166
# Which issue does this PR close?
Re https://github.com/apache/arrow-rs/issues/2149
# Rationale for this change
While wondering "why did we run out of github actions credits" (when my test jobs are waiting for a runner) I looked at the history of actions https://github.com/apache/arrow-rs/actions and saw several jobs were started *twice*
I have noticed the same thing on some of my own PRs but I have not found any recent examples.
# What changes are included in this PR?
Change jobs to trigger on push to `master` only as well as PRs
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a diff in pull request #2166: Run actions on push to master, pull requests
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #2166:
URL: https://github.com/apache/arrow-rs/pull/2166#discussion_r929301201
##########
.github/workflows/object_store.yml:
##########
@@ -19,6 +19,9 @@
name: "Object Store"
on:
+ push:
Review Comment:
https://github.com/apache/arrow-rs/runs/7508735903?check_suite_focus=true
Its working!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a diff in pull request #2166: Run actions on push to master, pull requests
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #2166:
URL: https://github.com/apache/arrow-rs/pull/2166#discussion_r929208243
##########
.github/workflows/object_store.yml:
##########
@@ -19,6 +19,9 @@
name: "Object Store"
on:
+ push:
Review Comment:
this is an oversight -- and it means the object store test does not run against master (until this PR gets merged)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #2166: Run actions on push to master, pull requests
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2166:
URL: https://github.com/apache/arrow-rs/pull/2166#issuecomment-1194626368
Benchmark runs are scheduled for baseline = 13e6f39fab33eb33300050486d77a1568bb77dbb and contender = ec3530da596a4535097d9d734b23291153f058f7. ec3530da596a4535097d9d734b23291153f058f7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/0a6068ab024d45479458cb49735e0ea8...4d0e683656814e19ae9f953db3ad6c25/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/9d1736d1c90d44c9a64d9f48c208967e...fddf7091e5eb4065a1d1d8d3200f9330/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/771ad080182c4fe0b3549046e33592b0...b8281668cd1a419ab4419d92500921f2/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/3f09b7192ccc4f35bcef3f16e1adb5e5...865f5d97e0ab4e318ccecf531cda8e9e/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #2166: Run actions on push to master, pull requests
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2166:
URL: https://github.com/apache/arrow-rs/pull/2166#issuecomment-1194576799
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/2166?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2166](https://codecov.io/gh/apache/arrow-rs/pull/2166?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c77e0e1) into [master](https://codecov.io/gh/apache/arrow-rs/commit/13e6f39fab33eb33300050486d77a1568bb77dbb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (13e6f39) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #2166 +/- ##
=======================================
Coverage 82.86% 82.86%
=======================================
Files 237 237
Lines 61429 61429
=======================================
Hits 50902 50902
Misses 10527 10527
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/2166?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow-rs/pull/2166/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldF9kZXJpdmUvc3JjL3BhcnF1ZXRfZmllbGQucnM=) | `65.98% <0.00%> (-0.23%)` | :arrow_down: |
| [parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow-rs/pull/2166/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvZW5jb2RpbmdzL2VuY29kaW5nLnJz) | `93.43% <0.00%> (-0.20%)` | :arrow_down: |
| [arrow/src/datatypes/datatype.rs](https://codecov.io/gh/apache/arrow-rs/pull/2166/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2RhdGF0eXBlcy9kYXRhdHlwZS5ycw==) | `63.00% <0.00%> (+0.31%)` | :arrow_up: |
| [...row/src/array/builder/string\_dictionary\_builder.rs](https://codecov.io/gh/apache/arrow-rs/pull/2166/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2J1aWxkZXIvc3RyaW5nX2RpY3Rpb25hcnlfYnVpbGRlci5ycw==) | `91.36% <0.00%> (+0.71%)` | :arrow_up: |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #2166: Run actions on push to master, pull requests
Posted by GitBox <gi...@apache.org>.
alamb merged PR #2166:
URL: https://github.com/apache/arrow-rs/pull/2166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org