You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Vamsavardhana Reddy (JIRA)" <de...@geronimo.apache.org> on 2006/09/05 15:41:24 UTC
[jira] Created: (GERONIMO-2380) Keystores portlet - Form field
validation using javascript
Keystores portlet - Form field validation using javascript
----------------------------------------------------------
Key: GERONIMO-2380
URL: http://issues.apache.org/jira/browse/GERONIMO-2380
Project: Geronimo
Issue Type: Improvement
Security Level: public (Regular issues)
Components: console
Affects Versions: 1.1.1
Environment: Win XP, G 1.1.1-rc1
Reporter: Vamsavardhana Reddy
Fix For: 1.1.2, 1.1.x, 1.2
Forms in Keystores portlet could use field validation using javascript to check for empty strings and non numerical values before posting the data to the server.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-2380) Keystores portlet - Form field
validation using javascript
Posted by "Vamsavardhana Reddy (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2380?page=all ]
Vamsavardhana Reddy updated GERONIMO-2380:
------------------------------------------
Attachment: GERONIMO-2380.patch
GERONIMO-2380.patch: Updates "Create Private Key" and "Add Trust Certificate" pages to use field validation using javascript.
> Keystores portlet - Form field validation using javascript
> ----------------------------------------------------------
>
> Key: GERONIMO-2380
> URL: http://issues.apache.org/jira/browse/GERONIMO-2380
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 1.1.1
> Environment: Win XP, G 1.1.1-rc1
> Reporter: Vamsavardhana Reddy
> Fix For: 1.2, 1.1.x, 1.1.2
>
> Attachments: GERONIMO-2380.patch
>
>
> Forms in Keystores portlet could use field validation using javascript to check for empty strings and non numerical values before posting the data to the server.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2380) Keystores portlet - Form field
validation using javascript
Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2380?page=comments#action_12433720 ]
David Jencks commented on GERONIMO-2380:
----------------------------------------
+1. I'm not sure this is complete enough (or I might have messed up the patch) but its progress.
> Keystores portlet - Form field validation using javascript
> ----------------------------------------------------------
>
> Key: GERONIMO-2380
> URL: http://issues.apache.org/jira/browse/GERONIMO-2380
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 1.1.1
> Environment: Win XP, G 1.1.1-rc1
> Reporter: Vamsavardhana Reddy
> Fix For: 1.2, 1.1.x, 1.1.2
>
> Attachments: GERONIMO-2380.patch
>
>
> Forms in Keystores portlet could use field validation using javascript to check for empty strings and non numerical values before posting the data to the server.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2380) Keystores portlet - Form field
validation using javascript
Posted by "Vamsavardhana Reddy (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2380?page=comments#action_12433551 ]
Vamsavardhana Reddy commented on GERONIMO-2380:
-----------------------------------------------
Paul, thanks for reviewing the patch.
"Number of days valid" chedking for emptiness is addressed in dependency JIRA GERONIMO-2378 Problems in JavaScript validation cod...
Regarding the trusted certificate field.... well javascript validation is not a complete validation of fields. Most of the time javascript validation is used to reduce traffic to the server. I added this check just to fall in line with other pages.
> Keystores portlet - Form field validation using javascript
> ----------------------------------------------------------
>
> Key: GERONIMO-2380
> URL: http://issues.apache.org/jira/browse/GERONIMO-2380
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 1.1.1
> Environment: Win XP, G 1.1.1-rc1
> Reporter: Vamsavardhana Reddy
> Fix For: 1.1.2, 1.1.x, 1.2
>
> Attachments: GERONIMO-2380.patch
>
>
> Forms in Keystores portlet could use field validation using javascript to check for empty strings and non numerical values before posting the data to the server.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2380) Keystores portlet - Form field
validation using javascript
Posted by "Paul McMahan (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2380?page=comments#action_12433473 ]
Paul McMahan commented on GERONIMO-2380:
----------------------------------------
Vamsi, some comments on the patch.
Create Private Key portlet:
"Number of days valid" is checked for being numerical but not for emptiness. If left empty the portlet throws a NumberFormatException. Also, the popup messages prompt for the form's internal variable names instead of the display name.
Upload certificate portlet:
The Trusted Cerficate field is not empty by default. It contains the text "...paste trusted certificate text here...". So checking the field for emptiness is not very useful.
> Keystores portlet - Form field validation using javascript
> ----------------------------------------------------------
>
> Key: GERONIMO-2380
> URL: http://issues.apache.org/jira/browse/GERONIMO-2380
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 1.1.1
> Environment: Win XP, G 1.1.1-rc1
> Reporter: Vamsavardhana Reddy
> Fix For: 1.1.2, 1.1.x, 1.2
>
> Attachments: GERONIMO-2380.patch
>
>
> Forms in Keystores portlet could use field validation using javascript to check for empty strings and non numerical values before posting the data to the server.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2380) Keystores portlet - Form field
validation using javascript
Posted by "Paul McMahan (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2380?page=comments#action_12433858 ]
Paul McMahan commented on GERONIMO-2380:
----------------------------------------
Vamsi, thanks for responding to my comments. Despite my concerns I think the patch is progress so +1
> Keystores portlet - Form field validation using javascript
> ----------------------------------------------------------
>
> Key: GERONIMO-2380
> URL: http://issues.apache.org/jira/browse/GERONIMO-2380
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 1.1.1
> Environment: Win XP, G 1.1.1-rc1
> Reporter: Vamsavardhana Reddy
> Fix For: 1.2, 1.1.x, 1.1.2
>
> Attachments: GERONIMO-2380.patch
>
>
> Forms in Keystores portlet could use field validation using javascript to check for empty strings and non numerical values before posting the data to the server.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (GERONIMO-2380) Keystores portlet - Form field
validation using javascript
Posted by "Gianny Damour (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2380?page=all ]
Gianny Damour reassigned GERONIMO-2380:
---------------------------------------
Assignee: Gianny Damour
> Keystores portlet - Form field validation using javascript
> ----------------------------------------------------------
>
> Key: GERONIMO-2380
> URL: http://issues.apache.org/jira/browse/GERONIMO-2380
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 1.1.1
> Environment: Win XP, G 1.1.1-rc1
> Reporter: Vamsavardhana Reddy
> Assigned To: Gianny Damour
> Fix For: 1.2, 1.1.x, 1.1.2
>
> Attachments: GERONIMO-2380.patch
>
>
> Forms in Keystores portlet could use field validation using javascript to check for empty strings and non numerical values before posting the data to the server.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira