You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by thotasrinath <gi...@git.apache.org> on 2017/03/23 13:50:53 UTC
[GitHub] incubator-carbondata pull request #690: [CARBONDATA-811] Refactor dictionary...
GitHub user thotasrinath opened a pull request:
https://github.com/apache/incubator-carbondata/pull/690
[CARBONDATA-811] Refactor dictionary based result collector class.
Initialization of variables is moved to constructor. So that initialization is done only once on object creation instead of running a business logic.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/thotasrinath/incubator-carbondata ResultCollectorClassOptimization
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/690.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #690
----
commit 542fcb921ac32eeb8b26e484dbd60b9b5fb16e8c
Author: thotasrinath <sr...@outlook.com>
Date: 2017-03-23T13:44:13Z
Refactor dictionary based result collector class.
Initialization of variables is moved to constructor. So that initialization is done only once on object creation instead of running a business logic.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #690: [CARBONDATA-811] Refactor dictionary based ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/690
LGTM. Testcases are failing not because of this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #690: [CARBONDATA-811] Refactor dictionary...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/690
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #690: [CARBONDATA-811] Refactor dictionary based ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/690
Build Failed with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1308/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---