You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/04/27 02:13:49 UTC

[GitHub] [rocketmq] HScarb commented on a diff in pull request #4213: [ISSUE #4203] Support zstd/lz4 compression to improve send/receive performance

HScarb commented on code in PR #4213:
URL: https://github.com/apache/rocketmq/pull/4213#discussion_r859314565


##########
common/src/main/java/org/apache/rocketmq/common/UtilAll.java:
##########
@@ -295,6 +295,7 @@ private static byte charToByte(char c) {
         return (byte) "0123456789ABCDEF".indexOf(c);
     }
 
+    @Deprecated

Review Comment:
   It's better to add link to new method, like this
   ```java
   /**
     * @deprecated use {@link Compressor#decompress()} instead. 
     */ 
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org