You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by "Scott Wegner (JIRA)" <ji...@apache.org> on 2018/10/12 22:43:00 UTC

[jira] [Created] (BEAM-5742) Add expectations for code reviews

Scott Wegner created BEAM-5742:
----------------------------------

             Summary: Add expectations for code reviews
                 Key: BEAM-5742
                 URL: https://issues.apache.org/jira/browse/BEAM-5742
             Project: Beam
          Issue Type: Sub-task
          Components: website
            Reporter: Scott Wegner


There should be a dedicated section about how we to code reviews, and expectations for contributors / reviewers. Things like:
* PR's should have linked JIRA
* Code changes should also include tests
* Small changes are easier to review
* How to find a reviewer, when you can expect reviewer to engage
* How automatic test runs work (PreCommits run by on each commit; build / test should be passing before asking for a reviewer)
* How to re-run tests, and how/when to run Post-Commits



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)