You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/09/21 06:31:43 UTC
[GitHub] [cloudstack] shwstppr opened a new pull request #5481: ui: fix create user with saml
shwstppr opened a new pull request #5481:
URL: https://github.com/apache/cloudstack/pull/5481
### Description
Fixes #5478
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5481: ui: fix create user with saml
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5481:
URL: https://github.com/apache/cloudstack/pull/5481#issuecomment-923686900
@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5481: ui: fix create account/user with saml
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5481:
URL: https://github.com/apache/cloudstack/pull/5481#issuecomment-923732532
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5481 (SL-JID-674)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd edited a comment on pull request #5481: ui: fix create user with saml
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on pull request #5481:
URL: https://github.com/apache/cloudstack/pull/5481#issuecomment-923701717
@shwstppr couple of issues, not sure if they are due to the qa.cloudstack.cloud backend of 4.15.1: (the qa.cloudstack.cloud is SAMl enabled and can be used for testing)
1. Check if the normal user/role type should be shown this form, it fails:
2. On creating user as normal user type, that fails too (in its own account):
3. As domain admin, the IDP list was somehow not shown in the create user form:
4. As root admin, I created a new user 'rick' and while creating the user ticked authorise saml sso and selected the IDP however the newly-created user is not SAML2 type:
5. For an already authorised saml user, when clicking edit saml authorisation button the IDP is pre-selected as 0 (something wrong in option/value key?)
Note: this form also seems to pass invalid entityid in the API, so the user isn't really SAML enabled.
@shwstppr please also test/fix any issues with the createAccount form (which also has the saml authorisation option).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5481: ui: fix create account/user with saml
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5481:
URL: https://github.com/apache/cloudstack/pull/5481#issuecomment-923915249
LGTM tested!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5481: ui: fix create account/user with saml
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5481:
URL: https://github.com/apache/cloudstack/pull/5481#issuecomment-923771911
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5481: ui: fix create account/user with saml
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5481:
URL: https://github.com/apache/cloudstack/pull/5481#issuecomment-923735165
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5481 (SL-JID-675)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5481: ui: fix create account/user with saml
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5481:
URL: https://github.com/apache/cloudstack/pull/5481#issuecomment-923727827
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5481: ui: fix create user with saml
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5481:
URL: https://github.com/apache/cloudstack/pull/5481#issuecomment-923685796
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5481: ui: fix create account/user with saml
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5481:
URL: https://github.com/apache/cloudstack/pull/5481#issuecomment-923731043
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5481: ui: fix create user with saml
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5481:
URL: https://github.com/apache/cloudstack/pull/5481#issuecomment-923686071
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr edited a comment on pull request #5481: ui: fix create account/user with saml
Posted by GitBox <gi...@apache.org>.
shwstppr edited a comment on pull request #5481:
URL: https://github.com/apache/cloudstack/pull/5481#issuecomment-923903002
@rhtyd let's move ahead with one for _2_
> As domain admin, the entity ID is not updating - still 0? And on saving the form still passes 0 as entityid
I'll fix _1_ and _3_ in another PR #5487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5481: ui: fix create account/user with saml
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5481:
URL: https://github.com/apache/cloudstack/pull/5481#issuecomment-923895733
@shwstppr is this ready for final test/merge, or you addressing minor issues too?
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5481: ui: fix create account/user with saml
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5481:
URL: https://github.com/apache/cloudstack/pull/5481#issuecomment-923772987
@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5481: ui: fix create user with saml
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5481:
URL: https://github.com/apache/cloudstack/pull/5481#issuecomment-923701717
@shwstppr couple of issues, not sure if they are due to the qa.cloudstack.cloud backend of 4.15.1: (the qa.cloudstack.cloud is SAMl enabled and can be used for testing)
1. Check if the normal user/role type should be shown this form, it fails:
2. On creating user as normal user type, that fails too (in its own account):
3. As domain admin, the IDP list was somehow not shown in the create user form:
4. As root admin, I created a new user 'rick' and while creating the user ticked authorise saml sso and selected the IDP however the newly-created user is not SAML2 type:
5. For an already authorised saml user, when clicking edit saml authorisation button the IDP is pre-selected as 0 (something wrong in option/value key?)
Note: this form also seems to pass invalid entityid in the API, so the user isn't really SAML enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5481: ui: fix create account/user with saml
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5481:
URL: https://github.com/apache/cloudstack/pull/5481#issuecomment-923896166
@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5481: ui: fix create user with saml
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5481:
URL: https://github.com/apache/cloudstack/pull/5481#issuecomment-923689207
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5481 (SL-JID-673)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5481: ui: fix create account/user with saml
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5481:
URL: https://github.com/apache/cloudstack/pull/5481#issuecomment-923900149
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5481 (SL-JID-678)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd edited a comment on pull request #5481: ui: fix create account/user with saml
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on pull request #5481:
URL: https://github.com/apache/cloudstack/pull/5481#issuecomment-923814460
@shwstppr outstanding/new issues:
1. Minor - does not refresh user detail page on edit/saving the authorise saml sso form
2. As domain admin, the entity ID is not updating - still 0? And on saving the form still passes 0 as entityid
3. Minor - Create user form doesn't work for domain user the #/user path (as domainid is not passed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5481: ui: fix create account/user with saml
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5481:
URL: https://github.com/apache/cloudstack/pull/5481#issuecomment-923727390
@rhtyd Verified mentioned issues with PR build:
1. Normal User role cannot create new users in their own account. Old UI doesn't provide the option and option wasn't there in this PR build as well.
2. Same as `1`
3. Fixed this case
4. Fixed with this PR
5. Didn't see this behaviour with this PR build.
Addressed #5477 and #5478
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5481: ui: fix create account/user with saml
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5481:
URL: https://github.com/apache/cloudstack/pull/5481#issuecomment-923772555
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5481: ui: fix create account/user with saml
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5481:
URL: https://github.com/apache/cloudstack/pull/5481#issuecomment-923731254
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5481: ui: fix create account/user with saml
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5481:
URL: https://github.com/apache/cloudstack/pull/5481#issuecomment-923776127
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5481 (SL-JID-676)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5481: ui: fix create account/user with saml
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5481:
URL: https://github.com/apache/cloudstack/pull/5481#issuecomment-923903002
@rhtyd let's move ahead with one for #2
> As domain admin, the entity ID is not updating - still 0? And on saving the form still passes 0 as entityid
I'll fix #1 and #3 in another PR #5487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5481: ui: fix create account/user with saml
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5481:
URL: https://github.com/apache/cloudstack/pull/5481#issuecomment-923814460
@shwstppr outstanding/new issues:
1. Minor - does not refresh user detail page on edit/saving the authorise saml sso form
2. As domain admin, the entity ID is not updating - still 0? And on saving the form still passes 0 as entityid
3. Create user form doesn't work for domain user the #/user path (as domainid is not passed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #5481: ui: fix create account/user with saml
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5481:
URL: https://github.com/apache/cloudstack/pull/5481
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org