You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Benjamin Bentmann (JIRA)" <ji...@apache.org> on 2008/04/25 15:39:55 UTC

[jira] Created: (LANG-430) Add methods StringUtils.lowerCase(String, Locale) and StringUtils.upperCase(String, Locale)

Add methods StringUtils.lowerCase(String, Locale) and StringUtils.upperCase(String, Locale)
-------------------------------------------------------------------------------------------

                 Key: LANG-430
                 URL: https://issues.apache.org/jira/browse/LANG-430
             Project: Commons Lang
          Issue Type: New Feature
    Affects Versions: 2.4
            Reporter: Benjamin Bentmann
            Priority: Minor


Since the platform-dependence of [String.to*Case()|http://java.sun.com/javase/6/docs/api/java/lang/String.html#toLowerCase()] is usually not intended, developers will specify a fixed locale when doing the case transformation (compare [Common Bug #3|http://www.nabble.com/Re%3A-Common-Bugs-p14931921s177.html]). There are currently not related methods in {{StringUtils}}.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (LANG-430) Add methods StringUtils.lowerCase(String, Locale) and StringUtils.upperCase(String, Locale)

Posted by "James Carman (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LANG-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12592382#action_12592382 ] 

James Carman commented on LANG-430:
-----------------------------------

I agree, if we're going to provide null-safe, helper methods, we should also provide the locale-sensitive ones.  I don't think we can remove them at this point.

> Add methods StringUtils.lowerCase(String, Locale) and StringUtils.upperCase(String, Locale)
> -------------------------------------------------------------------------------------------
>
>                 Key: LANG-430
>                 URL: https://issues.apache.org/jira/browse/LANG-430
>             Project: Commons Lang
>          Issue Type: New Feature
>    Affects Versions: 2.4
>            Reporter: Benjamin Bentmann
>            Priority: Minor
>         Attachments: LANG-430.patch
>
>
> Since the platform-dependence of [String.to*Case()|http://java.sun.com/javase/6/docs/api/java/lang/String.html#toLowerCase()] is usually not intended, developers will specify a fixed locale when doing the case transformation (compare [Common Bug #3|http://www.nabble.com/Re%3A-Common-Bugs-p14931921s177.html]). There are currently not related methods in {{StringUtils}}.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (LANG-430) Add methods StringUtils.lowerCase(String, Locale) and StringUtils.upperCase(String, Locale)

Posted by "Benjamin Bentmann (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LANG-430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Bentmann updated LANG-430:
-----------------------------------

    Attachment: LANG-430.patch

> Add methods StringUtils.lowerCase(String, Locale) and StringUtils.upperCase(String, Locale)
> -------------------------------------------------------------------------------------------
>
>                 Key: LANG-430
>                 URL: https://issues.apache.org/jira/browse/LANG-430
>             Project: Commons Lang
>          Issue Type: New Feature
>    Affects Versions: 2.4
>            Reporter: Benjamin Bentmann
>            Priority: Minor
>         Attachments: LANG-430.patch
>
>
> Since the platform-dependence of [String.to*Case()|http://java.sun.com/javase/6/docs/api/java/lang/String.html#toLowerCase()] is usually not intended, developers will specify a fixed locale when doing the case transformation (compare [Common Bug #3|http://www.nabble.com/Re%3A-Common-Bugs-p14931921s177.html]). There are currently not related methods in {{StringUtils}}.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (LANG-430) Add methods StringUtils.lowerCase(String, Locale) and StringUtils.upperCase(String, Locale)

Posted by "James Carman (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LANG-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12592380#action_12592380 ] 

James Carman commented on LANG-430:
-----------------------------------

What does the upperCase() method buy us anyway?  Is it merely a null-safe alternative to String.toUpperCase()?

> Add methods StringUtils.lowerCase(String, Locale) and StringUtils.upperCase(String, Locale)
> -------------------------------------------------------------------------------------------
>
>                 Key: LANG-430
>                 URL: https://issues.apache.org/jira/browse/LANG-430
>             Project: Commons Lang
>          Issue Type: New Feature
>    Affects Versions: 2.4
>            Reporter: Benjamin Bentmann
>            Priority: Minor
>         Attachments: LANG-430.patch
>
>
> Since the platform-dependence of [String.to*Case()|http://java.sun.com/javase/6/docs/api/java/lang/String.html#toLowerCase()] is usually not intended, developers will specify a fixed locale when doing the case transformation (compare [Common Bug #3|http://www.nabble.com/Re%3A-Common-Bugs-p14931921s177.html]). There are currently not related methods in {{StringUtils}}.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (LANG-430) Add methods StringUtils.lowerCase(String, Locale) and StringUtils.upperCase(String, Locale)

Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LANG-430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henri Yandell closed LANG-430.
------------------------------

       Resolution: Fixed
    Fix Version/s: 3.0

svn ci -m "Adding Locale overloads for toUpperCase and toLowerCase as provided by Benjamin Bentmann in LANG-430" src

Sending        src/java/org/apache/commons/lang/StringUtils.java
Sending        src/test/org/apache/commons/lang/StringUtilsTest.java
Transmitting file data ..
Committed revision 655239.

> Add methods StringUtils.lowerCase(String, Locale) and StringUtils.upperCase(String, Locale)
> -------------------------------------------------------------------------------------------
>
>                 Key: LANG-430
>                 URL: https://issues.apache.org/jira/browse/LANG-430
>             Project: Commons Lang
>          Issue Type: New Feature
>    Affects Versions: 2.4
>            Reporter: Benjamin Bentmann
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: LANG-430.patch
>
>
> Since the platform-dependence of [String.to*Case()|http://java.sun.com/javase/6/docs/api/java/lang/String.html#toLowerCase()] is usually not intended, developers will specify a fixed locale when doing the case transformation (compare [Common Bug #3|http://www.nabble.com/Re%3A-Common-Bugs-p14931921s177.html]). There are currently not related methods in {{StringUtils}}.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (LANG-430) Add methods StringUtils.lowerCase(String, Locale) and StringUtils.upperCase(String, Locale)

Posted by "James Carman (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LANG-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12592382#action_12592382 ] 

jwcarman edited comment on LANG-430 at 4/25/08 7:09 AM:
------------------------------------------------------------

I agree; if we're going to provide null-safe, helper methods, we should also provide the locale-sensitive ones.  I don't think we can remove them at this point.

      was (Author: jwcarman):
    I agree, if we're going to provide null-safe, helper methods, we should also provide the locale-sensitive ones.  I don't think we can remove them at this point.
  
> Add methods StringUtils.lowerCase(String, Locale) and StringUtils.upperCase(String, Locale)
> -------------------------------------------------------------------------------------------
>
>                 Key: LANG-430
>                 URL: https://issues.apache.org/jira/browse/LANG-430
>             Project: Commons Lang
>          Issue Type: New Feature
>    Affects Versions: 2.4
>            Reporter: Benjamin Bentmann
>            Priority: Minor
>         Attachments: LANG-430.patch
>
>
> Since the platform-dependence of [String.to*Case()|http://java.sun.com/javase/6/docs/api/java/lang/String.html#toLowerCase()] is usually not intended, developers will specify a fixed locale when doing the case transformation (compare [Common Bug #3|http://www.nabble.com/Re%3A-Common-Bugs-p14931921s177.html]). There are currently not related methods in {{StringUtils}}.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (LANG-430) Add methods StringUtils.lowerCase(String, Locale) and StringUtils.upperCase(String, Locale)

Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LANG-430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Niall Pemberton updated LANG-430:
---------------------------------

    Fix Version/s:     (was: 3.0)
                   2.5

> Add methods StringUtils.lowerCase(String, Locale) and StringUtils.upperCase(String, Locale)
> -------------------------------------------------------------------------------------------
>
>                 Key: LANG-430
>                 URL: https://issues.apache.org/jira/browse/LANG-430
>             Project: Commons Lang
>          Issue Type: New Feature
>          Components: lang.*
>    Affects Versions: 2.4
>            Reporter: Benjamin Bentmann
>            Priority: Minor
>             Fix For: 2.5
>
>         Attachments: LANG-430.patch
>
>
> Since the platform-dependence of [String.to*Case()|http://java.sun.com/javase/6/docs/api/java/lang/String.html#toLowerCase()] is usually not intended, developers will specify a fixed locale when doing the case transformation (compare [Common Bug #3|http://www.nabble.com/Re%3A-Common-Bugs-p14931921s177.html]). There are currently not related methods in {{StringUtils}}.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (LANG-430) Add methods StringUtils.lowerCase(String, Locale) and StringUtils.upperCase(String, Locale)

Posted by "Benjamin Bentmann (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LANG-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12592381#action_12592381 ] 

Benjamin Bentmann commented on LANG-430:
----------------------------------------

Other methods from {{StringUtils}} are just null-safe wrappers around {{String}} methods, too, e.g. {{trim()}} or {{length()}}. Guess it's a matter of convenience.

Anyway, I'm also fine if {{StringUtils.upperCase()}} and {{StringUtils.lowerCase()}} would get removed. I just don't like to see that Lang only provides platform-dependent case transformations.

> Add methods StringUtils.lowerCase(String, Locale) and StringUtils.upperCase(String, Locale)
> -------------------------------------------------------------------------------------------
>
>                 Key: LANG-430
>                 URL: https://issues.apache.org/jira/browse/LANG-430
>             Project: Commons Lang
>          Issue Type: New Feature
>    Affects Versions: 2.4
>            Reporter: Benjamin Bentmann
>            Priority: Minor
>         Attachments: LANG-430.patch
>
>
> Since the platform-dependence of [String.to*Case()|http://java.sun.com/javase/6/docs/api/java/lang/String.html#toLowerCase()] is usually not intended, developers will specify a fixed locale when doing the case transformation (compare [Common Bug #3|http://www.nabble.com/Re%3A-Common-Bugs-p14931921s177.html]). There are currently not related methods in {{StringUtils}}.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.