You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/12/20 17:55:12 UTC

[GitHub] [calcite] jacques-n commented on a change in pull request #2653: [CALCITE-4952] (Re)introduce a simplistic RelMetadataQuery option

jacques-n commented on a change in pull request #2653:
URL: https://github.com/apache/calcite/pull/2653#discussion_r772563991



##########
File path: core/src/test/java/org/apache/calcite/test/RelMetadataTest.java
##########
@@ -3686,4 +3742,43 @@ Sql assertRowsUnique(boolean[] ignoreNulls, Matcher<Boolean> matcher,
     }
 
   }
+
+  /**
+   * Test class for janino metadata path.
+   */
+  @Nested

Review comment:
       Yeah, I was torn on making it parameterized given the sheer amount of minor changes. 
   
   I just went through and did so. It quadrupled the size of the patch but I agree it is more idiomatic.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org