[GitHub] [hbase] saintstack commented on a change in pull request #3566: HBASE-26172 Deprecated MasterRegistry and allow getBootstrapNodes to …

[GitBox <gi...@apache.org>]

saintstack commented on a change in pull request #3566:
URL: https://github.com/apache/hbase/pull/3566#discussion_r685670797



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
##########
@@ -308,18 +310,35 @@
    */
   private static final long DEFAULT_REGION_SERVER_RPC_MINIMUM_SCAN_TIME_LIMIT_DELTA = 10;
 
-  /*
+  /**
    * Whether to reject rows with size > threshold defined by
    * {@link RSRpcServices#BATCH_ROWS_THRESHOLD_NAME}
    */
   private static final String REJECT_BATCH_ROWS_OVER_THRESHOLD =
     "hbase.rpc.rows.size.threshold.reject";
 
-  /*
+  /**
    * Default value of config {@link RSRpcServices#REJECT_BATCH_ROWS_OVER_THRESHOLD}
    */
   private static final boolean DEFAULT_REJECT_BATCH_ROWS_OVER_THRESHOLD = false;
 
+  /**
+   * Determine the bootstrap nodes we want to return to the client connection registry.
+   * <ul>
+   * <li>{@link #MASTER}: return masters as bootstrap nodes.</li>

Review comment:
       I'm trying to figure out what the approach is. It seems to be moving Registry host to RegionServers -- which sounds good but I'm not sure how we get off the ground... bootstrap. And yeah, would be good to avoid Masters if we can.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org