You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Shrijeet Paliwal (JIRA)" <ji...@apache.org> on 2011/07/15 23:38:59 UTC
[jira] [Created] (HBASE-4109) Hostname returned via reverse dns
lookup contains trailing period if configured interface is not "default"
Hostname returned via reverse dns lookup contains trailing period if configured interface is not "default"
----------------------------------------------------------------------------------------------------------
Key: HBASE-4109
URL: https://issues.apache.org/jira/browse/HBASE-4109
Project: HBase
Issue Type: Bug
Components: master, regionserver
Affects Versions: 0.90.3
Reporter: Shrijeet Paliwal
Fix For: 0.90.4
If you are using an interface anything other than 'default' (literally that keyword) DNS.java 's getDefaultHost will return a string which will
have a trailing period at the end. It seems javadoc of reverseDns in DNS.java (see below) is conflicting with what that function is actually doing.
It is returning a PTR record while claims it returns a hostname. The PTR record always has period at the end , RFC: http://irbs.net/bog-4.9.5/bog47.html
We make call to DNS.getDefaultHost at more than one places and treat that as actual hostname.
Quoting HRegionServer for example
{code}
String machineName = DNS.getDefaultHost(conf.get(
"hbase.regionserver.dns.interface", "default"), conf.get(
"hbase.regionserver.dns.nameserver", "default"));
{code}
This causes inconsistencies. An example of such inconsistency was observed while debugging the issue "Regions not getting reassigned if RS is brought down". More here
http://search-hadoop.com/m/CANUA1qRCkQ1
We may want to sanitize the string returned from DNS class. Or better we can take a path of overhauling the way we do DNS name matching all over.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4109) Hostname returned via reverse dns
lookup contains trailing period if configured interface is not "default"
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259517#comment-13259517 ]
Hudson commented on HBASE-4109:
-------------------------------
Integrated in HBase-0.92-security #105 (See [https://builds.apache.org/job/HBase-0.92-security/105/])
HBASE-5758 Forward port "HBASE-4109 Hostname returned via reverse dns lookup contains trailing period if configured interface is not default (Revision 1311827)
HBASE-5758 Forward port "HBASE-4109 Hostname returned via reverse dns lookup contains trailing period if configured interface is not default (Revision 1311825)
Result = FAILURE
stack :
Files :
* /hbase/branches/0.92/CHANGES.txt
stack :
Files :
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/Strings.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java
> Hostname returned via reverse dns lookup contains trailing period if configured interface is not "default"
> ----------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4109
> URL: https://issues.apache.org/jira/browse/HBASE-4109
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.90.4
>
> Attachments: 0001-HBASE-4109-Sanitize-hostname-returned-from-DNS-class.patch
>
>
> If you are using an interface anything other than 'default' (literally that keyword) DNS.java 's getDefaultHost will return a string which will
> have a trailing period at the end. It seems javadoc of reverseDns in DNS.java (see below) is conflicting with what that function is actually doing.
> It is returning a PTR record while claims it returns a hostname. The PTR record always has period at the end , RFC: http://irbs.net/bog-4.9.5/bog47.html
> We make call to DNS.getDefaultHost at more than one places and treat that as actual hostname.
> Quoting HRegionServer for example
> {code}
> String machineName = DNS.getDefaultHost(conf.get(
> "hbase.regionserver.dns.interface", "default"), conf.get(
> "hbase.regionserver.dns.nameserver", "default"));
> {code}
> This causes inconsistencies. An example of such inconsistency was observed while debugging the issue "Regions not getting reassigned if RS is brought down". More here
> http://search-hadoop.com/m/CANUA1qRCkQ1
> We may want to sanitize the string returned from DNS class. Or better we can take a path of overhauling the way we do DNS name matching all over.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4109) Hostname returned via reverse dns
lookup contains trailing period if configured interface is not "default"
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068732#comment-13068732 ]
jiraposter@reviews.apache.org commented on HBASE-4109:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1139/#review1146
-----------------------------------------------------------
Should : String domainNamePointerToHostName(String dnPtr) be in o.a.h.h.util.Strings? Perhaps it would be better in o.a.h.h.util.Addressing?
- Eugene
On 2011-07-18 18:41:16, Shrijeet Paliwal wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1139/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-07-18 18:41:16)
bq.
bq.
bq. Review request for hbase and Michael Stack.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. If you are using an interface anything other than 'default' (literally that keyword) DNS.java 's getDefaultHost will return a string which will
bq. have a trailing period at the end. It seems javadoc of reverseDns in DNS.java (see below) is conflicting with what that function is actually doing.
bq. It is returning a PTR record while claims it returns a hostname. The PTR record always has period at the end , RFC: http://irbs.net/bog-4.9.5/bog47.html
bq.
bq. This patch adds a sanitizing function and wraps all calls to getDefaultHost to go through a step of removing trailing period.
bq.
bq.
bq. This addresses bug HBASE-4109.
bq. https://issues.apache.org/jira/browse/HBASE-4109
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/util/Strings.java c2cad2e
bq. src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java d551c6f
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 2d033f3
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java c91523a
bq.
bq. Diff: https://reviews.apache.org/r/1139/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Shrijeet
bq.
bq.
> Hostname returned via reverse dns lookup contains trailing period if configured interface is not "default"
> ----------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4109
> URL: https://issues.apache.org/jira/browse/HBASE-4109
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Fix For: 0.90.4
>
> Attachments: 0001-HBASE-4109-Sanitize-hostname-returned-from-DNS-class.patch
>
>
> If you are using an interface anything other than 'default' (literally that keyword) DNS.java 's getDefaultHost will return a string which will
> have a trailing period at the end. It seems javadoc of reverseDns in DNS.java (see below) is conflicting with what that function is actually doing.
> It is returning a PTR record while claims it returns a hostname. The PTR record always has period at the end , RFC: http://irbs.net/bog-4.9.5/bog47.html
> We make call to DNS.getDefaultHost at more than one places and treat that as actual hostname.
> Quoting HRegionServer for example
> {code}
> String machineName = DNS.getDefaultHost(conf.get(
> "hbase.regionserver.dns.interface", "default"), conf.get(
> "hbase.regionserver.dns.nameserver", "default"));
> {code}
> This causes inconsistencies. An example of such inconsistency was observed while debugging the issue "Regions not getting reassigned if RS is brought down". More here
> http://search-hadoop.com/m/CANUA1qRCkQ1
> We may want to sanitize the string returned from DNS class. Or better we can take a path of overhauling the way we do DNS name matching all over.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4109) Hostname returned via reverse dns
lookup contains trailing period if configured interface is not "default"
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250899#comment-13250899 ]
Hudson commented on HBASE-4109:
-------------------------------
Integrated in HBase-0.92 #366 (See [https://builds.apache.org/job/HBase-0.92/366/])
HBASE-5758 Forward port "HBASE-4109 Hostname returned via reverse dns lookup contains trailing period if configured interface is not default (Revision 1311827)
HBASE-5758 Forward port "HBASE-4109 Hostname returned via reverse dns lookup contains trailing period if configured interface is not default (Revision 1311825)
Result = FAILURE
stack :
Files :
* /hbase/branches/0.92/CHANGES.txt
stack :
Files :
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/Strings.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java
> Hostname returned via reverse dns lookup contains trailing period if configured interface is not "default"
> ----------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4109
> URL: https://issues.apache.org/jira/browse/HBASE-4109
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.90.4
>
> Attachments: 0001-HBASE-4109-Sanitize-hostname-returned-from-DNS-class.patch
>
>
> If you are using an interface anything other than 'default' (literally that keyword) DNS.java 's getDefaultHost will return a string which will
> have a trailing period at the end. It seems javadoc of reverseDns in DNS.java (see below) is conflicting with what that function is actually doing.
> It is returning a PTR record while claims it returns a hostname. The PTR record always has period at the end , RFC: http://irbs.net/bog-4.9.5/bog47.html
> We make call to DNS.getDefaultHost at more than one places and treat that as actual hostname.
> Quoting HRegionServer for example
> {code}
> String machineName = DNS.getDefaultHost(conf.get(
> "hbase.regionserver.dns.interface", "default"), conf.get(
> "hbase.regionserver.dns.nameserver", "default"));
> {code}
> This causes inconsistencies. An example of such inconsistency was observed while debugging the issue "Regions not getting reassigned if RS is brought down". More here
> http://search-hadoop.com/m/CANUA1qRCkQ1
> We may want to sanitize the string returned from DNS class. Or better we can take a path of overhauling the way we do DNS name matching all over.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4109) Hostname returned via reverse dns
lookup contains trailing period if configured interface is not "default"
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253627#comment-13253627 ]
Hudson commented on HBASE-4109:
-------------------------------
Integrated in HBase-0.94-security #9 (See [https://builds.apache.org/job/HBase-0.94-security/9/])
HBASE-5758 Forward port "HBASE-4109 Hostname returned via reverse dns lookup contains trailing period if configured interface is not default (Revision 1311822)
Result = SUCCESS
stack :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/Strings.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java
> Hostname returned via reverse dns lookup contains trailing period if configured interface is not "default"
> ----------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4109
> URL: https://issues.apache.org/jira/browse/HBASE-4109
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.90.4
>
> Attachments: 0001-HBASE-4109-Sanitize-hostname-returned-from-DNS-class.patch
>
>
> If you are using an interface anything other than 'default' (literally that keyword) DNS.java 's getDefaultHost will return a string which will
> have a trailing period at the end. It seems javadoc of reverseDns in DNS.java (see below) is conflicting with what that function is actually doing.
> It is returning a PTR record while claims it returns a hostname. The PTR record always has period at the end , RFC: http://irbs.net/bog-4.9.5/bog47.html
> We make call to DNS.getDefaultHost at more than one places and treat that as actual hostname.
> Quoting HRegionServer for example
> {code}
> String machineName = DNS.getDefaultHost(conf.get(
> "hbase.regionserver.dns.interface", "default"), conf.get(
> "hbase.regionserver.dns.nameserver", "default"));
> {code}
> This causes inconsistencies. An example of such inconsistency was observed while debugging the issue "Regions not getting reassigned if RS is brought down". More here
> http://search-hadoop.com/m/CANUA1qRCkQ1
> We may want to sanitize the string returned from DNS class. Or better we can take a path of overhauling the way we do DNS name matching all over.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4109) Hostname returned via reverse dns
lookup contains trailing period if configured interface is not "default"
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068737#comment-13068737 ]
jiraposter@reviews.apache.org commented on HBASE-4109:
------------------------------------------------------
bq. On 2011-07-20 23:59:24, Eugene Koontz wrote:
bq. > Should : String domainNamePointerToHostName(String dnPtr) be in o.a.h.h.util.Strings? Perhaps it would be better in o.a.h.h.util.Addressing?
Eugene, yeah I had second thoughts about it myself. One, I was hesitating introducing a new class (I was thinking of introducing NetUtils) because all we are doing is string manipulation instead of any networking magic. Second, I saw org.apache.hadoop.util having functions like simpleHostname in it.
- Shrijeet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1139/#review1146
-----------------------------------------------------------
On 2011-07-18 18:41:16, Shrijeet Paliwal wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1139/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-07-18 18:41:16)
bq.
bq.
bq. Review request for hbase and Michael Stack.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. If you are using an interface anything other than 'default' (literally that keyword) DNS.java 's getDefaultHost will return a string which will
bq. have a trailing period at the end. It seems javadoc of reverseDns in DNS.java (see below) is conflicting with what that function is actually doing.
bq. It is returning a PTR record while claims it returns a hostname. The PTR record always has period at the end , RFC: http://irbs.net/bog-4.9.5/bog47.html
bq.
bq. This patch adds a sanitizing function and wraps all calls to getDefaultHost to go through a step of removing trailing period.
bq.
bq.
bq. This addresses bug HBASE-4109.
bq. https://issues.apache.org/jira/browse/HBASE-4109
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/util/Strings.java c2cad2e
bq. src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java d551c6f
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 2d033f3
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java c91523a
bq.
bq. Diff: https://reviews.apache.org/r/1139/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Shrijeet
bq.
bq.
> Hostname returned via reverse dns lookup contains trailing period if configured interface is not "default"
> ----------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4109
> URL: https://issues.apache.org/jira/browse/HBASE-4109
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Fix For: 0.90.4
>
> Attachments: 0001-HBASE-4109-Sanitize-hostname-returned-from-DNS-class.patch
>
>
> If you are using an interface anything other than 'default' (literally that keyword) DNS.java 's getDefaultHost will return a string which will
> have a trailing period at the end. It seems javadoc of reverseDns in DNS.java (see below) is conflicting with what that function is actually doing.
> It is returning a PTR record while claims it returns a hostname. The PTR record always has period at the end , RFC: http://irbs.net/bog-4.9.5/bog47.html
> We make call to DNS.getDefaultHost at more than one places and treat that as actual hostname.
> Quoting HRegionServer for example
> {code}
> String machineName = DNS.getDefaultHost(conf.get(
> "hbase.regionserver.dns.interface", "default"), conf.get(
> "hbase.regionserver.dns.nameserver", "default"));
> {code}
> This causes inconsistencies. An example of such inconsistency was observed while debugging the issue "Regions not getting reassigned if RS is brought down". More here
> http://search-hadoop.com/m/CANUA1qRCkQ1
> We may want to sanitize the string returned from DNS class. Or better we can take a path of overhauling the way we do DNS name matching all over.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4109) Hostname returned via reverse dns
lookup contains trailing period if configured interface is not "default"
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-4109:
-------------------------
Status: Patch Available (was: Open)
> Hostname returned via reverse dns lookup contains trailing period if configured interface is not "default"
> ----------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4109
> URL: https://issues.apache.org/jira/browse/HBASE-4109
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Fix For: 0.90.4
>
> Attachments: 0001-HBASE-4109-Sanitize-hostname-returned-from-DNS-class.patch
>
>
> If you are using an interface anything other than 'default' (literally that keyword) DNS.java 's getDefaultHost will return a string which will
> have a trailing period at the end. It seems javadoc of reverseDns in DNS.java (see below) is conflicting with what that function is actually doing.
> It is returning a PTR record while claims it returns a hostname. The PTR record always has period at the end , RFC: http://irbs.net/bog-4.9.5/bog47.html
> We make call to DNS.getDefaultHost at more than one places and treat that as actual hostname.
> Quoting HRegionServer for example
> {code}
> String machineName = DNS.getDefaultHost(conf.get(
> "hbase.regionserver.dns.interface", "default"), conf.get(
> "hbase.regionserver.dns.nameserver", "default"));
> {code}
> This causes inconsistencies. An example of such inconsistency was observed while debugging the issue "Regions not getting reassigned if RS is brought down". More here
> http://search-hadoop.com/m/CANUA1qRCkQ1
> We may want to sanitize the string returned from DNS class. Or better we can take a path of overhauling the way we do DNS name matching all over.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4109) Hostname returned via reverse dns
lookup contains trailing period if configured interface is not "default"
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251362#comment-13251362 ]
Hudson commented on HBASE-4109:
-------------------------------
Integrated in HBase-TRUNK-security #167 (See [https://builds.apache.org/job/HBase-TRUNK-security/167/])
HBASE-5758 Forward port "HBASE-4109 Hostname returned via reverse dns lookup contains trailing period if configured interface is not default (Revision 1311821)
Result = SUCCESS
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/Strings.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java
> Hostname returned via reverse dns lookup contains trailing period if configured interface is not "default"
> ----------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4109
> URL: https://issues.apache.org/jira/browse/HBASE-4109
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.90.4
>
> Attachments: 0001-HBASE-4109-Sanitize-hostname-returned-from-DNS-class.patch
>
>
> If you are using an interface anything other than 'default' (literally that keyword) DNS.java 's getDefaultHost will return a string which will
> have a trailing period at the end. It seems javadoc of reverseDns in DNS.java (see below) is conflicting with what that function is actually doing.
> It is returning a PTR record while claims it returns a hostname. The PTR record always has period at the end , RFC: http://irbs.net/bog-4.9.5/bog47.html
> We make call to DNS.getDefaultHost at more than one places and treat that as actual hostname.
> Quoting HRegionServer for example
> {code}
> String machineName = DNS.getDefaultHost(conf.get(
> "hbase.regionserver.dns.interface", "default"), conf.get(
> "hbase.regionserver.dns.nameserver", "default"));
> {code}
> This causes inconsistencies. An example of such inconsistency was observed while debugging the issue "Regions not getting reassigned if RS is brought down". More here
> http://search-hadoop.com/m/CANUA1qRCkQ1
> We may want to sanitize the string returned from DNS class. Or better we can take a path of overhauling the way we do DNS name matching all over.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-4109) Hostname returned via reverse dns
lookup contains trailing period if configured interface is not "default"
Posted by "Jean-Daniel Cryans (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Daniel Cryans reassigned HBASE-4109:
-----------------------------------------
Assignee: Shrijeet Paliwal
> Hostname returned via reverse dns lookup contains trailing period if configured interface is not "default"
> ----------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4109
> URL: https://issues.apache.org/jira/browse/HBASE-4109
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.90.4
>
> Attachments: 0001-HBASE-4109-Sanitize-hostname-returned-from-DNS-class.patch
>
>
> If you are using an interface anything other than 'default' (literally that keyword) DNS.java 's getDefaultHost will return a string which will
> have a trailing period at the end. It seems javadoc of reverseDns in DNS.java (see below) is conflicting with what that function is actually doing.
> It is returning a PTR record while claims it returns a hostname. The PTR record always has period at the end , RFC: http://irbs.net/bog-4.9.5/bog47.html
> We make call to DNS.getDefaultHost at more than one places and treat that as actual hostname.
> Quoting HRegionServer for example
> {code}
> String machineName = DNS.getDefaultHost(conf.get(
> "hbase.regionserver.dns.interface", "default"), conf.get(
> "hbase.regionserver.dns.nameserver", "default"));
> {code}
> This causes inconsistencies. An example of such inconsistency was observed while debugging the issue "Regions not getting reassigned if RS is brought down". More here
> http://search-hadoop.com/m/CANUA1qRCkQ1
> We may want to sanitize the string returned from DNS class. Or better we can take a path of overhauling the way we do DNS name matching all over.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4109) Hostname returned via reverse dns
lookup contains trailing period if configured interface is not "default"
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250799#comment-13250799 ]
Hudson commented on HBASE-4109:
-------------------------------
Integrated in HBase-0.94 #101 (See [https://builds.apache.org/job/HBase-0.94/101/])
HBASE-5758 Forward port "HBASE-4109 Hostname returned via reverse dns lookup contains trailing period if configured interface is not default (Revision 1311822)
Result = SUCCESS
stack :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/Strings.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java
> Hostname returned via reverse dns lookup contains trailing period if configured interface is not "default"
> ----------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4109
> URL: https://issues.apache.org/jira/browse/HBASE-4109
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.90.4
>
> Attachments: 0001-HBASE-4109-Sanitize-hostname-returned-from-DNS-class.patch
>
>
> If you are using an interface anything other than 'default' (literally that keyword) DNS.java 's getDefaultHost will return a string which will
> have a trailing period at the end. It seems javadoc of reverseDns in DNS.java (see below) is conflicting with what that function is actually doing.
> It is returning a PTR record while claims it returns a hostname. The PTR record always has period at the end , RFC: http://irbs.net/bog-4.9.5/bog47.html
> We make call to DNS.getDefaultHost at more than one places and treat that as actual hostname.
> Quoting HRegionServer for example
> {code}
> String machineName = DNS.getDefaultHost(conf.get(
> "hbase.regionserver.dns.interface", "default"), conf.get(
> "hbase.regionserver.dns.nameserver", "default"));
> {code}
> This causes inconsistencies. An example of such inconsistency was observed while debugging the issue "Regions not getting reassigned if RS is brought down". More here
> http://search-hadoop.com/m/CANUA1qRCkQ1
> We may want to sanitize the string returned from DNS class. Or better we can take a path of overhauling the way we do DNS name matching all over.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4109) Hostname returned via reverse dns
lookup contains trailing period if configured interface is not "default"
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13066252#comment-13066252 ]
stack commented on HBASE-4109:
------------------------------
@Shrijeet The redo has been done in TRUNK. Regionserver uses a String passed it by the master for all messages (HBASE-1502).
A sanitization would work for 0.90?
> Hostname returned via reverse dns lookup contains trailing period if configured interface is not "default"
> ----------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4109
> URL: https://issues.apache.org/jira/browse/HBASE-4109
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Fix For: 0.90.4
>
>
> If you are using an interface anything other than 'default' (literally that keyword) DNS.java 's getDefaultHost will return a string which will
> have a trailing period at the end. It seems javadoc of reverseDns in DNS.java (see below) is conflicting with what that function is actually doing.
> It is returning a PTR record while claims it returns a hostname. The PTR record always has period at the end , RFC: http://irbs.net/bog-4.9.5/bog47.html
> We make call to DNS.getDefaultHost at more than one places and treat that as actual hostname.
> Quoting HRegionServer for example
> {code}
> String machineName = DNS.getDefaultHost(conf.get(
> "hbase.regionserver.dns.interface", "default"), conf.get(
> "hbase.regionserver.dns.nameserver", "default"));
> {code}
> This causes inconsistencies. An example of such inconsistency was observed while debugging the issue "Regions not getting reassigned if RS is brought down". More here
> http://search-hadoop.com/m/CANUA1qRCkQ1
> We may want to sanitize the string returned from DNS class. Or better we can take a path of overhauling the way we do DNS name matching all over.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4109) Hostname returned via reverse dns
lookup contains trailing period if configured interface is not "default"
Posted by "Shrijeet Paliwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13066261#comment-13066261 ]
Shrijeet Paliwal commented on HBASE-4109:
-----------------------------------------
Makes my life easier :) I will submit a patch with sanitizing function today.
> Hostname returned via reverse dns lookup contains trailing period if configured interface is not "default"
> ----------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4109
> URL: https://issues.apache.org/jira/browse/HBASE-4109
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Fix For: 0.90.4
>
>
> If you are using an interface anything other than 'default' (literally that keyword) DNS.java 's getDefaultHost will return a string which will
> have a trailing period at the end. It seems javadoc of reverseDns in DNS.java (see below) is conflicting with what that function is actually doing.
> It is returning a PTR record while claims it returns a hostname. The PTR record always has period at the end , RFC: http://irbs.net/bog-4.9.5/bog47.html
> We make call to DNS.getDefaultHost at more than one places and treat that as actual hostname.
> Quoting HRegionServer for example
> {code}
> String machineName = DNS.getDefaultHost(conf.get(
> "hbase.regionserver.dns.interface", "default"), conf.get(
> "hbase.regionserver.dns.nameserver", "default"));
> {code}
> This causes inconsistencies. An example of such inconsistency was observed while debugging the issue "Regions not getting reassigned if RS is brought down". More here
> http://search-hadoop.com/m/CANUA1qRCkQ1
> We may want to sanitize the string returned from DNS class. Or better we can take a path of overhauling the way we do DNS name matching all over.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4109) Hostname returned via reverse dns
lookup contains trailing period if configured interface is not "default"
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068719#comment-13068719 ]
jiraposter@reviews.apache.org commented on HBASE-4109:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1139/#review1145
-----------------------------------------------------------
Ship it!
+1
- Michael
On 2011-07-18 18:41:16, Shrijeet Paliwal wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1139/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-07-18 18:41:16)
bq.
bq.
bq. Review request for hbase and Michael Stack.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. If you are using an interface anything other than 'default' (literally that keyword) DNS.java 's getDefaultHost will return a string which will
bq. have a trailing period at the end. It seems javadoc of reverseDns in DNS.java (see below) is conflicting with what that function is actually doing.
bq. It is returning a PTR record while claims it returns a hostname. The PTR record always has period at the end , RFC: http://irbs.net/bog-4.9.5/bog47.html
bq.
bq. This patch adds a sanitizing function and wraps all calls to getDefaultHost to go through a step of removing trailing period.
bq.
bq.
bq. This addresses bug HBASE-4109.
bq. https://issues.apache.org/jira/browse/HBASE-4109
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/util/Strings.java c2cad2e
bq. src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java d551c6f
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 2d033f3
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java c91523a
bq.
bq. Diff: https://reviews.apache.org/r/1139/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Shrijeet
bq.
bq.
> Hostname returned via reverse dns lookup contains trailing period if configured interface is not "default"
> ----------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4109
> URL: https://issues.apache.org/jira/browse/HBASE-4109
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Fix For: 0.90.4
>
> Attachments: 0001-HBASE-4109-Sanitize-hostname-returned-from-DNS-class.patch
>
>
> If you are using an interface anything other than 'default' (literally that keyword) DNS.java 's getDefaultHost will return a string which will
> have a trailing period at the end. It seems javadoc of reverseDns in DNS.java (see below) is conflicting with what that function is actually doing.
> It is returning a PTR record while claims it returns a hostname. The PTR record always has period at the end , RFC: http://irbs.net/bog-4.9.5/bog47.html
> We make call to DNS.getDefaultHost at more than one places and treat that as actual hostname.
> Quoting HRegionServer for example
> {code}
> String machineName = DNS.getDefaultHost(conf.get(
> "hbase.regionserver.dns.interface", "default"), conf.get(
> "hbase.regionserver.dns.nameserver", "default"));
> {code}
> This causes inconsistencies. An example of such inconsistency was observed while debugging the issue "Regions not getting reassigned if RS is brought down". More here
> http://search-hadoop.com/m/CANUA1qRCkQ1
> We may want to sanitize the string returned from DNS class. Or better we can take a path of overhauling the way we do DNS name matching all over.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4109) Hostname returned via reverse dns
lookup contains trailing period if configured interface is not "default"
Posted by "Adrian Muraru (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250567#comment-13250567 ]
Adrian Muraru commented on HBASE-4109:
--------------------------------------
Hi,
Just noticed that the same issue pops up in 0.92 now.
Can we have this patch applied in 0.92 trunk as well?
> Hostname returned via reverse dns lookup contains trailing period if configured interface is not "default"
> ----------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4109
> URL: https://issues.apache.org/jira/browse/HBASE-4109
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.90.4
>
> Attachments: 0001-HBASE-4109-Sanitize-hostname-returned-from-DNS-class.patch
>
>
> If you are using an interface anything other than 'default' (literally that keyword) DNS.java 's getDefaultHost will return a string which will
> have a trailing period at the end. It seems javadoc of reverseDns in DNS.java (see below) is conflicting with what that function is actually doing.
> It is returning a PTR record while claims it returns a hostname. The PTR record always has period at the end , RFC: http://irbs.net/bog-4.9.5/bog47.html
> We make call to DNS.getDefaultHost at more than one places and treat that as actual hostname.
> Quoting HRegionServer for example
> {code}
> String machineName = DNS.getDefaultHost(conf.get(
> "hbase.regionserver.dns.interface", "default"), conf.get(
> "hbase.regionserver.dns.nameserver", "default"));
> {code}
> This causes inconsistencies. An example of such inconsistency was observed while debugging the issue "Regions not getting reassigned if RS is brought down". More here
> http://search-hadoop.com/m/CANUA1qRCkQ1
> We may want to sanitize the string returned from DNS class. Or better we can take a path of overhauling the way we do DNS name matching all over.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4109) Hostname returned via reverse dns
lookup contains trailing period if configured interface is not "default"
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-4109:
-------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed to branch (Should be no need for this kind of fixup on trunk). Thanks for the patch Shrijeet.
> Hostname returned via reverse dns lookup contains trailing period if configured interface is not "default"
> ----------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4109
> URL: https://issues.apache.org/jira/browse/HBASE-4109
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Fix For: 0.90.4
>
> Attachments: 0001-HBASE-4109-Sanitize-hostname-returned-from-DNS-class.patch
>
>
> If you are using an interface anything other than 'default' (literally that keyword) DNS.java 's getDefaultHost will return a string which will
> have a trailing period at the end. It seems javadoc of reverseDns in DNS.java (see below) is conflicting with what that function is actually doing.
> It is returning a PTR record while claims it returns a hostname. The PTR record always has period at the end , RFC: http://irbs.net/bog-4.9.5/bog47.html
> We make call to DNS.getDefaultHost at more than one places and treat that as actual hostname.
> Quoting HRegionServer for example
> {code}
> String machineName = DNS.getDefaultHost(conf.get(
> "hbase.regionserver.dns.interface", "default"), conf.get(
> "hbase.regionserver.dns.nameserver", "default"));
> {code}
> This causes inconsistencies. An example of such inconsistency was observed while debugging the issue "Regions not getting reassigned if RS is brought down". More here
> http://search-hadoop.com/m/CANUA1qRCkQ1
> We may want to sanitize the string returned from DNS class. Or better we can take a path of overhauling the way we do DNS name matching all over.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4109) Hostname returned via reverse dns
lookup contains trailing period if configured interface is not "default"
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067206#comment-13067206 ]
jiraposter@reviews.apache.org commented on HBASE-4109:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1139/
-----------------------------------------------------------
Review request for hbase and Michael Stack.
Summary
-------
If you are using an interface anything other than 'default' (literally that keyword) DNS.java 's getDefaultHost will return a string which will
have a trailing period at the end. It seems javadoc of reverseDns in DNS.java (see below) is conflicting with what that function is actually doing.
It is returning a PTR record while claims it returns a hostname. The PTR record always has period at the end , RFC: http://irbs.net/bog-4.9.5/bog47.html
This patch adds a sanitizing function and wraps all calls to getDefaultHost to go through a step of removing trailing period.
This addresses bug HBASE-4109.
https://issues.apache.org/jira/browse/HBASE-4109
Diffs
-----
src/main/java/org/apache/hadoop/hbase/util/Strings.java c2cad2e
src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java d551c6f
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 2d033f3
src/main/java/org/apache/hadoop/hbase/master/HMaster.java c91523a
Diff: https://reviews.apache.org/r/1139/diff
Testing
-------
Thanks,
Shrijeet
> Hostname returned via reverse dns lookup contains trailing period if configured interface is not "default"
> ----------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4109
> URL: https://issues.apache.org/jira/browse/HBASE-4109
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Fix For: 0.90.4
>
> Attachments: 0001-HBASE-4109-Sanitize-hostname-returned-from-DNS-class.patch
>
>
> If you are using an interface anything other than 'default' (literally that keyword) DNS.java 's getDefaultHost will return a string which will
> have a trailing period at the end. It seems javadoc of reverseDns in DNS.java (see below) is conflicting with what that function is actually doing.
> It is returning a PTR record while claims it returns a hostname. The PTR record always has period at the end , RFC: http://irbs.net/bog-4.9.5/bog47.html
> We make call to DNS.getDefaultHost at more than one places and treat that as actual hostname.
> Quoting HRegionServer for example
> {code}
> String machineName = DNS.getDefaultHost(conf.get(
> "hbase.regionserver.dns.interface", "default"), conf.get(
> "hbase.regionserver.dns.nameserver", "default"));
> {code}
> This causes inconsistencies. An example of such inconsistency was observed while debugging the issue "Regions not getting reassigned if RS is brought down". More here
> http://search-hadoop.com/m/CANUA1qRCkQ1
> We may want to sanitize the string returned from DNS class. Or better we can take a path of overhauling the way we do DNS name matching all over.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4109) Hostname returned via reverse dns
lookup contains trailing period if configured interface is not "default"
Posted by "Harsh J (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221283#comment-13221283 ]
Harsh J commented on HBASE-4109:
--------------------------------
Hi,
This affects multihomed DataNodes as well. I've filed HADOOP-8134 upstream.
> Hostname returned via reverse dns lookup contains trailing period if configured interface is not "default"
> ----------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4109
> URL: https://issues.apache.org/jira/browse/HBASE-4109
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.90.4
>
> Attachments: 0001-HBASE-4109-Sanitize-hostname-returned-from-DNS-class.patch
>
>
> If you are using an interface anything other than 'default' (literally that keyword) DNS.java 's getDefaultHost will return a string which will
> have a trailing period at the end. It seems javadoc of reverseDns in DNS.java (see below) is conflicting with what that function is actually doing.
> It is returning a PTR record while claims it returns a hostname. The PTR record always has period at the end , RFC: http://irbs.net/bog-4.9.5/bog47.html
> We make call to DNS.getDefaultHost at more than one places and treat that as actual hostname.
> Quoting HRegionServer for example
> {code}
> String machineName = DNS.getDefaultHost(conf.get(
> "hbase.regionserver.dns.interface", "default"), conf.get(
> "hbase.regionserver.dns.nameserver", "default"));
> {code}
> This causes inconsistencies. An example of such inconsistency was observed while debugging the issue "Regions not getting reassigned if RS is brought down". More here
> http://search-hadoop.com/m/CANUA1qRCkQ1
> We may want to sanitize the string returned from DNS class. Or better we can take a path of overhauling the way we do DNS name matching all over.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4109) Hostname returned via reverse dns
lookup contains trailing period if configured interface is not "default"
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068832#comment-13068832 ]
stack commented on HBASE-4109:
------------------------------
Sorry. I meant to say that I like Eugene's suggestion but agree that this single method is not really enough to start up a new class -- especially given the kind of String manipulation being done; I think its good for now.
> Hostname returned via reverse dns lookup contains trailing period if configured interface is not "default"
> ----------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4109
> URL: https://issues.apache.org/jira/browse/HBASE-4109
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Fix For: 0.90.4
>
> Attachments: 0001-HBASE-4109-Sanitize-hostname-returned-from-DNS-class.patch
>
>
> If you are using an interface anything other than 'default' (literally that keyword) DNS.java 's getDefaultHost will return a string which will
> have a trailing period at the end. It seems javadoc of reverseDns in DNS.java (see below) is conflicting with what that function is actually doing.
> It is returning a PTR record while claims it returns a hostname. The PTR record always has period at the end , RFC: http://irbs.net/bog-4.9.5/bog47.html
> We make call to DNS.getDefaultHost at more than one places and treat that as actual hostname.
> Quoting HRegionServer for example
> {code}
> String machineName = DNS.getDefaultHost(conf.get(
> "hbase.regionserver.dns.interface", "default"), conf.get(
> "hbase.regionserver.dns.nameserver", "default"));
> {code}
> This causes inconsistencies. An example of such inconsistency was observed while debugging the issue "Regions not getting reassigned if RS is brought down". More here
> http://search-hadoop.com/m/CANUA1qRCkQ1
> We may want to sanitize the string returned from DNS class. Or better we can take a path of overhauling the way we do DNS name matching all over.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4109) Hostname returned via reverse dns
lookup contains trailing period if configured interface is not "default"
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250862#comment-13250862 ]
Hudson commented on HBASE-4109:
-------------------------------
Integrated in HBase-TRUNK #2737 (See [https://builds.apache.org/job/HBase-TRUNK/2737/])
HBASE-5758 Forward port "HBASE-4109 Hostname returned via reverse dns lookup contains trailing period if configured interface is not default (Revision 1311821)
Result = SUCCESS
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/Strings.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java
> Hostname returned via reverse dns lookup contains trailing period if configured interface is not "default"
> ----------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4109
> URL: https://issues.apache.org/jira/browse/HBASE-4109
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.90.4
>
> Attachments: 0001-HBASE-4109-Sanitize-hostname-returned-from-DNS-class.patch
>
>
> If you are using an interface anything other than 'default' (literally that keyword) DNS.java 's getDefaultHost will return a string which will
> have a trailing period at the end. It seems javadoc of reverseDns in DNS.java (see below) is conflicting with what that function is actually doing.
> It is returning a PTR record while claims it returns a hostname. The PTR record always has period at the end , RFC: http://irbs.net/bog-4.9.5/bog47.html
> We make call to DNS.getDefaultHost at more than one places and treat that as actual hostname.
> Quoting HRegionServer for example
> {code}
> String machineName = DNS.getDefaultHost(conf.get(
> "hbase.regionserver.dns.interface", "default"), conf.get(
> "hbase.regionserver.dns.nameserver", "default"));
> {code}
> This causes inconsistencies. An example of such inconsistency was observed while debugging the issue "Regions not getting reassigned if RS is brought down". More here
> http://search-hadoop.com/m/CANUA1qRCkQ1
> We may want to sanitize the string returned from DNS class. Or better we can take a path of overhauling the way we do DNS name matching all over.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4109) Hostname returned via reverse dns
lookup contains trailing period if configured interface is not "default"
Posted by "Shrijeet Paliwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shrijeet Paliwal updated HBASE-4109:
------------------------------------
Attachment: 0001-HBASE-4109-Sanitize-hostname-returned-from-DNS-class.patch
Patch of hbase 0.90.3
> Hostname returned via reverse dns lookup contains trailing period if configured interface is not "default"
> ----------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4109
> URL: https://issues.apache.org/jira/browse/HBASE-4109
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Fix For: 0.90.4
>
> Attachments: 0001-HBASE-4109-Sanitize-hostname-returned-from-DNS-class.patch
>
>
> If you are using an interface anything other than 'default' (literally that keyword) DNS.java 's getDefaultHost will return a string which will
> have a trailing period at the end. It seems javadoc of reverseDns in DNS.java (see below) is conflicting with what that function is actually doing.
> It is returning a PTR record while claims it returns a hostname. The PTR record always has period at the end , RFC: http://irbs.net/bog-4.9.5/bog47.html
> We make call to DNS.getDefaultHost at more than one places and treat that as actual hostname.
> Quoting HRegionServer for example
> {code}
> String machineName = DNS.getDefaultHost(conf.get(
> "hbase.regionserver.dns.interface", "default"), conf.get(
> "hbase.regionserver.dns.nameserver", "default"));
> {code}
> This causes inconsistencies. An example of such inconsistency was observed while debugging the issue "Regions not getting reassigned if RS is brought down". More here
> http://search-hadoop.com/m/CANUA1qRCkQ1
> We may want to sanitize the string returned from DNS class. Or better we can take a path of overhauling the way we do DNS name matching all over.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4109) Hostname returned via reverse dns
lookup contains trailing period if configured interface is not "default"
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250729#comment-13250729 ]
stack commented on HBASE-4109:
------------------------------
@Adrian Forward port is over in hbase-5758. I will commit later today.
> Hostname returned via reverse dns lookup contains trailing period if configured interface is not "default"
> ----------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4109
> URL: https://issues.apache.org/jira/browse/HBASE-4109
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.90.4
>
> Attachments: 0001-HBASE-4109-Sanitize-hostname-returned-from-DNS-class.patch
>
>
> If you are using an interface anything other than 'default' (literally that keyword) DNS.java 's getDefaultHost will return a string which will
> have a trailing period at the end. It seems javadoc of reverseDns in DNS.java (see below) is conflicting with what that function is actually doing.
> It is returning a PTR record while claims it returns a hostname. The PTR record always has period at the end , RFC: http://irbs.net/bog-4.9.5/bog47.html
> We make call to DNS.getDefaultHost at more than one places and treat that as actual hostname.
> Quoting HRegionServer for example
> {code}
> String machineName = DNS.getDefaultHost(conf.get(
> "hbase.regionserver.dns.interface", "default"), conf.get(
> "hbase.regionserver.dns.nameserver", "default"));
> {code}
> This causes inconsistencies. An example of such inconsistency was observed while debugging the issue "Regions not getting reassigned if RS is brought down". More here
> http://search-hadoop.com/m/CANUA1qRCkQ1
> We may want to sanitize the string returned from DNS class. Or better we can take a path of overhauling the way we do DNS name matching all over.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira