You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/01/19 10:46:00 UTC
[GitHub] [lucene-solr] asalamon74 opened a new pull request #2222: SOLR-14297: replace commons-codec Base64 with JDK8 Base64
asalamon74 opened a new pull request #2222:
URL: https://github.com/apache/lucene-solr/pull/2222
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr:
* https://issues.apache.org/jira/projects/LUCENE
* https://issues.apache.org/jira/projects/SOLR
You will need to create an account in Jira in order to create an issue.
The title of the PR should reference the Jira issue number in the form:
* LUCENE-####: <short description of problem or changes>
* SOLR-####: <short description of problem or changes>
LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
Java8 has a builtin Base64 encoder and decoder, there is no need to use commons-codec for this purpose.
# Solution
Eliminate commons-codec Base64 usage
# Tests
Unit tests
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `master` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] HoustonPutman commented on pull request #2222: SOLR-14297: replace commons-codec Base64 with JDK8 Base64
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on pull request #2222:
URL: https://github.com/apache/lucene-solr/pull/2222#issuecomment-763939227
Could you please add an entry to `solr/CHANGES.txt` in the 9.0 section under "Other"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] HoustonPutman edited a comment on pull request #2222: SOLR-14297: replace commons-codec Base64 with JDK8 Base64
Posted by GitBox <gi...@apache.org>.
HoustonPutman edited a comment on pull request #2222:
URL: https://github.com/apache/lucene-solr/pull/2222#issuecomment-762977652
Since Base64.Encoder and Base64.Decoder are thread-safe, it might be better to have static instantiations of each for each class here, instead of generating one per request.
Otherwise this looks pretty straightforward!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] HoustonPutman merged pull request #2222: SOLR-14297: replace commons-codec Base64 with JDK8 Base64
Posted by GitBox <gi...@apache.org>.
HoustonPutman merged pull request #2222:
URL: https://github.com/apache/lucene-solr/pull/2222
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] HoustonPutman merged pull request #2222: SOLR-14297: replace commons-codec Base64 with JDK8 Base64
Posted by GitBox <gi...@apache.org>.
HoustonPutman merged pull request #2222:
URL: https://github.com/apache/lucene-solr/pull/2222
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] HoustonPutman commented on pull request #2222: SOLR-14297: replace commons-codec Base64 with JDK8 Base64
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on pull request #2222:
URL: https://github.com/apache/lucene-solr/pull/2222#issuecomment-763939227
Could you please add an entry to `solr/CHANGES.txt` in the 9.0 section under "Other"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] HoustonPutman commented on pull request #2222: SOLR-14297: replace commons-codec Base64 with JDK8 Base64
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on pull request #2222:
URL: https://github.com/apache/lucene-solr/pull/2222#issuecomment-762977652
Since Base64.Encoder and Base64.Decoder are thread-safe, it might be better to have static implementations of each for each class here, instead of generating one per request.
Otherwise this looks pretty straightforward!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] asalamon74 commented on pull request #2222: SOLR-14297: replace commons-codec Base64 with JDK8 Base64
Posted by GitBox <gi...@apache.org>.
asalamon74 commented on pull request #2222:
URL: https://github.com/apache/lucene-solr/pull/2222#issuecomment-763421790
It seems to me `getDecoder()` and `getEncoder()` does not generate a new decoder/encoder just returns the same one: http://hg.openjdk.java.net/jdk8/jdk8/jdk/file/687fd7c7986d/src/share/classes/java/util/Base64.java#l151
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org