[GitHub] [geode] galen-pivotal opened pull request #3039: GEODE-6221: Cleanup some Protobuf tests

["galen-pivotal (GitHub)" <gi...@apache.org>]

* Remove usage of JUnit4CacheTestCase from geode-protobuf.
* Don't use DUnit embedded locator for testing against.

I'm not 100% this will fix all the flakiness, but it should be an
improvement.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [x] Have you written or updated unit tests to verify your changes?

- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/3039 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] galen-pivotal commented on pull request #3039: GEODE-6221: Cleanup some Protobuf tests

["galen-pivotal (GitHub)" <gi...@apache.org>]

ah, nice. That wasn't clear, so I'll add it to the doc comment.

[ Full content available at: https://github.com/apache/geode/pull/3039 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on pull request #3039: GEODE-6221: Cleanup some Protobuf tests

["kirklund (GitHub)" <gi...@apache.org>]

Everything in Host is (or is going to be) deprecated. Go ahead and change to:
```
hostName = VM.getHostName();
```

[ Full content available at: https://github.com/apache/geode/pull/3039 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on pull request #3039: GEODE-6221: Cleanup some Protobuf tests

["kirklund (GitHub)" <gi...@apache.org>]

Don't forget to set all statics to null (including locator) in tearDown:
```
locatorVM.invoke(() -> {
  locator.stop();
  locator = null;
});

[ Full content available at: https://github.com/apache/geode/pull/3039 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] galen-pivotal commented on pull request #3039: GEODE-6221: Cleanup some Protobuf tests

["galen-pivotal (GitHub)" <gi...@apache.org>]

oh, nice, thanks! I didn't know that had been added to `VM`.

[ Full content available at: https://github.com/apache/geode/pull/3039 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on pull request #3039: GEODE-6221: Cleanup some Protobuf tests

["kirklund (GitHub)" <gi...@apache.org>]

I recommend moving this line to tearDown() method and just delete the try-finally blocks from all of these tests. Helps reduce the noise.

[ Full content available at: https://github.com/apache/geode/pull/3039 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on pull request #3039: GEODE-6221: Cleanup some Protobuf tests

["kirklund (GitHub)" <gi...@apache.org>]

You don't need RestoreSystemProperties if you're already using DistributedRestoreSystemProperties. The latter includes the main JVM.

[ Full content available at: https://github.com/apache/geode/pull/3039 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] galen-pivotal commented on pull request #3039: GEODE-6221: Cleanup some Protobuf tests

["galen-pivotal (GitHub)" <gi...@apache.org>]

I think I disagree on this point. I prefer to have tests clean up for themselves anything that's not part of the setup/teardown scope. I don't really want to have _all_ the tests run with read-serialized set to true, and I would prefer not to decouple the scope of setup and cleanup for the thread-local read-serialized.

[ Full content available at: https://github.com/apache/geode/pull/3039 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] galen-pivotal closed pull request #3039: GEODE-6221: Cleanup some Protobuf tests

["galen-pivotal (GitHub)" <gi...@apache.org>]

[ pull request closed by galen-pivotal ]

[ Full content available at: https://github.com/apache/geode/pull/3039 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org