You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/08/08 13:09:39 UTC
[GitHub] [netbeans] jtulach opened a new pull request #3096: Exposing "Frontend UI Pages" to users of Java Frontend Application
jtulach opened a new pull request #3096:
URL: https://github.com/apache/netbeans/pull/3096
When a Gradle project for Java Frontend Application is created (like in #3095), it doesn't navigate user to `pages` directory with `index.html` - finding that directory is quite tricky and hurts experience of those who try to use this support. The PR fixes that by creating a dedicated node, if the `src/main/webapp/pages` directory is found.

Laszlo, can you please check if I am using the Gradle project extension mechanism properly? It does work, but maybe there are better ways to achieve the same.
Sváťo, maybe the plugin could register actions and associate Run with `bck2brwsr -t` without the need to specify that in the `gradle.properties`? However I haven't found an example to do it - `micronaut` project doesn't seem to specify that, but I think @sdedic has created an API that should work for Gradle projects as well.
If the current PR is fine from @lkishalmi's perspective, I'd like to get it to 12.5 - the node is very handy. If it is not, we can wait for 12.6.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a change in pull request #3096: Exposing "Frontend UI Pages" to users of Java Frontend Application
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on a change in pull request #3096:
URL: https://github.com/apache/netbeans/pull/3096#discussion_r684946794
##########
File path: java/gradle.htmlui/src/org/netbeans/modules/gradle/htmlui/HtmlJavaPagesNodeFactory.java
##########
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.netbeans.modules.gradle.htmlui;
+
+import java.awt.Image;
+import org.netbeans.modules.gradle.api.NbGradleProject;
+import org.netbeans.modules.gradle.spi.nodes.AbstractGradleNodeList;
+import java.beans.PropertyChangeEvent;
+import java.beans.PropertyChangeListener;
+import java.util.Collections;
+import java.util.List;
+import javax.swing.event.ChangeListener;
+import org.netbeans.api.project.Project;
+import org.netbeans.spi.project.ui.support.NodeFactory;
+import org.netbeans.spi.project.ui.support.NodeList;
+import org.openide.filesystems.FileObject;
+import org.openide.loaders.DataFolder;
+import org.openide.nodes.FilterNode;
+import org.openide.nodes.Node;
+import org.openide.util.ImageUtilities;
+import org.openide.util.NbBundle;
+
+@NbBundle.Messages({
+ "MSG_HtmlJavaPages=Frontend UI Pages"
+})
+@NodeFactory.Registration(projectType = NbGradleProject.GRADLE_PROJECT_TYPE, position = 77)
+public final class HtmlJavaPagesNodeFactory implements NodeFactory {
+
+ @Override
+ public NodeList<?> createNodes(Project p) {
+ return new HtmlJavaPagesList(p);
+ }
+
+ private static class HtmlJavaPagesList extends AbstractGradleNodeList<FileObject> implements PropertyChangeListener {
+
+ final Project project;
+
+ HtmlJavaPagesList(Project project) {
+ this.project = project;
+ }
+
+ @Override
+ public List<FileObject> keys() {
+ FileObject pages = project.getProjectDirectory().getFileObject("src/main/webapp/pages"); // NOI18N
+ return pages != null ? Collections.singletonList(pages) : Collections.<FileObject>emptyList();
+ }
+
+ @Override
+ public Node node(FileObject key) {
+ DataFolder df = DataFolder.findFolder(key);
+ FilterNode fn = new FilterNode(df.getNodeDelegate().cloneNode()) {
+ @Override
+ public Image getIcon(int type) {
+ return ImageUtilities.loadImage("org/netbeans/modules/gradle/htmlui/DukeHTML.png"); // NOI18N
+ }
+
+ @Override
+ public Image getOpenedIcon(int type) {
+ return getIcon(type);
+ }
+
+ @Override
+ public String getName() {
+ return "pages"; // NOI18N
+ }
+
+ @Override
+ public String getDisplayName() {
+ return Bundle.MSG_HtmlJavaPages();
+ }
+ };
+ return fn;
+ }
+
+ @Override
+ public void propertyChange(PropertyChangeEvent evt) {
+ if (NbGradleProject.PROP_PROJECT_INFO.equals(evt.getPropertyName())) {
Review comment:
I guess you are not the only one [doing that](https://github.com/apache/netbeans/blob/0719659fdb6d42a5d2314dfd0436a50c6ef81c77/enterprise/maven.j2ee/src/org/netbeans/modules/maven/j2ee/ui/nodes/WebPagesNodeFactory.java#L108)...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic edited a comment on pull request #3096: Exposing "Frontend UI Pages" to users of Java Frontend Application
Posted by GitBox <gi...@apache.org>.
sdedic edited a comment on pull request #3096:
URL: https://github.com/apache/netbeans/pull/3096#issuecomment-897435859
@JaroslavTulach Re. `-t`: no, Micronaut does not do that, as `-t` is supported by Gradle itself (there's a exec profile that adds `--continuous` by default). You can however register a declarative action provider ([see example action provider registration](https://github.com/apache/netbeans/blob/master/extide/gradle/test/unit/src/META-INF/generated-layer.xml#L24)) and can override the default action if a specific plugin is present in Gradle build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #3096: Exposing "Frontend UI Pages" to users of Java Frontend Application
Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #3096:
URL: https://github.com/apache/netbeans/pull/3096#issuecomment-897435859
Re. `-t`: no, Micronaut does not do that, as `-t` is supported by Gradle itself (there's a exec profile that adds `--continuous` by default). You can however register a declarative action provider ([see example action provider registration](https://github.com/apache/netbeans/blob/master/extide/gradle/test/unit/src/META-INF/generated-layer.xml#L24)) and can override the default action if a specific plugin is present in Gradle build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net merged pull request #3096: Exposing "Frontend UI Pages" to users of Java Frontend Application
Posted by GitBox <gi...@apache.org>.
neilcsmith-net merged pull request #3096:
URL: https://github.com/apache/netbeans/pull/3096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on pull request #3096: Exposing "Frontend UI Pages" to users of Java Frontend Application
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #3096:
URL: https://github.com/apache/netbeans/pull/3096#issuecomment-899355672
Eric, can this change be merged into `delivery` for 12.5?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #3096: Exposing "Frontend UI Pages" to users of Java Frontend Application
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #3096:
URL: https://github.com/apache/netbeans/pull/3096#discussion_r684897661
##########
File path: java/gradle.htmlui/src/org/netbeans/modules/gradle/htmlui/HtmlJavaPagesNodeFactory.java
##########
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.netbeans.modules.gradle.htmlui;
+
+import java.awt.Image;
+import org.netbeans.modules.gradle.api.NbGradleProject;
+import org.netbeans.modules.gradle.spi.nodes.AbstractGradleNodeList;
+import java.beans.PropertyChangeEvent;
+import java.beans.PropertyChangeListener;
+import java.util.Collections;
+import java.util.List;
+import javax.swing.event.ChangeListener;
+import org.netbeans.api.project.Project;
+import org.netbeans.spi.project.ui.support.NodeFactory;
+import org.netbeans.spi.project.ui.support.NodeList;
+import org.openide.filesystems.FileObject;
+import org.openide.loaders.DataFolder;
+import org.openide.nodes.FilterNode;
+import org.openide.nodes.Node;
+import org.openide.util.ImageUtilities;
+import org.openide.util.NbBundle;
+
+@NbBundle.Messages({
+ "MSG_HtmlJavaPages=Frontend UI Pages"
+})
+@NodeFactory.Registration(projectType = NbGradleProject.GRADLE_PROJECT_TYPE, position = 77)
+public final class HtmlJavaPagesNodeFactory implements NodeFactory {
+
+ @Override
+ public NodeList<?> createNodes(Project p) {
+ return new HtmlJavaPagesList(p);
+ }
+
+ private static class HtmlJavaPagesList extends AbstractGradleNodeList<FileObject> implements PropertyChangeListener {
+
+ final Project project;
+
+ HtmlJavaPagesList(Project project) {
+ this.project = project;
+ }
+
+ @Override
+ public List<FileObject> keys() {
+ FileObject pages = project.getProjectDirectory().getFileObject("src/main/webapp/pages"); // NOI18N
+ return pages != null ? Collections.singletonList(pages) : Collections.<FileObject>emptyList();
+ }
+
+ @Override
+ public Node node(FileObject key) {
+ DataFolder df = DataFolder.findFolder(key);
+ FilterNode fn = new FilterNode(df.getNodeDelegate().cloneNode()) {
+ @Override
+ public Image getIcon(int type) {
+ return ImageUtilities.loadImage("org/netbeans/modules/gradle/htmlui/DukeHTML.png"); // NOI18N
+ }
+
+ @Override
+ public Image getOpenedIcon(int type) {
+ return getIcon(type);
+ }
+
+ @Override
+ public String getName() {
+ return "pages"; // NOI18N
+ }
+
+ @Override
+ public String getDisplayName() {
+ return Bundle.MSG_HtmlJavaPages();
+ }
+ };
+ return fn;
+ }
+
+ @Override
+ public void propertyChange(PropertyChangeEvent evt) {
+ if (NbGradleProject.PROP_PROJECT_INFO.equals(evt.getPropertyName())) {
Review comment:
I admit I had no intent, I just copied [WebPagesNodeFactory](https://github.com/apache/netbeans/blob/master/enterprise/gradle.javaee/src/org/netbeans/modules/gradle/javaee/nodes/WebPagesNodeFactory.java#L72). Dump, complete (e.g. not even **selective**) [cluelessness](http://wiki.apidesign.org/wiki/Cluelessness)...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a change in pull request #3096: Exposing "Frontend UI Pages" to users of Java Frontend Application
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on a change in pull request #3096:
URL: https://github.com/apache/netbeans/pull/3096#discussion_r684895137
##########
File path: java/gradle.htmlui/src/org/netbeans/modules/gradle/htmlui/HtmlJavaPagesNodeFactory.java
##########
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.netbeans.modules.gradle.htmlui;
+
+import java.awt.Image;
+import org.netbeans.modules.gradle.api.NbGradleProject;
+import org.netbeans.modules.gradle.spi.nodes.AbstractGradleNodeList;
+import java.beans.PropertyChangeEvent;
+import java.beans.PropertyChangeListener;
+import java.util.Collections;
+import java.util.List;
+import javax.swing.event.ChangeListener;
+import org.netbeans.api.project.Project;
+import org.netbeans.spi.project.ui.support.NodeFactory;
+import org.netbeans.spi.project.ui.support.NodeList;
+import org.openide.filesystems.FileObject;
+import org.openide.loaders.DataFolder;
+import org.openide.nodes.FilterNode;
+import org.openide.nodes.Node;
+import org.openide.util.ImageUtilities;
+import org.openide.util.NbBundle;
+
+@NbBundle.Messages({
+ "MSG_HtmlJavaPages=Frontend UI Pages"
+})
+@NodeFactory.Registration(projectType = NbGradleProject.GRADLE_PROJECT_TYPE, position = 77)
+public final class HtmlJavaPagesNodeFactory implements NodeFactory {
+
+ @Override
+ public NodeList<?> createNodes(Project p) {
+ return new HtmlJavaPagesList(p);
+ }
+
+ private static class HtmlJavaPagesList extends AbstractGradleNodeList<FileObject> implements PropertyChangeListener {
+
+ final Project project;
+
+ HtmlJavaPagesList(Project project) {
+ this.project = project;
+ }
+
+ @Override
+ public List<FileObject> keys() {
+ FileObject pages = project.getProjectDirectory().getFileObject("src/main/webapp/pages"); // NOI18N
+ return pages != null ? Collections.singletonList(pages) : Collections.<FileObject>emptyList();
+ }
+
+ @Override
+ public Node node(FileObject key) {
+ DataFolder df = DataFolder.findFolder(key);
+ FilterNode fn = new FilterNode(df.getNodeDelegate().cloneNode()) {
+ @Override
+ public Image getIcon(int type) {
+ return ImageUtilities.loadImage("org/netbeans/modules/gradle/htmlui/DukeHTML.png"); // NOI18N
+ }
+
+ @Override
+ public Image getOpenedIcon(int type) {
+ return getIcon(type);
+ }
+
+ @Override
+ public String getName() {
+ return "pages"; // NOI18N
+ }
+
+ @Override
+ public String getDisplayName() {
+ return Bundle.MSG_HtmlJavaPages();
+ }
+ };
+ return fn;
+ }
+
+ @Override
+ public void propertyChange(PropertyChangeEvent evt) {
+ if (NbGradleProject.PROP_PROJECT_INFO.equals(evt.getPropertyName())) {
Review comment:
This would invoke change if the Gradle project files would be changed. Maybe the intent was to refresh on PROP_RESOURCES changes. Though in order that one to work you need to register a WatchedResourceProvider for "src/main/webapp/pages". In that case evt.getNewValue() will hold the URI of the changed resource.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists