You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2017/04/11 12:30:37 UTC

Review Request 58350: Updated GMock/GTest in stout.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58350/
-----------------------------------------------------------

Review request for mesos, Neil Conway and Till Toenshoff.


Bugs: MESOS-7364
    https://issues.apache.org/jira/browse/MESOS-7364


Repository: mesos


Description
-------

This will fix various issues that occured with version 1.7.0.
As GTest is now using 'std::tuple' instead of 'std::tr1::tuple', some
test cases have been updated accordingly.


Diffs
-----

  3rdparty/stout/3rdparty/Makefile.am 73f6e058eff6ed8b08d119fcb61bc28c8d30c346 
  3rdparty/stout/Makefile.am ebf1069eb1b787f063a2066a4db0b3f5de4a56da 
  3rdparty/stout/cmake/StoutTestsConfigure.cmake 685f1c840e1bdad0dcc4c6b0629a944cffbb309f 
  3rdparty/stout/configure.ac 50c1f6f0b1935a3770724c10f651190dcf002633 


Diff: https://reviews.apache.org/r/58350/diff/1/


Testing
-------

make check (on macOS, Linux, Windows)


Thanks,

Jan Schlicht

Re: Review Request 58350: Updated GMock/GTest in stout.

Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58350/#review175175
-----------------------------------------------------------


Ship it!




Commit description seems inaccurate: this commit does not remove references to `tr1`.

- Neil Conway


On May 15, 2017, 10:28 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58350/
> -----------------------------------------------------------
> 
> (Updated May 15, 2017, 10:28 a.m.)
> 
> 
> Review request for mesos, Neil Conway and Till Toenshoff.
> 
> 
> Bugs: MESOS-7364
>     https://issues.apache.org/jira/browse/MESOS-7364
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This will fix various issues that occured with version 1.7.0.
> As GTest is now using 'std::tuple' instead of 'std::tr1::tuple', some
> test cases have been updated accordingly.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/3rdparty/Makefile.am 73f6e058eff6ed8b08d119fcb61bc28c8d30c346 
>   3rdparty/stout/Makefile.am ebf1069eb1b787f063a2066a4db0b3f5de4a56da 
>   3rdparty/stout/cmake/StoutTestsConfigure.cmake 685f1c840e1bdad0dcc4c6b0629a944cffbb309f 
>   3rdparty/stout/configure.ac 50c1f6f0b1935a3770724c10f651190dcf002633 
> 
> 
> Diff: https://reviews.apache.org/r/58350/diff/2/
> 
> 
> Testing
> -------
> 
> Tested in https://reviews.apache.org/r/58351/
> 
> Don't commit without 58351.
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 58350: Updated GMock/GTest in stout.

Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58350/
-----------------------------------------------------------

(Updated May 15, 2017, 12:28 p.m.)


Review request for mesos, Neil Conway and Till Toenshoff.


Changes
-------

Rebased.


Bugs: MESOS-7364
    https://issues.apache.org/jira/browse/MESOS-7364


Repository: mesos


Description
-------

This will fix various issues that occured with version 1.7.0.
As GTest is now using 'std::tuple' instead of 'std::tr1::tuple', some
test cases have been updated accordingly.


Diffs (updated)
-----

  3rdparty/stout/3rdparty/Makefile.am 73f6e058eff6ed8b08d119fcb61bc28c8d30c346 
  3rdparty/stout/Makefile.am ebf1069eb1b787f063a2066a4db0b3f5de4a56da 
  3rdparty/stout/cmake/StoutTestsConfigure.cmake 685f1c840e1bdad0dcc4c6b0629a944cffbb309f 
  3rdparty/stout/configure.ac 50c1f6f0b1935a3770724c10f651190dcf002633 


Diff: https://reviews.apache.org/r/58350/diff/2/

Changes: https://reviews.apache.org/r/58350/diff/1-2/


Testing (updated)
-------

Tested in https://reviews.apache.org/r/58351/

Don't commit without 58351.


Thanks,

Jan Schlicht