You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/05/01 20:02:57 UTC

[GitHub] [hbase] joshelser commented on a change in pull request #1623: HBASE-24302 Add an "ignoreTimestamps" option (defaulted to false) to …

joshelser commented on a change in pull request #1623:
URL: https://github.com/apache/hbase/pull/1623#discussion_r418712804



##########
File path: hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestSyncTable.java
##########
@@ -463,26 +490,28 @@ private void writeTestData(TableName sourceTableName, TableName targetTableName)
     int numRows = 100;
     int sourceRegions = 10;
     int targetRegions = 6;
+    if (ArrayUtils.isEmpty(timestamps)) {

Review comment:
       If you make `timestamps` a `Pair`, that would make this a little more terse (avoid the ability for the caller to give you a single timestamp, or three timestamps)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org