You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Lei Xu <le...@cloudera.com> on 2017/04/20 20:56:39 UTC
Review Request 58593: SENTRY-1710. Reduce datanucleus key cache size
for
MSentryPermChange and MSentryPathChange tables to avoid holes in change IDs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58593/
-----------------------------------------------------------
Review request for sentry, Alexander Kolbasov, Hao Hao, kalyan kumar kalvagadda, and Na Li.
Bugs: SENTRY-1710
https://issues.apache.org/jira/browse/SENTRY-1710
Repository: sentry
Description
-------
As discussed in SENTRY-1643 and SENTRY-1706, MSentryPermChange and MSentryPathChange tables require that CHANGE ID of such changes to be unique and consecutive. SENTRY-1644 addressed this requirement in the application code, that requires multiple trips for each change record insertion, while it raises the possibility of collision on change ID when there are concurrently updates.
This patch change the ```key-cache-size``` to 1, as Lina suggested.
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPathChange.java 4b42ed02d7b6996ee9e460f346ebfefc44be9734
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPermChange.java a97d10ad92739ed17e543372024b6afb652fe0be
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo 81a4c6ecb271d8f04fe8caab1b52e8b4a2813ba1
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/DeltaTransactionBlock.java 8d3c88ba24eef76c6c07d06fb426e27b1d7d7f6b
Diff: https://reviews.apache.org/r/58593/diff/1/
Testing
-------
mvn test -Dtest=TestSentryStore
Thanks,
Lei Xu
Re: Review Request 58593: SENTRY-1710. Reduce datanucleus key cache
size for
MSentryPermChange and MSentryPathChange tables to avoid holes in change IDs.
Posted by Na Li <li...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58593/#review172562
-----------------------------------------------------------
Ship it!
Ship It!
- Na Li
On April 20, 2017, 8:56 p.m., Lei Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58593/
> -----------------------------------------------------------
>
> (Updated April 20, 2017, 8:56 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, kalyan kumar kalvagadda, and Na Li.
>
>
> Bugs: SENTRY-1710
> https://issues.apache.org/jira/browse/SENTRY-1710
>
>
> Repository: sentry
>
>
> Description
> -------
>
> As discussed in SENTRY-1643 and SENTRY-1706, MSentryPermChange and MSentryPathChange tables require that CHANGE ID of such changes to be unique and consecutive. SENTRY-1644 addressed this requirement in the application code, that requires multiple trips for each change record insertion, while it raises the possibility of collision on change ID when there are concurrently updates.
>
> This patch change the ```key-cache-size``` to 1, as Lina suggested.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPathChange.java 4b42ed02d7b6996ee9e460f346ebfefc44be9734
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPermChange.java a97d10ad92739ed17e543372024b6afb652fe0be
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo 81a4c6ecb271d8f04fe8caab1b52e8b4a2813ba1
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/DeltaTransactionBlock.java 8d3c88ba24eef76c6c07d06fb426e27b1d7d7f6b
>
>
> Diff: https://reviews.apache.org/r/58593/diff/1/
>
>
> Testing
> -------
>
> mvn test -Dtest=TestSentryStore
>
>
> Thanks,
>
> Lei Xu
>
>
Re: Review Request 58593: SENTRY-1710. Reduce datanucleus key cache
size for
MSentryPermChange and MSentryPathChange tables to avoid holes in change IDs.
Posted by Hao Hao <ha...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58593/#review172565
-----------------------------------------------------------
Ship it!
Ship It!
- Hao Hao
On April 20, 2017, 8:56 p.m., Lei Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58593/
> -----------------------------------------------------------
>
> (Updated April 20, 2017, 8:56 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, kalyan kumar kalvagadda, and Na Li.
>
>
> Bugs: SENTRY-1710
> https://issues.apache.org/jira/browse/SENTRY-1710
>
>
> Repository: sentry
>
>
> Description
> -------
>
> As discussed in SENTRY-1643 and SENTRY-1706, MSentryPermChange and MSentryPathChange tables require that CHANGE ID of such changes to be unique and consecutive. SENTRY-1644 addressed this requirement in the application code, that requires multiple trips for each change record insertion, while it raises the possibility of collision on change ID when there are concurrently updates.
>
> This patch change the ```key-cache-size``` to 1, as Lina suggested.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPathChange.java 4b42ed02d7b6996ee9e460f346ebfefc44be9734
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPermChange.java a97d10ad92739ed17e543372024b6afb652fe0be
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo 81a4c6ecb271d8f04fe8caab1b52e8b4a2813ba1
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/DeltaTransactionBlock.java 8d3c88ba24eef76c6c07d06fb426e27b1d7d7f6b
>
>
> Diff: https://reviews.apache.org/r/58593/diff/1/
>
>
> Testing
> -------
>
> mvn test -Dtest=TestSentryStore
>
>
> Thanks,
>
> Lei Xu
>
>
Re: Review Request 58593: SENTRY-1710. Reduce datanucleus key cache
size for
MSentryPermChange and MSentryPathChange tables to avoid holes in change IDs.
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58593/#review172564
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Kolbasov
On April 20, 2017, 8:56 p.m., Lei Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58593/
> -----------------------------------------------------------
>
> (Updated April 20, 2017, 8:56 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, kalyan kumar kalvagadda, and Na Li.
>
>
> Bugs: SENTRY-1710
> https://issues.apache.org/jira/browse/SENTRY-1710
>
>
> Repository: sentry
>
>
> Description
> -------
>
> As discussed in SENTRY-1643 and SENTRY-1706, MSentryPermChange and MSentryPathChange tables require that CHANGE ID of such changes to be unique and consecutive. SENTRY-1644 addressed this requirement in the application code, that requires multiple trips for each change record insertion, while it raises the possibility of collision on change ID when there are concurrently updates.
>
> This patch change the ```key-cache-size``` to 1, as Lina suggested.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPathChange.java 4b42ed02d7b6996ee9e460f346ebfefc44be9734
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPermChange.java a97d10ad92739ed17e543372024b6afb652fe0be
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo 81a4c6ecb271d8f04fe8caab1b52e8b4a2813ba1
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/DeltaTransactionBlock.java 8d3c88ba24eef76c6c07d06fb426e27b1d7d7f6b
>
>
> Diff: https://reviews.apache.org/r/58593/diff/1/
>
>
> Testing
> -------
>
> mvn test -Dtest=TestSentryStore
>
>
> Thanks,
>
> Lei Xu
>
>