[GitHub] [superset] michael-s-molina commented on pull request #13462: chore: Removes Popover duplication

[GitBox <gi...@apache.org>]

michael-s-molina commented on pull request #13462:
URL: https://github.com/apache/superset/pull/13462#issuecomment-790880065


   
   
   
   
   > It seems like `import Popover from 'src/components/Popover';` just loads a wrapper which effectively aliases `import { Popover } from 'src/common/components';` - should we just point directly to the latter, and remove `src/components/Popover`? It seems like the only reason to keep the wrapper would be if we intend to enhance or style the "stock" popover.
   
   Great question @rusackas! `src/common/components` will be deleted when we migrate all to `src/components`. The import in `src/components/Popover` is wrong, it should be `from antd`. I'll fix it!
   
   Later we'll create and index in src/components and export all with named exports. Then we could delete `src/components/Popover` if there's no customization.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org