[GitHub] [spark] squito commented on issue #24057: [SPARK-26839][SQL] Work around classloader changes in Java 9 for Hive isolation

[GitBox <gi...@apache.org>]

squito commented on issue #24057: [SPARK-26839][SQL] Work around classloader changes in Java 9 for Hive isolation
URL: https://github.com/apache/spark/pull/24057#issuecomment-472498661
 
 
   looks reasonable -- just want to mention again about the extra rule I needed in the list of shared prefixes for security:
   
   ```
       // needed for at least com.sun.security.auth.module.UnixLoginModule
       name.startsWith("com.sun") ||
   ```
   
   I don't have any insight yet into the datanucleus issues -- my fork has a different version of hive so I'm not encountering that issue (or at least, not yet).  the security thing may also be specific to my fork, though I doubt it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org