You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/08/15 23:40:17 UTC
[GitHub] [orc] dongjoon-hyun opened a new pull request #868: ORC-955: Add Javadoc generation GitHub Action job
dongjoon-hyun opened a new pull request #868:
URL: https://github.com/apache/orc/pull/868
### What changes were proposed in this pull request?
This PR aims to add a `javadoc` generation test coverage to prevent a future regression.
### Why are the changes needed?
Although Javadoc generation is a non-functional step, we had better remove the possibility of VOTE failure completely.
### How was this patch tested?
Pass the GitHub Action with the new job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] williamhyun merged pull request #868: ORC-955: Add Javadoc generation GitHub Action job
Posted by GitBox <gi...@apache.org>.
williamhyun merged pull request #868:
URL: https://github.com/apache/orc/pull/868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #868: ORC-955: Add Javadoc generation GitHub Action job
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #868:
URL: https://github.com/apache/orc/pull/868#issuecomment-899134501
Thank you, @williamhyun . I invite you as a collaborator of my Spark fork. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] williamhyun commented on pull request #868: ORC-955: Add Javadoc generation GitHub Action job
Posted by GitBox <gi...@apache.org>.
williamhyun commented on pull request #868:
URL: https://github.com/apache/orc/pull/868#issuecomment-899130765
@dongjoon-hyun
I merged #867 , could you rebase this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #868: ORC-955: Add Javadoc generation GitHub Action job
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #868:
URL: https://github.com/apache/orc/pull/868#issuecomment-899130858
Thank you for quick review. Yes, I rebased!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #868: ORC-955: Add Javadoc generation GitHub Action job
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #868:
URL: https://github.com/apache/orc/pull/868#issuecomment-899128633
cc @pgaref , @williamhyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org