You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/22 21:44:26 UTC
[GitHub] [beam] lukecwik opened a new pull request, #22005: [BEAM-6597] Replace ProgressRequestCallback with BundleProgressReporter
lukecwik opened a new pull request, #22005:
URL: https://github.com/apache/beam/pull/22005
This cleans up a TODO for a closed issue and moves short id logic to one time instantiation vs per bundle report for a minor perf improvement.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #22005: [BEAM-6597] Replace ProgressRequestCallback with BundleProgressReporter
Posted by GitBox <gi...@apache.org>.
lukecwik commented on PR #22005:
URL: https://github.com/apache/beam/pull/22005#issuecomment-1163900880
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #22005: [BEAM-6597] Replace ProgressRequestCallback with BundleProgressReporter
Posted by GitBox <gi...@apache.org>.
lukecwik commented on PR #22005:
URL: https://github.com/apache/beam/pull/22005#issuecomment-1169253353
> I am not familiar with harness. Went through once and just find a minor piece. Just curious, is the expected performance gain evaluated in some way (like [here](https://github.com/apache/beam/pull/22002)). Thanks!
It should help some but not a meaningful amount as this isn't happening on the element processing hot path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on a diff in pull request #22005: [BEAM-6597] Replace ProgressRequestCallback with BundleProgressReporter
Posted by GitBox <gi...@apache.org>.
lukecwik commented on code in PR #22005:
URL: https://github.com/apache/beam/pull/22005#discussion_r908965444
##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ProcessBundleHandler.java:
##########
@@ -1021,13 +991,12 @@ void shutdown() throws Exception {
public abstract static class BundleProcessor {
public static BundleProcessor create(
Cache<Object, Object> processWideCache,
- InMemory bundleProgressReporterAndRegistrar,
+ BundleProgressReporter.InMemory bundleProgressReporterAndRegistrar,
Review Comment:
Thanks I missed this one.
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik merged pull request #22005: [BEAM-6597] Replace ProgressRequestCallback with BundleProgressReporter
Posted by GitBox <gi...@apache.org>.
lukecwik merged PR #22005:
URL: https://github.com/apache/beam/pull/22005
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #22005: [BEAM-6597] Replace ProgressRequestCallback with BundleProgressReporter
Posted by GitBox <gi...@apache.org>.
lukecwik commented on PR #22005:
URL: https://github.com/apache/beam/pull/22005#issuecomment-1164540037
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #22005: [BEAM-6597] Replace ProgressRequestCallback with BundleProgressReporter
Posted by GitBox <gi...@apache.org>.
lukecwik commented on PR #22005:
URL: https://github.com/apache/beam/pull/22005#issuecomment-1169258872
@Abacn PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on a diff in pull request #22005: [BEAM-6597] Replace ProgressRequestCallback with BundleProgressReporter
Posted by GitBox <gi...@apache.org>.
Abacn commented on code in PR #22005:
URL: https://github.com/apache/beam/pull/22005#discussion_r908950043
##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ProcessBundleHandler.java:
##########
@@ -1021,13 +991,12 @@ void shutdown() throws Exception {
public abstract static class BundleProcessor {
public static BundleProcessor create(
Cache<Object, Object> processWideCache,
- InMemory bundleProgressReporterAndRegistrar,
+ BundleProgressReporter.InMemory bundleProgressReporterAndRegistrar,
Review Comment:
I see, there are two "InMemory" which are subclass of different interface. If so then may remove the import of `org.apache.beam.fn.harness.control.BundleProgressReporter.InMemory` and also change all other raw InMemory to `BundleProgressReporter.InMemory` in this file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #22005: [BEAM-6597] Replace ProgressRequestCallback with BundleProgressReporter
Posted by GitBox <gi...@apache.org>.
lukecwik commented on PR #22005:
URL: https://github.com/apache/beam/pull/22005#issuecomment-1163637338
This is dependent on https://github.com/apache/beam/pull/22002 being merged as a precursor to this.
CC: @apilloud @TheNeuralBit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #22005: [BEAM-6597] Replace ProgressRequestCallback with BundleProgressReporter
Posted by GitBox <gi...@apache.org>.
lukecwik commented on PR #22005:
URL: https://github.com/apache/beam/pull/22005#issuecomment-1170160793
Run Java_Examples_Dataflow_Java11 PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org