You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2017/09/27 15:22:52 UTC
[Impala-ASF-CR] IMPALA-5307: Part 3: remove TODO from RCFile
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8151
Change subject: IMPALA-5307: Part 3: remove TODO from RCFile
......................................................................
IMPALA-5307: Part 3: remove TODO from RCFile
Our RCFile implementations already copies out data (it sets
set_contains_tuple_data to false). Remove a TODO that suggests undoing
this. The current implementation is suboptimal but improving RCFile
performance is not a priority.
Change-Id: I594bb246cab64e15de750114890881a2ad9f504d
---
M be/src/exec/hdfs-rcfile-scanner.cc
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/8151/1
--
To view, visit http://gerrit.cloudera.org:8080/8151
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I594bb246cab64e15de750114890881a2ad9f504d
Gerrit-Change-Number: 8151
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-5307: Part 3: remove TODO from RCFile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8151 )
Change subject: IMPALA-5307: Part 3: remove TODO from RCFile
......................................................................
IMPALA-5307: Part 3: remove TODO from RCFile
Our RCFile implementations already copies out data (it sets
set_contains_tuple_data to false). Remove a TODO that suggests undoing
this. The current implementation is suboptimal but improving RCFile
performance is not a priority.
Change-Id: I594bb246cab64e15de750114890881a2ad9f504d
Reviewed-on: http://gerrit.cloudera.org:8080/8151
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/exec/hdfs-rcfile-scanner.cc
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8151
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I594bb246cab64e15de750114890881a2ad9f504d
Gerrit-Change-Number: 8151
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-5307: Part 3: remove TODO from RCFile
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8151 )
Change subject: IMPALA-5307: Part 3: remove TODO from RCFile
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8151
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I594bb246cab64e15de750114890881a2ad9f504d
Gerrit-Change-Number: 8151
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Sep 2017 15:27:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5307: Part 3: remove TODO from RCFile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8151 )
Change subject: IMPALA-5307: Part 3: remove TODO from RCFile
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1273/
--
To view, visit http://gerrit.cloudera.org:8080/8151
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I594bb246cab64e15de750114890881a2ad9f504d
Gerrit-Change-Number: 8151
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Sep 2017 17:51:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5307: Part 3: remove TODO from RCFile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8151 )
Change subject: IMPALA-5307: Part 3: remove TODO from RCFile
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/8151
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I594bb246cab64e15de750114890881a2ad9f504d
Gerrit-Change-Number: 8151
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Sep 2017 21:54:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5307: Part 3: remove TODO from RCFile
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8151 )
Change subject: IMPALA-5307: Part 3: remove TODO from RCFile
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8151
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I594bb246cab64e15de750114890881a2ad9f504d
Gerrit-Change-Number: 8151
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Sep 2017 17:51:48 +0000
Gerrit-HasComments: No