[GitHub] [beam] olehborysevych commented on a diff in pull request #24819: Playground Example CI fix for 24807

[GitBox <gi...@apache.org>]

olehborysevych commented on code in PR #24819:
URL: https://github.com/apache/beam/pull/24819#discussion_r1060630609


##########
.github/workflows/playground_examples_ci_reusable.yml:
##########
@@ -67,7 +67,7 @@ jobs:
           if [ -z "$BASE_REF" ] || [ "$BASE_REF" == "master" ]; then
             BASE_REF=origin/master
           fi
-          DIFF=$(git diff --name-only $BASE_REF $GITHUB_SHA | tr '\n' ' ')
+          DIFF=$(git diff --name-only --diff-filter=d $BASE_REF $GITHUB_SHA | tr '\n' ' ')

Review Comment:
   Danny,  there were renamed files in Damon's PR  but there was also deleted file. I've tested git-diff behaviour locally for different sets of changed/renamed/deleted files and renames are reported as a "new file name" entry in git-diff output which was handled correctly in checker.py. It was a deleted file that caused the issue: https://github.com/apache/beam/pull/24806/files 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org