You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/09/19 19:54:13 UTC

[GitHub] [nifi] eduardofontes commented on a change in pull request #3746: NIFI-6679 - Patch MoveHDFS

eduardofontes commented on a change in pull request #3746: NIFI-6679 - Patch MoveHDFS
URL: https://github.com/apache/nifi/pull/3746#discussion_r326355843
 
 

 ##########
 File path: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/MoveHDFS.java
 ##########
 @@ -357,9 +357,10 @@ public Object run() {
                         if (destinationExists) {
                             switch (processorConfig.getConflictResolution()) {
                                 case REPLACE_RESOLUTION:
-                                    if (hdfs.delete(file, false)) {
+                                    // Remove destination file (newFile) to replace
 
 Review comment:
   Ok @tpalfy . Thank you! I've just put your code in MoveHDFS test class.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services