You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/07/11 08:44:57 UTC

[GitHub] [dolphinscheduler] amaoisnb opened a new pull request, #10882: [Document-7870][docs] Modify the document system screenshot

amaoisnb opened a new pull request, #10882:
URL: https://github.com/apache/dolphinscheduler/pull/10882

   - Upgrade 3.0 and dev branch screenshot to laster
   - Upgrade Workflow Definition page
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #10882: [Document-7870][docs] Modify the document system screenshot

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #10882:
URL: https://github.com/apache/dolphinscheduler/pull/10882#issuecomment-1180183824

   thanks, and will task a look tonight


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #10882: [Document-7870][docs] Modify the document system screenshot

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #10882:
URL: https://github.com/apache/dolphinscheduler/pull/10882#discussion_r929790697


##########
docs/docs/zh/guide/start/quick-start.md:
##########
@@ -50,11 +50,11 @@
   * 点击工作流定义->创建工作流定义->上线工作流定义
 
 <p align="center">
-   <img src="../../../../img/dag1.png" width="60%" />
+   <img src="../../../../img/process_definition_en.png" width="60%" />

Review Comment:
   do you mean rename `process_definition_en` to `process_definition` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] amaoisnb commented on pull request #10882: [Document-7870][docs] Modify the document system screenshot

Posted by GitBox <gi...@apache.org>.
amaoisnb commented on PR #10882:
URL: https://github.com/apache/dolphinscheduler/pull/10882#issuecomment-1185155852

   > @amaoisnb change LGTM, but could you resolve the conflicts
   Okay, I'll try


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #10882: [Document-7870][docs] Modify the document system screenshot

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #10882:
URL: https://github.com/apache/dolphinscheduler/pull/10882#issuecomment-1195290805

   @amaoisnb I solve conflict by myself, hope you do not mind


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #10882: [Document-7870][docs] Modify the document system screenshot

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #10882:
URL: https://github.com/apache/dolphinscheduler/pull/10882#discussion_r929792412


##########
docs/docs/zh/guide/start/quick-start.md:
##########
@@ -50,11 +50,11 @@
   * 点击工作流定义->创建工作流定义->上线工作流定义
 
 <p align="center">
-   <img src="../../../../img/dag1.png" width="60%" />
+   <img src="../../../../img/process_definition_en.png" width="60%" />

Review Comment:
   > do you mean rename `process_definition_en` to `process_definition` ?
   
   oh, my bad, you mean `process_definition` vs `workflow` ? we should do it, but I think it is better to do it in separate PR, and change other related content, WDYT



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] amaoisnb closed pull request #10882: [Document-7870][docs] Modify the document system screenshot

Posted by GitBox <gi...@apache.org>.
amaoisnb closed pull request #10882: [Document-7870][docs] Modify the document system screenshot
URL: https://github.com/apache/dolphinscheduler/pull/10882


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #10882: [Document-7870][docs] Modify the document system screenshot

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #10882:
URL: https://github.com/apache/dolphinscheduler/pull/10882#issuecomment-1180527851

   Hi @amaoisnb we only need to use screenshot in English in our doc, so you should change file https://raw.githubusercontent.com/apache/dolphinscheduler/12fdd9bbd9d15dfe2a993731a2b5054ea5eb3956/docs/docs/zh/guide/start/quick-start.md and make them using the same picture in English version.
   
   and remvoe the exists img in path `img/dag1.png` and `img/task-log.png`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #10882: [Document-7870][docs] Modify the document system screenshot

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #10882:
URL: https://github.com/apache/dolphinscheduler/pull/10882#issuecomment-1183932090

   @amaoisnb change LGTM, but could you resolve the conflicts


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #10882: [Document-7870][docs] Modify the document system screenshot

Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #10882:
URL: https://github.com/apache/dolphinscheduler/pull/10882#discussion_r929788794


##########
docs/docs/zh/guide/start/quick-start.md:
##########
@@ -50,11 +50,11 @@
   * 点击工作流定义->创建工作流定义->上线工作流定义
 
 <p align="center">
-   <img src="../../../../img/dag1.png" width="60%" />
+   <img src="../../../../img/process_definition_en.png" width="60%" />

Review Comment:
   As we have discussed here before: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1175126227, what about renaming `process_definition_en` to `workflow_definition_en`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #10882: [Document-7870][docs] Modify the document system screenshot

Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #10882:
URL: https://github.com/apache/dolphinscheduler/pull/10882#discussion_r929804443


##########
docs/docs/zh/guide/start/quick-start.md:
##########
@@ -50,11 +50,11 @@
   * 点击工作流定义->创建工作流定义->上线工作流定义
 
 <p align="center">
-   <img src="../../../../img/dag1.png" width="60%" />
+   <img src="../../../../img/process_definition_en.png" width="60%" />

Review Comment:
   Sure, sounds good to me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org