[GitHub] [lucene-solr] madrob commented on a change in pull request #2089: SOLR-14999: Option to set the advertised port for Solr.

[GitBox <gi...@apache.org>]

madrob commented on a change in pull request #2089:
URL: https://github.com/apache/lucene-solr/pull/2089#discussion_r526487616



##########
File path: solr/solr-ref-guide/src/format-of-solr-xml.adoc
##########
@@ -134,9 +134,10 @@ The hostname Solr uses to access cores.
 The url context path.
 
 `hostPort`::
-The port Solr uses to access cores.
+The port Solr uses to access cores, and advertise Solr node locations through liveNodes.
 +
-In the default `solr.xml` file, this is set to `${jetty.port:8983}`, which will use the Solr port defined in Jetty, and otherwise fall back to 8983.
+In the default `solr.xml` file, this is set to `${solr.port.advertise:0}`.

Review comment:
       I'd like a sentence here giving an example why the user might care about it, i.e. solr running behind a proxy.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org