You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "XiaokaiWang (Code Review)" <ge...@cloudera.org> on 2019/08/02 16:38:09 UTC
[kudu-CR] testcase: with CheckRowCount instead of CheckRowCountWithRetries
XiaokaiWang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13989
Change subject: testcase: with CheckRowCount instead of CheckRowCountWithRetries
......................................................................
testcase: with CheckRowCount instead of CheckRowCountWithRetries
KUDU-796 was fixed. So, we need not retries when reading after a restart.
Change-Id: I0f2d535bd9519e0cdd3c4f3d63e57c5c3bb53ebd
---
M src/kudu/integration-tests/cluster_verifier.cc
M src/kudu/integration-tests/cluster_verifier.h
M src/kudu/integration-tests/ts_recovery-itest.cc
3 files changed, 15 insertions(+), 48 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/13989/1
--
To view, visit http://gerrit.cloudera.org:8080/13989
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0f2d535bd9519e0cdd3c4f3d63e57c5c3bb53ebd
Gerrit-Change-Number: 13989
Gerrit-PatchSet: 1
Gerrit-Owner: XiaokaiWang <xi...@live.com>
[kudu-CR] testcase: with CheckRowCount instead of CheckRowCountWithRetries
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13989 )
Change subject: testcase: with CheckRowCount instead of CheckRowCountWithRetries
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/13989
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I0f2d535bd9519e0cdd3c4f3d63e57c5c3bb53ebd
Gerrit-Change-Number: 13989
Gerrit-PatchSet: 2
Gerrit-Owner: XiaokaiWang <xi...@live.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] testcase: with CheckRowCount instead of CheckRowCountWithRetries
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13989 )
Change subject: testcase: with CheckRowCount instead of CheckRowCountWithRetries
......................................................................
testcase: with CheckRowCount instead of CheckRowCountWithRetries
KUDU-796 was fixed. So, we need not retries when reading after a restart.
Change-Id: I0f2d535bd9519e0cdd3c4f3d63e57c5c3bb53ebd
Reviewed-on: http://gerrit.cloudera.org:8080/13989
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/integration-tests/cluster_verifier.cc
M src/kudu/integration-tests/cluster_verifier.h
M src/kudu/integration-tests/ts_recovery-itest.cc
3 files changed, 15 insertions(+), 49 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/13989
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f2d535bd9519e0cdd3c4f3d63e57c5c3bb53ebd
Gerrit-Change-Number: 13989
Gerrit-PatchSet: 3
Gerrit-Owner: XiaokaiWang <xi...@live.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] testcase: with CheckRowCount instead of CheckRowCountWithRetries
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13989 )
Change subject: testcase: with CheckRowCount instead of CheckRowCountWithRetries
......................................................................
Patch Set 1:
Looks good though there's an IWYU issue to resolve.
--
To view, visit http://gerrit.cloudera.org:8080/13989
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f2d535bd9519e0cdd3c4f3d63e57c5c3bb53ebd
Gerrit-Change-Number: 13989
Gerrit-PatchSet: 1
Gerrit-Owner: XiaokaiWang <xi...@live.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 02 Aug 2019 17:24:40 +0000
Gerrit-HasComments: No
[kudu-CR] testcase: with CheckRowCount instead of CheckRowCountWithRetries
Posted by "XiaokaiWang (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13989
to look at the new patch set (#2).
Change subject: testcase: with CheckRowCount instead of CheckRowCountWithRetries
......................................................................
testcase: with CheckRowCount instead of CheckRowCountWithRetries
KUDU-796 was fixed. So, we need not retries when reading after a restart.
Change-Id: I0f2d535bd9519e0cdd3c4f3d63e57c5c3bb53ebd
---
M src/kudu/integration-tests/cluster_verifier.cc
M src/kudu/integration-tests/cluster_verifier.h
M src/kudu/integration-tests/ts_recovery-itest.cc
3 files changed, 15 insertions(+), 49 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/13989/2
--
To view, visit http://gerrit.cloudera.org:8080/13989
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0f2d535bd9519e0cdd3c4f3d63e57c5c3bb53ebd
Gerrit-Change-Number: 13989
Gerrit-PatchSet: 2
Gerrit-Owner: XiaokaiWang <xi...@live.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] testcase: with CheckRowCount instead of CheckRowCountWithRetries
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13989 )
Change subject: testcase: with CheckRowCount instead of CheckRowCountWithRetries
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13989
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f2d535bd9519e0cdd3c4f3d63e57c5c3bb53ebd
Gerrit-Change-Number: 13989
Gerrit-PatchSet: 2
Gerrit-Owner: XiaokaiWang <xi...@live.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sat, 03 Aug 2019 04:43:40 +0000
Gerrit-HasComments: No
[kudu-CR] testcase: with CheckRowCount instead of CheckRowCountWithRetries
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13989 )
Change subject: testcase: with CheckRowCount instead of CheckRowCountWithRetries
......................................................................
Patch Set 2: Code-Review+2
Overriding Jenkins, NTP sync issues in some tests.
--
To view, visit http://gerrit.cloudera.org:8080/13989
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f2d535bd9519e0cdd3c4f3d63e57c5c3bb53ebd
Gerrit-Change-Number: 13989
Gerrit-PatchSet: 2
Gerrit-Owner: XiaokaiWang <xi...@live.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sat, 03 Aug 2019 04:43:34 +0000
Gerrit-HasComments: No