You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "mstrucken (via GitHub)" <gi...@apache.org> on 2025/02/04 16:08:01 UTC
[PR] Fix ShellBolt log level (storm)
mstrucken opened a new pull request, #7955:
URL: https://github.com/apache/storm/pull/7955
## What is the purpose of the change
ShellBolt log level is always INFO due to failed check against Long after deseralizing
## How was the change tested
I used the following minimal example:
```java
String json = "{\"command\": \"log\", \"msg\": \"Testing ...\", \"level\": 4}";
try {
JSONObject msg = (JSONObject) JSONValue.parseWithException(json);
ShellMsg shellMsg = new ShellMsg();
String command = (String)msg.get("command");
if (command.equals("log")) {
Object logLevelObj = msg.get("level");
if (logLevelObj != null && logLevelObj instanceof Number) {
int logLevel = ((Number) logLevelObj).intValue();
shellMsg.setLogLevel(logLevel);
}
}
} catch (ParseException e) {
throw new RuntimeException(e);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix ShellBolt log level (storm)
Posted by "reiabreu (via GitHub)" <gi...@apache.org>.
reiabreu merged PR #7955:
URL: https://github.com/apache/storm/pull/7955
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix ShellBolt log level (storm)
Posted by "mstrucken (via GitHub)" <gi...@apache.org>.
mstrucken commented on PR #7955:
URL: https://github.com/apache/storm/pull/7955#issuecomment-2634428120
Fixes #7954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix ShellBolt log level (storm)
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on PR #7955:
URL: https://github.com/apache/storm/pull/7955#issuecomment-2634444040
@mstrucken Most likely: STORM-3961 :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix ShellBolt log level (storm)
Posted by "reiabreu (via GitHub)" <gi...@apache.org>.
reiabreu commented on PR #7955:
URL: https://github.com/apache/storm/pull/7955#issuecomment-2634969588
Thanks for a detailed issue and PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix ShellBolt log level (storm)
Posted by "mstrucken (via GitHub)" <gi...@apache.org>.
mstrucken commented on PR #7955:
URL: https://github.com/apache/storm/pull/7955#issuecomment-2634440187
> Thanks for the PR - very much appreciated! This is a regression from the switch to another json impl in the last year.
A colleague told me that it was introduced with 2.6.0, but I haven't found the exact commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org