You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "HaochengLIU (via GitHub)" <gi...@apache.org> on 2023/03/31 01:09:04 UTC

[GitHub] [arrow] HaochengLIU commented on a diff in pull request #34765: GH-14917: [C++] Error out when GTest is compiled with a C++ standard lower than 17

HaochengLIU commented on code in PR #34765:
URL: https://github.com/apache/arrow/pull/34765#discussion_r1153921278


##########
cpp/cmake_modules/SetupCxxFlags.cmake:
##########
@@ -115,6 +115,9 @@ elseif(ARROW_CPU_FLAG STREQUAL "aarch64")
   if(ARROW_SIMD_LEVEL STREQUAL "DEFAULT")
     set(ARROW_SIMD_LEVEL "NEON")
   endif()
+  if(APPLE)
+    set(GTest_SOURCE "BUNDLED")
+  endif()

Review Comment:
   Thanks for the suggestion @kou , I've updated the title of the PR and opened a new follow up issue. Please take a look when you have time



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org