You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@yunikorn.apache.org by "Weiwei Yang (Jira)" <ji...@apache.org> on 2020/04/08 04:46:00 UTC

[jira] [Updated] (YUNIKORN-82) Wrong revision in docker image

     [ https://issues.apache.org/jira/browse/YUNIKORN-82?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Weiwei Yang updated YUNIKORN-82:
--------------------------------
    Description: 
Reproduce steps
 # from k8shim, build the scheduler docker image, such as: yunikorn/yunikorn-scheduler-k8s:latest
 # then run "docker inspect yunikorn/yunikorn-scheduler-k8s:latest"
 # check Labels

 

{code} 

"Labels": {  

  "BuildTimeStamp": "2020-04-07T10:17:10-0700",

  "Version": "latest",   "yunikorn-core-revision": "20200403014952",

  "yunikorn-k8shim-revision": "0c83fd7f5ff5",

  "yunikorn-scheduler-interface-revision": "20200327234544"

}

 \{code}

Looks like the revision for {{yunikorn-core-revision}} and {{yunikorn-scheduler-interface-revision}} are incorrect. Code to set this is in Makefile

 
{code:java}
...
 @coreSHA=$$(go list -m "github.com/apache/incubator-yunikorn-core" | cut -d "-" -f4) ; \
 siSHA=$$(go list -m "github.com/apache/incubator-yunikorn-scheduler-interface" | cut -d "-" -f5) ; \
 shimSHA=$$(git rev-parse --short=12 HEAD) ; \
 docker build ./deployments/image/configmap -t ${REGISTRY}/yunikorn-scheduler-k8s:${VERSION} \
 --label "yunikorn-core-revision=$${coreSHA}" \
 --label "yunikorn-scheduler-interface-revision=$${siSHA}" \
 --label "yunikorn-k8shim-revision=$${shimSHA}" \
 --label "BuildTimeStamp=${DATE}" \
 --label "Version=${VERSION}"

{code}

  was:
Reproduce steps
 # from k8shim, build the scheduler docker image, such as: yunikorn/yunikorn-scheduler-k8s:latest
 # then run "docker inspect yunikorn/yunikorn-scheduler-k8s:latest"
 # check Labels

 

"Labels": {
  "BuildTimeStamp": "2020-04-07T10:17:10-0700",
  "Version": "latest",
  "yunikorn-core-revision": "20200403014952",
  "yunikorn-k8shim-revision": "0c83fd7f5ff5",
  "yunikorn-scheduler-interface-revision": "20200327234544"
 }

 

Looks like the revision for \{{yunikorn-core-revision}} and \{{yunikorn-scheduler-interface-revision}} are incorrect. Code to set this is in Makefile

 

{code}

...
 @coreSHA=$$(go list -m "github.com/apache/incubator-yunikorn-core" | cut -d "-" -f4) ; \
 siSHA=$$(go list -m "github.com/apache/incubator-yunikorn-scheduler-interface" | cut -d "-" -f5) ; \
 shimSHA=$$(git rev-parse --short=12 HEAD) ; \
 docker build ./deployments/image/configmap -t ${REGISTRY}/yunikorn-scheduler-k8s:${VERSION} \
 --label "yunikorn-core-revision=$${coreSHA}" \
 --label "yunikorn-scheduler-interface-revision=$${siSHA}" \
 --label "yunikorn-k8shim-revision=$${shimSHA}" \
 --label "BuildTimeStamp=${DATE}" \
 --label "Version=${VERSION}"

{code}


> Wrong revision in docker image
> ------------------------------
>
>                 Key: YUNIKORN-82
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-82
>             Project: Apache YuniKorn
>          Issue Type: Bug
>          Components: shim - kubernetes
>            Reporter: Weiwei Yang
>            Priority: Major
>              Labels: newbie
>
> Reproduce steps
>  # from k8shim, build the scheduler docker image, such as: yunikorn/yunikorn-scheduler-k8s:latest
>  # then run "docker inspect yunikorn/yunikorn-scheduler-k8s:latest"
>  # check Labels
>  
> {code} 
> "Labels": {  
>   "BuildTimeStamp": "2020-04-07T10:17:10-0700",
>   "Version": "latest",   "yunikorn-core-revision": "20200403014952",
>   "yunikorn-k8shim-revision": "0c83fd7f5ff5",
>   "yunikorn-scheduler-interface-revision": "20200327234544"
> }
>  \{code}
> Looks like the revision for {{yunikorn-core-revision}} and {{yunikorn-scheduler-interface-revision}} are incorrect. Code to set this is in Makefile
>  
> {code:java}
> ...
>  @coreSHA=$$(go list -m "github.com/apache/incubator-yunikorn-core" | cut -d "-" -f4) ; \
>  siSHA=$$(go list -m "github.com/apache/incubator-yunikorn-scheduler-interface" | cut -d "-" -f5) ; \
>  shimSHA=$$(git rev-parse --short=12 HEAD) ; \
>  docker build ./deployments/image/configmap -t ${REGISTRY}/yunikorn-scheduler-k8s:${VERSION} \
>  --label "yunikorn-core-revision=$${coreSHA}" \
>  --label "yunikorn-scheduler-interface-revision=$${siSHA}" \
>  --label "yunikorn-k8shim-revision=$${shimSHA}" \
>  --label "BuildTimeStamp=${DATE}" \
>  --label "Version=${VERSION}"
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org