You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Mark Hindess <ma...@googlemail.com> on 2009/08/13 23:52:19 UTC
[drlvm] Upgrading APR
DRLVM is using APR version 1.2.12 which was released in November 2007.
There have been numerous bug/security fixes since that time. I think we
should upgrade to APR version 1.3.8 which was on August 6th 2009.
I've tested the following patch on Linux/x86_64 and I am running tests
on Linux/x86 and windows/x86. Assuming the Linux/x86 and windows/x86
tests are okay, then I'd like to commit this patch (from inclusion in
M11).
Any objections?
Regards,
Mark
Index: working_vm/README.txt
===================================================================
--- working_vm/README.txt (revision 803806)
+++ working_vm/README.txt (working copy)
@@ -112,7 +112,7 @@
Apache Harmony site [http://harmony.apache.org/quickhelp_contributors.html].
Also, there are external resources required for building DRLVM:
-zlib, apr-1.2.12, log4cxx, cpptasks-1.b04, etc.
+zlib, apr-1.3.8, log4cxx, cpptasks-1.b04, etc.
This list can change as DRLVM is being developed, so the best way to resolve
external dependencies is to let the build download them:
$ ant fetch-depends
Index: working_vm/make/depends.properties
===================================================================
--- working_vm/make/depends.properties (revision 803806)
+++ working_vm/make/depends.properties (working copy)
@@ -25,10 +25,10 @@
# Apache Portable Runtime, version 1.1 or above
# http://apr.apache.org/download.cgi
-apr.src.tgz=${depends.oss}/apr/apr-1.2.12.tar.gz
-apr.src.rootdir=apr-1.2.12
-apr.src.tgz.url=http://archive.apache.org/dist/apr/apr-1.2.12.tar.gz
-apr.src.tgz.md5=020ea947446dca2d1210c099c7a4c837
+apr.src.tgz=${depends.oss}/apr/apr-1.3.8.tar.gz
+apr.src.rootdir=apr-1.3.8
+apr.src.tgz.url=http://www.apache.org/dist/apr/apr-1.3.8.tar.gz
+apr.src.tgz.md5=310fac12285d94a162c488f4b8f1aabc
# ZLIB, version 1.2.1 or above
# http://www.zlib.net/
Re: [drlvm] Upgrading APR
Posted by Sean Qiu <se...@gmail.com>.
+1
Thanks, Mark.
Best Regards
Sean, Xiao Xia Qiu
2009/8/14 Mark Hindess <ma...@googlemail.com>:
>
> DRLVM is using APR version 1.2.12 which was released in November 2007.
> There have been numerous bug/security fixes since that time. I think we
> should upgrade to APR version 1.3.8 which was on August 6th 2009.
>
> I've tested the following patch on Linux/x86_64 and I am running tests
> on Linux/x86 and windows/x86. Assuming the Linux/x86 and windows/x86
> tests are okay, then I'd like to commit this patch (from inclusion in
> M11).
>
> Any objections?
>
> Regards,
> Mark
>
> Index: working_vm/README.txt
> ===================================================================
> --- working_vm/README.txt (revision 803806)
> +++ working_vm/README.txt (working copy)
> @@ -112,7 +112,7 @@
> Apache Harmony site [http://harmony.apache.org/quickhelp_contributors.html].
>
> Also, there are external resources required for building DRLVM:
> -zlib, apr-1.2.12, log4cxx, cpptasks-1.b04, etc.
> +zlib, apr-1.3.8, log4cxx, cpptasks-1.b04, etc.
> This list can change as DRLVM is being developed, so the best way to resolve
> external dependencies is to let the build download them:
> $ ant fetch-depends
> Index: working_vm/make/depends.properties
> ===================================================================
> --- working_vm/make/depends.properties (revision 803806)
> +++ working_vm/make/depends.properties (working copy)
> @@ -25,10 +25,10 @@
>
> # Apache Portable Runtime, version 1.1 or above
> # http://apr.apache.org/download.cgi
> -apr.src.tgz=${depends.oss}/apr/apr-1.2.12.tar.gz
> -apr.src.rootdir=apr-1.2.12
> -apr.src.tgz.url=http://archive.apache.org/dist/apr/apr-1.2.12.tar.gz
> -apr.src.tgz.md5=020ea947446dca2d1210c099c7a4c837
> +apr.src.tgz=${depends.oss}/apr/apr-1.3.8.tar.gz
> +apr.src.rootdir=apr-1.3.8
> +apr.src.tgz.url=http://www.apache.org/dist/apr/apr-1.3.8.tar.gz
> +apr.src.tgz.md5=310fac12285d94a162c488f4b8f1aabc
>
> # ZLIB, version 1.2.1 or above
> # http://www.zlib.net/
>
>
>
Re: [drlvm] Upgrading APR
Posted by Oliver Deakin <ol...@googlemail.com>.
+1 to this also - Im giving the patch below a full test run on Windows
x86 at the moment, Ill let you know if anything turns up.
Regards,
Oliver
Mark Hindess wrote:
> DRLVM is using APR version 1.2.12 which was released in November 2007.
> There have been numerous bug/security fixes since that time. I think we
> should upgrade to APR version 1.3.8 which was on August 6th 2009.
>
> I've tested the following patch on Linux/x86_64 and I am running tests
> on Linux/x86 and windows/x86. Assuming the Linux/x86 and windows/x86
> tests are okay, then I'd like to commit this patch (from inclusion in
> M11).
>
> Any objections?
>
> Regards,
> Mark
>
> Index: working_vm/README.txt
> ===================================================================
> --- working_vm/README.txt (revision 803806)
> +++ working_vm/README.txt (working copy)
> @@ -112,7 +112,7 @@
> Apache Harmony site [http://harmony.apache.org/quickhelp_contributors.html].
>
> Also, there are external resources required for building DRLVM:
> -zlib, apr-1.2.12, log4cxx, cpptasks-1.b04, etc.
> +zlib, apr-1.3.8, log4cxx, cpptasks-1.b04, etc.
> This list can change as DRLVM is being developed, so the best way to resolve
> external dependencies is to let the build download them:
> $ ant fetch-depends
> Index: working_vm/make/depends.properties
> ===================================================================
> --- working_vm/make/depends.properties (revision 803806)
> +++ working_vm/make/depends.properties (working copy)
> @@ -25,10 +25,10 @@
>
> # Apache Portable Runtime, version 1.1 or above
> # http://apr.apache.org/download.cgi
> -apr.src.tgz=${depends.oss}/apr/apr-1.2.12.tar.gz
> -apr.src.rootdir=apr-1.2.12
> -apr.src.tgz.url=http://archive.apache.org/dist/apr/apr-1.2.12.tar.gz
> -apr.src.tgz.md5=020ea947446dca2d1210c099c7a4c837
> +apr.src.tgz=${depends.oss}/apr/apr-1.3.8.tar.gz
> +apr.src.rootdir=apr-1.3.8
> +apr.src.tgz.url=http://www.apache.org/dist/apr/apr-1.3.8.tar.gz
> +apr.src.tgz.md5=310fac12285d94a162c488f4b8f1aabc
>
> # ZLIB, version 1.2.1 or above
> # http://www.zlib.net/
>
>
>
>
--
Oliver Deakin
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
Re: [drlvm] Upgrading APR
Posted by Xiao-Feng Li <xi...@gmail.com>.
+1
On Fri, Aug 14, 2009 at 5:52 AM, Mark
Hindess<ma...@googlemail.com> wrote:
>
> DRLVM is using APR version 1.2.12 which was released in November 2007.
> There have been numerous bug/security fixes since that time. I think we
> should upgrade to APR version 1.3.8 which was on August 6th 2009.
>
> I've tested the following patch on Linux/x86_64 and I am running tests
> on Linux/x86 and windows/x86. Assuming the Linux/x86 and windows/x86
> tests are okay, then I'd like to commit this patch (from inclusion in
> M11).
>
> Any objections?
>
> Regards,
> Mark
>
> Index: working_vm/README.txt
> ===================================================================
> --- working_vm/README.txt (revision 803806)
> +++ working_vm/README.txt (working copy)
> @@ -112,7 +112,7 @@
> Apache Harmony site [http://harmony.apache.org/quickhelp_contributors.html].
>
> Also, there are external resources required for building DRLVM:
> -zlib, apr-1.2.12, log4cxx, cpptasks-1.b04, etc.
> +zlib, apr-1.3.8, log4cxx, cpptasks-1.b04, etc.
> This list can change as DRLVM is being developed, so the best way to resolve
> external dependencies is to let the build download them:
> $ ant fetch-depends
> Index: working_vm/make/depends.properties
> ===================================================================
> --- working_vm/make/depends.properties (revision 803806)
> +++ working_vm/make/depends.properties (working copy)
> @@ -25,10 +25,10 @@
>
> # Apache Portable Runtime, version 1.1 or above
> # http://apr.apache.org/download.cgi
> -apr.src.tgz=${depends.oss}/apr/apr-1.2.12.tar.gz
> -apr.src.rootdir=apr-1.2.12
> -apr.src.tgz.url=http://archive.apache.org/dist/apr/apr-1.2.12.tar.gz
> -apr.src.tgz.md5=020ea947446dca2d1210c099c7a4c837
> +apr.src.tgz=${depends.oss}/apr/apr-1.3.8.tar.gz
> +apr.src.rootdir=apr-1.3.8
> +apr.src.tgz.url=http://www.apache.org/dist/apr/apr-1.3.8.tar.gz
> +apr.src.tgz.md5=310fac12285d94a162c488f4b8f1aabc
>
> # ZLIB, version 1.2.1 or above
> # http://www.zlib.net/
>
>
>
--
http://people.apache.org/~xli
Re: [drlvm] Upgrading APR
Posted by Oliver Deakin <ol...@googlemail.com>.
Mark Hindess wrote:
> In message <4A...@gmail.com>, Tim Ellison writes:
>
>> On 13/Aug/2009 22:56, Pavel Pervov wrote:
>>
>>> +1. This also makes APR buildable with VS 2K8. Thanks for the effort.
>>>
>> Almost. I have a few changes sat in my workspace that are also
>> required. I will commit them after Mark updates APR.
>>
>
> Ok. My tests ran okay on Linux/x86, Linux/x86_64 and Windows/x86 so I've
> committed the upgrade in r804151.
>
My tests on Windows x86 also ran well with no new failures.
Regards,
Oliver
> I notice that there are changes to the LICENSE/NOTICE files in APR 1.3.8
> (appended below). Do we need to replicate these in our corresponding
> files.
>
> Regards,
> Mark.
>
> --- semis/apr/src/LICENSE 2004-12-05 21:34:37.000000000 +0000
> +++ semis/apr/src/LICENSE 2008-05-02 18:26:59.000000000 +0100
> @@ -295,3 +295,47 @@
> misrepresented as being the original software.
> 3. This notice may not be removed or altered from any source distribution.
>
> +From strings/apr_snprintf.c:
> +
> + *
> + * cvt - IEEE floating point formatting routines.
> + * Derived from UNIX V7, Copyright(C) Caldera International Inc.
> + *
> +
> + Copyright(C) Caldera International Inc. 2001-2002. All rights reserved.
> +
> + Redistribution and use in source and binary forms, with or without
> + modification, are permitted provided that the following conditions are
> + met:
> +
> + Redistributions of source code and documentation must retain the above
> + copyright notice, this list of conditions and the following disclaimer.
> +
> + Redistributions in binary form must reproduce the above copyright
> + notice, this list of conditions and the following disclaimer in the
> + documentation and/or other materials provided with the distribution.
> +
> + All advertising materials mentioning features or use of this software
> + must display the following acknowledgement:
> +
> + This product includes software developed or owned by Caldera
> + International, Inc.
> +
> + Neither the name of Caldera International, Inc. nor the names of other
> + contributors may be used to endorse or promote products derived from
> + this software without specific prior written permission.
> +
> + USE OF THE SOFTWARE PROVIDED FOR UNDER THIS LICENSE BY CALDERA
> + INTERNATIONAL, INC. AND CONTRIBUTORS ``AS IS'' AND ANY EXPRESS OR IMPLIED
> + WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
> + MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN
> + NO EVENT SHALL CALDERA INTERNATIONAL, INC. BE LIABLE FOR ANY DIRECT,
> + INDIRECT INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
> + (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
> + SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
> + HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
> + STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
> + ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> + POSSIBILITY OF SUCH DAMAGE.
> +
> +
> --- semis/apr/src/NOTICE 2004-11-24 22:51:51.000000000 +0000
> +++ semis/apr/src/NOTICE 2009-07-02 03:45:11.000000000 +0100
> @@ -1,3 +1,6 @@
> +Apache Portable Runtime
> +Copyright (c) 2009 The Apache Software Foundation.
> +
> This product includes software developed by
> The Apache Software Foundation (http://www.apache.org/).
>
> @@ -7,3 +10,6 @@
>
> This software contains code derived from the RSA Data Security
> Inc. MD5 Message-Digest Algorithm.
> +
> +This software contains code derived from UNIX V7, Copyright(C)
> +Caldera International Inc.
>
>
>
>
--
Oliver Deakin
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
Re: [drlvm] Upgrading APR
Posted by Mark Hindess <ma...@googlemail.com>.
In message <4A...@gmail.com>, Tim Ellison writes:
>
> On 13/Aug/2009 22:56, Pavel Pervov wrote:
> > +1. This also makes APR buildable with VS 2K8. Thanks for the effort.
>
> Almost. I have a few changes sat in my workspace that are also
> required. I will commit them after Mark updates APR.
Ok. My tests ran okay on Linux/x86, Linux/x86_64 and Windows/x86 so I've
committed the upgrade in r804151.
I notice that there are changes to the LICENSE/NOTICE files in APR 1.3.8
(appended below). Do we need to replicate these in our corresponding
files.
Regards,
Mark.
--- semis/apr/src/LICENSE 2004-12-05 21:34:37.000000000 +0000
+++ semis/apr/src/LICENSE 2008-05-02 18:26:59.000000000 +0100
@@ -295,3 +295,47 @@
misrepresented as being the original software.
3. This notice may not be removed or altered from any source distribution.
+From strings/apr_snprintf.c:
+
+ *
+ * cvt - IEEE floating point formatting routines.
+ * Derived from UNIX V7, Copyright(C) Caldera International Inc.
+ *
+
+ Copyright(C) Caldera International Inc. 2001-2002. All rights reserved.
+
+ Redistribution and use in source and binary forms, with or without
+ modification, are permitted provided that the following conditions are
+ met:
+
+ Redistributions of source code and documentation must retain the above
+ copyright notice, this list of conditions and the following disclaimer.
+
+ Redistributions in binary form must reproduce the above copyright
+ notice, this list of conditions and the following disclaimer in the
+ documentation and/or other materials provided with the distribution.
+
+ All advertising materials mentioning features or use of this software
+ must display the following acknowledgement:
+
+ This product includes software developed or owned by Caldera
+ International, Inc.
+
+ Neither the name of Caldera International, Inc. nor the names of other
+ contributors may be used to endorse or promote products derived from
+ this software without specific prior written permission.
+
+ USE OF THE SOFTWARE PROVIDED FOR UNDER THIS LICENSE BY CALDERA
+ INTERNATIONAL, INC. AND CONTRIBUTORS ``AS IS'' AND ANY EXPRESS OR IMPLIED
+ WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
+ MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN
+ NO EVENT SHALL CALDERA INTERNATIONAL, INC. BE LIABLE FOR ANY DIRECT,
+ INDIRECT INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+ SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+ HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
+ STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
+ ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ POSSIBILITY OF SUCH DAMAGE.
+
+
--- semis/apr/src/NOTICE 2004-11-24 22:51:51.000000000 +0000
+++ semis/apr/src/NOTICE 2009-07-02 03:45:11.000000000 +0100
@@ -1,3 +1,6 @@
+Apache Portable Runtime
+Copyright (c) 2009 The Apache Software Foundation.
+
This product includes software developed by
The Apache Software Foundation (http://www.apache.org/).
@@ -7,3 +10,6 @@
This software contains code derived from the RSA Data Security
Inc. MD5 Message-Digest Algorithm.
+
+This software contains code derived from UNIX V7, Copyright(C)
+Caldera International Inc.
Re: [drlvm] Upgrading APR
Posted by Tim Ellison <t....@gmail.com>.
On 13/Aug/2009 22:56, Pavel Pervov wrote:
> +1. This also makes APR buildable with VS 2K8. Thanks for the effort.
Almost. I have a few changes sat in my workspace that are also
required. I will commit them after Mark updates APR.
Regards,
Tim
Re: [drlvm] Upgrading APR
Posted by Pavel Pervov <pm...@gmail.com>.
Mark.
+1. This also makes APR buildable with VS 2K8. Thanks for the effort.
Pavel.
On Fri, Aug 14, 2009 at 1:52 AM, Mark
Hindess<ma...@googlemail.com> wrote:
>
> DRLVM is using APR version 1.2.12 which was released in November 2007.
> There have been numerous bug/security fixes since that time. I think we
> should upgrade to APR version 1.3.8 which was on August 6th 2009.
>
> I've tested the following patch on Linux/x86_64 and I am running tests
> on Linux/x86 and windows/x86. Assuming the Linux/x86 and windows/x86
> tests are okay, then I'd like to commit this patch (from inclusion in
> M11).
>
> Any objections?
>
> Regards,
> Mark
>
> Index: working_vm/README.txt
> ===================================================================
> --- working_vm/README.txt (revision 803806)
> +++ working_vm/README.txt (working copy)
> @@ -112,7 +112,7 @@
> Apache Harmony site [http://harmony.apache.org/quickhelp_contributors.html].
>
> Also, there are external resources required for building DRLVM:
> -zlib, apr-1.2.12, log4cxx, cpptasks-1.b04, etc.
> +zlib, apr-1.3.8, log4cxx, cpptasks-1.b04, etc.
> This list can change as DRLVM is being developed, so the best way to resolve
> external dependencies is to let the build download them:
> $ ant fetch-depends
> Index: working_vm/make/depends.properties
> ===================================================================
> --- working_vm/make/depends.properties (revision 803806)
> +++ working_vm/make/depends.properties (working copy)
> @@ -25,10 +25,10 @@
>
> # Apache Portable Runtime, version 1.1 or above
> # http://apr.apache.org/download.cgi
> -apr.src.tgz=${depends.oss}/apr/apr-1.2.12.tar.gz
> -apr.src.rootdir=apr-1.2.12
> -apr.src.tgz.url=http://archive.apache.org/dist/apr/apr-1.2.12.tar.gz
> -apr.src.tgz.md5=020ea947446dca2d1210c099c7a4c837
> +apr.src.tgz=${depends.oss}/apr/apr-1.3.8.tar.gz
> +apr.src.rootdir=apr-1.3.8
> +apr.src.tgz.url=http://www.apache.org/dist/apr/apr-1.3.8.tar.gz
> +apr.src.tgz.md5=310fac12285d94a162c488f4b8f1aabc
>
> # ZLIB, version 1.2.1 or above
> # http://www.zlib.net/
>
>
>