You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@wicket.apache.org by Matthew Hanlon <mr...@gmail.com> on 2008/11/21 23:26:05 UTC
Make FeedbackMessages#add(FeedbackMessage) public?
Greetings!
Is there any reason why FeedbackMessages#add(FeedbackMessage) is package
private? I'd like to be able to just stick a FeedbackMessage directly in my
Session rather than having to call add(Component, String, int), info(...),
error(...), warn(...), fatal(...) or debug(...).
Alternatively, but probably more disruptive, could the signature of the add,
info, warn, fatal and debug methods be changed from taking a String object
to taking a Serializable, like the error method does? This would achieve
what I am looking for.
Basically, I have a javascript FeedbackPanel which works on a subclass of
FeedbackMessage. I wrap my javascript foo as the serializable object in the
FeedbackMessage. This works great for all component feedback, but I came
across a case where I'd like to stick a feedback message in my session for
events such as the first visit to a page, for example, and this message kind
of falls outside the standard feedback levels. I'd like to be able to
manually create my js message, wrap it in a FeedbackMessage and stick it in
the session.
If there is a better suggestion, I'd be open to that, too! Thanks!
Regards,
Matt.
--
Matthew Rollins Hanlon
http://squareoftwo.org
_____________________
Hanlon's Razor:
"Never attribute to malice that which can be adequately explained by
stupidity."
http://wikipedia.org/wiki/Hanlon's_razor
Re: Make FeedbackMessages#add(FeedbackMessage) public?
Posted by Matthew Hanlon <mr...@gmail.com>.
That's great. Thanks.
Regards,
Matthew.
On Sat, Nov 22, 2008 at 12:47 PM, Igor Vaynberg <ig...@gmail.com> wrote:
> it is now public.
>
> as far as tweaking this further, we already have this on the wishlist
> for 1.5 but for 1.4 we do not want to break the api too much.
>
> -igor
>
> On Fri, Nov 21, 2008 at 2:26 PM, Matthew Hanlon <mr...@gmail.com> wrote:
>> Greetings!
>> Is there any reason why FeedbackMessages#add(FeedbackMessage) is package
>> private? I'd like to be able to just stick a FeedbackMessage directly in my
>> Session rather than having to call add(Component, String, int), info(...),
>> error(...), warn(...), fatal(...) or debug(...).
>>
>> Alternatively, but probably more disruptive, could the signature of the add,
>> info, warn, fatal and debug methods be changed from taking a String object
>> to taking a Serializable, like the error method does? This would achieve
>> what I am looking for.
>>
>> Basically, I have a javascript FeedbackPanel which works on a subclass of
>> FeedbackMessage. I wrap my javascript foo as the serializable object in the
>> FeedbackMessage. This works great for all component feedback, but I came
>> across a case where I'd like to stick a feedback message in my session for
>> events such as the first visit to a page, for example, and this message kind
>> of falls outside the standard feedback levels. I'd like to be able to
>> manually create my js message, wrap it in a FeedbackMessage and stick it in
>> the session.
>>
>> If there is a better suggestion, I'd be open to that, too! Thanks!
>>
>> Regards,
>> Matt.
>>
>> --
>> Matthew Rollins Hanlon
>> http://squareoftwo.org
>> _____________________
>> Hanlon's Razor:
>> "Never attribute to malice that which can be adequately explained by
>> stupidity."
>> http://wikipedia.org/wiki/Hanlon's_razor
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
>
--
Matthew Rollins Hanlon
http://squareoftwo.org
_____________________
Hanlon's Razor:
"Never attribute to malice that which can be adequately explained by stupidity."
http://wikipedia.org/wiki/Hanlon's_razor
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: Make FeedbackMessages#add(FeedbackMessage) public?
Posted by Igor Vaynberg <ig...@gmail.com>.
it is now public.
as far as tweaking this further, we already have this on the wishlist
for 1.5 but for 1.4 we do not want to break the api too much.
-igor
On Fri, Nov 21, 2008 at 2:26 PM, Matthew Hanlon <mr...@gmail.com> wrote:
> Greetings!
> Is there any reason why FeedbackMessages#add(FeedbackMessage) is package
> private? I'd like to be able to just stick a FeedbackMessage directly in my
> Session rather than having to call add(Component, String, int), info(...),
> error(...), warn(...), fatal(...) or debug(...).
>
> Alternatively, but probably more disruptive, could the signature of the add,
> info, warn, fatal and debug methods be changed from taking a String object
> to taking a Serializable, like the error method does? This would achieve
> what I am looking for.
>
> Basically, I have a javascript FeedbackPanel which works on a subclass of
> FeedbackMessage. I wrap my javascript foo as the serializable object in the
> FeedbackMessage. This works great for all component feedback, but I came
> across a case where I'd like to stick a feedback message in my session for
> events such as the first visit to a page, for example, and this message kind
> of falls outside the standard feedback levels. I'd like to be able to
> manually create my js message, wrap it in a FeedbackMessage and stick it in
> the session.
>
> If there is a better suggestion, I'd be open to that, too! Thanks!
>
> Regards,
> Matt.
>
> --
> Matthew Rollins Hanlon
> http://squareoftwo.org
> _____________________
> Hanlon's Razor:
> "Never attribute to malice that which can be adequately explained by
> stupidity."
> http://wikipedia.org/wiki/Hanlon's_razor
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org