You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Suresh Srinivas (Created) (JIRA)" <ji...@apache.org> on 2012/04/06 00:46:25 UTC
[jira] [Created] (HDFS-3211) JournalProtocol changes required for
introducing epoch and fencing
JournalProtocol changes required for introducing epoch and fencing
------------------------------------------------------------------
Key: HDFS-3211
URL: https://issues.apache.org/jira/browse/HDFS-3211
Project: Hadoop HDFS
Issue Type: Sub-task
Components: ha, name-node
Reporter: Suresh Srinivas
JournalProtocol changes to introduce epoch in every request. Adding new method fence for fencing a JournalService. On BackupNode fence is a no-op.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3211) JournalProtocol changes required for
introducing epoch and fencing
Posted by "Tsz Wo (Nicholas), SZE (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-3211:
-----------------------------------------
Hadoop Flags: Reviewed
+1 patch looks good.
> JournalProtocol changes required for introducing epoch and fencing
> ------------------------------------------------------------------
>
> Key: HDFS-3211
> URL: https://issues.apache.org/jira/browse/HDFS-3211
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: Shared journals (HDFS-3092)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt
>
>
> JournalProtocol changes to introduce epoch in every request. Adding new method fence for fencing a JournalService. On BackupNode fence is a no-op.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3211) JournalProtocol changes required for
introducing epoch and fencing
Posted by "Todd Lipcon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247790#comment-13247790 ]
Todd Lipcon commented on HDFS-3211:
-----------------------------------
Hi Suresh. Have you looked at HDFS-3189? Hopefully we can make our protocols similar with the intent of eventually merging the two implementations.
> JournalProtocol changes required for introducing epoch and fencing
> ------------------------------------------------------------------
>
> Key: HDFS-3211
> URL: https://issues.apache.org/jira/browse/HDFS-3211
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: Shared journals (HDFS-3092)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
>
> JournalProtocol changes to introduce epoch in every request. Adding new method fence for fencing a JournalService. On BackupNode fence is a no-op.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3211) JournalProtocol changes required for
introducing epoch and fencing
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249252#comment-13249252 ]
Hudson commented on HDFS-3211:
------------------------------
Integrated in Hadoop-Hdfs-trunk #1007 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1007/])
HDFS-3211. Add fence(..) and replace NamenodeRegistration with JournalInfo and epoch in JournalProtocol. Contributed by suresh (Revision 1310649)
Result = FAILURE
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310649
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/UnregisteredNodeException.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/JournalProtocolServerSideTranslatorPB.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/JournalProtocolTranslatorPB.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelper.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/journalservice/JournalService.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupJournalManager.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EditLogBackupOutputStream.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/FenceResponse.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/FencedException.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/JournalInfo.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/JournalProtocol.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/proto/JournalProtocol.proto
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/journalservice/TestJournalService.java
> JournalProtocol changes required for introducing epoch and fencing
> ------------------------------------------------------------------
>
> Key: HDFS-3211
> URL: https://issues.apache.org/jira/browse/HDFS-3211
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: Shared journals (HDFS-3092)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 3.0.0
>
> Attachments: HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt
>
>
> JournalProtocol changes to introduce epoch in every request. Adding new method fence for fencing a JournalService. On BackupNode fence is a no-op.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3211) JournalProtocol changes required for
introducing epoch and fencing
Posted by "Suresh Srinivas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HDFS-3211:
----------------------------------
Status: Patch Available (was: Open)
> JournalProtocol changes required for introducing epoch and fencing
> ------------------------------------------------------------------
>
> Key: HDFS-3211
> URL: https://issues.apache.org/jira/browse/HDFS-3211
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: Shared journals (HDFS-3092)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt
>
>
> JournalProtocol changes to introduce epoch in every request. Adding new method fence for fencing a JournalService. On BackupNode fence is a no-op.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3211) JournalProtocol changes required for
introducing epoch and fencing
Posted by "Suresh Srinivas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HDFS-3211:
----------------------------------
Attachment: (was: HDFS-3211.txt)
> JournalProtocol changes required for introducing epoch and fencing
> ------------------------------------------------------------------
>
> Key: HDFS-3211
> URL: https://issues.apache.org/jira/browse/HDFS-3211
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: Shared journals (HDFS-3092)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt
>
>
> JournalProtocol changes to introduce epoch in every request. Adding new method fence for fencing a JournalService. On BackupNode fence is a no-op.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3211) JournalProtocol changes required for
introducing epoch and fencing
Posted by "Suresh Srinivas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HDFS-3211:
----------------------------------
Attachment: HDFS-3211.txt
Updated patch with missing files.
> JournalProtocol changes required for introducing epoch and fencing
> ------------------------------------------------------------------
>
> Key: HDFS-3211
> URL: https://issues.apache.org/jira/browse/HDFS-3211
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: Shared journals (HDFS-3092)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt
>
>
> JournalProtocol changes to introduce epoch in every request. Adding new method fence for fencing a JournalService. On BackupNode fence is a no-op.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3211) JournalProtocol changes required for
introducing epoch and fencing
Posted by "Suresh Srinivas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HDFS-3211:
----------------------------------
Attachment: HDFS-3211.txt
> JournalProtocol changes required for introducing epoch and fencing
> ------------------------------------------------------------------
>
> Key: HDFS-3211
> URL: https://issues.apache.org/jira/browse/HDFS-3211
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: Shared journals (HDFS-3092)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt
>
>
> JournalProtocol changes to introduce epoch in every request. Adding new method fence for fencing a JournalService. On BackupNode fence is a no-op.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3211) JournalProtocol changes required for
introducing epoch and fencing
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-3211:
-----------------------------------------
Attachment: h3211_20120511_branch-2.patch
h3211_20120511_branch-2.patch: for branch-2.
> JournalProtocol changes required for introducing epoch and fencing
> ------------------------------------------------------------------
>
> Key: HDFS-3211
> URL: https://issues.apache.org/jira/browse/HDFS-3211
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: Shared journals (HDFS-3092)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 3.0.0
>
> Attachments: HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, h3211_20120511_branch-2.patch
>
>
> JournalProtocol changes to introduce epoch in every request. Adding new method fence for fencing a JournalService. On BackupNode fence is a no-op.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3211) JournalProtocol changes required for
introducing epoch and fencing
Posted by "Suresh Srinivas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HDFS-3211:
----------------------------------
Attachment: HDFS-3211.txt
> JournalProtocol changes required for introducing epoch and fencing
> ------------------------------------------------------------------
>
> Key: HDFS-3211
> URL: https://issues.apache.org/jira/browse/HDFS-3211
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: Shared journals (HDFS-3092)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HDFS-3211.txt
>
>
> JournalProtocol changes to introduce epoch in every request. Adding new method fence for fencing a JournalService. On BackupNode fence is a no-op.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3211) JournalProtocol changes required for
introducing epoch and fencing
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249112#comment-13249112 ]
Hudson commented on HDFS-3211:
------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2037 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2037/])
HDFS-3211. Add fence(..) and replace NamenodeRegistration with JournalInfo and epoch in JournalProtocol. Contributed by suresh (Revision 1310649)
Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310649
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/UnregisteredNodeException.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/JournalProtocolServerSideTranslatorPB.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/JournalProtocolTranslatorPB.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelper.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/journalservice/JournalService.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupJournalManager.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EditLogBackupOutputStream.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/FenceResponse.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/FencedException.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/JournalInfo.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/JournalProtocol.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/proto/JournalProtocol.proto
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/journalservice/TestJournalService.java
> JournalProtocol changes required for introducing epoch and fencing
> ------------------------------------------------------------------
>
> Key: HDFS-3211
> URL: https://issues.apache.org/jira/browse/HDFS-3211
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: Shared journals (HDFS-3092)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 3.0.0
>
> Attachments: HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt
>
>
> JournalProtocol changes to introduce epoch in every request. Adding new method fence for fencing a JournalService. On BackupNode fence is a no-op.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3211) JournalProtocol changes required for
introducing epoch and fencing
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273805#comment-13273805 ]
Hudson commented on HDFS-3211:
------------------------------
Integrated in Hadoop-Common-trunk-Commit #2236 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2236/])
Move HDFS-3211 to 2.0.0 in CHANGES.txt. (Revision 1337432)
Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1337432
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
> JournalProtocol changes required for introducing epoch and fencing
> ------------------------------------------------------------------
>
> Key: HDFS-3211
> URL: https://issues.apache.org/jira/browse/HDFS-3211
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: Shared journals (HDFS-3092)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 2.0.0, 3.0.0
>
> Attachments: HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, h3211_20120511_branch-2.patch
>
>
> JournalProtocol changes to introduce epoch in every request. Adding new method fence for fencing a JournalService. On BackupNode fence is a no-op.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3211) JournalProtocol changes required for
introducing epoch and fencing
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-3211:
-----------------------------------------
Fix Version/s: 2.0.0
I merged this to branch-2 (instead of using h3211_20120511_branch-2.patch). I skipped the journalservice changes in the merge.
> JournalProtocol changes required for introducing epoch and fencing
> ------------------------------------------------------------------
>
> Key: HDFS-3211
> URL: https://issues.apache.org/jira/browse/HDFS-3211
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: Shared journals (HDFS-3092)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 2.0.0, 3.0.0
>
> Attachments: HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, h3211_20120511_branch-2.patch
>
>
> JournalProtocol changes to introduce epoch in every request. Adding new method fence for fencing a JournalService. On BackupNode fence is a no-op.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3211) JournalProtocol changes required for
introducing epoch and fencing
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247988#comment-13247988 ]
Hadoop QA commented on HDFS-3211:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12521626/HDFS-3211.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2209//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2209//console
This message is automatically generated.
> JournalProtocol changes required for introducing epoch and fencing
> ------------------------------------------------------------------
>
> Key: HDFS-3211
> URL: https://issues.apache.org/jira/browse/HDFS-3211
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: Shared journals (HDFS-3092)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt
>
>
> JournalProtocol changes to introduce epoch in every request. Adding new method fence for fencing a JournalService. On BackupNode fence is a no-op.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3211) JournalProtocol changes required for
introducing epoch and fencing
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273802#comment-13273802 ]
Hudson commented on HDFS-3211:
------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2310 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2310/])
Move HDFS-3211 to 2.0.0 in CHANGES.txt. (Revision 1337432)
Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1337432
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
> JournalProtocol changes required for introducing epoch and fencing
> ------------------------------------------------------------------
>
> Key: HDFS-3211
> URL: https://issues.apache.org/jira/browse/HDFS-3211
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: Shared journals (HDFS-3092)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 2.0.0, 3.0.0
>
> Attachments: HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, h3211_20120511_branch-2.patch
>
>
> JournalProtocol changes to introduce epoch in every request. Adding new method fence for fencing a JournalService. On BackupNode fence is a no-op.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3211) JournalProtocol changes required for
introducing epoch and fencing
Posted by "Tsz Wo (Nicholas), SZE (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-3211:
-----------------------------------------
Resolution: Fixed
Fix Version/s: 3.0.0
Status: Resolved (was: Patch Available)
I have committed this to trunk. Thanks Suresh!
(I tried to merge it back to branch-2 but the merge failed since journalservice was not there. So we should either post a patch for branch-2 or merge also the journalservice patches.)
> JournalProtocol changes required for introducing epoch and fencing
> ------------------------------------------------------------------
>
> Key: HDFS-3211
> URL: https://issues.apache.org/jira/browse/HDFS-3211
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: Shared journals (HDFS-3092)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 3.0.0
>
> Attachments: HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt
>
>
> JournalProtocol changes to introduce epoch in every request. Adding new method fence for fencing a JournalService. On BackupNode fence is a no-op.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3211) JournalProtocol changes required for
introducing epoch and fencing
Posted by "Suresh Srinivas (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247798#comment-13247798 ]
Suresh Srinivas commented on HDFS-3211:
---------------------------------------
bq. Hi Suresh. Have you looked at HDFS-3189? Hopefully we can make our protocols similar with the intent of eventually merging the two implementations.
I looked at it briefly. I think this patch should cover the changes you were making. Some differences - newEpoch is called fence. We should finish HDFS-3077 discussions, and if changes come out of it, we could make further changes to the protocol.
> JournalProtocol changes required for introducing epoch and fencing
> ------------------------------------------------------------------
>
> Key: HDFS-3211
> URL: https://issues.apache.org/jira/browse/HDFS-3211
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: Shared journals (HDFS-3092)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HDFS-3211.txt, HDFS-3211.txt
>
>
> JournalProtocol changes to introduce epoch in every request. Adding new method fence for fencing a JournalService. On BackupNode fence is a no-op.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3211) JournalProtocol changes required for
introducing epoch and fencing
Posted by "Suresh Srinivas (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247838#comment-13247838 ]
Suresh Srinivas commented on HDFS-3211:
---------------------------------------
Created HDFS-3212 for persisting epoch.
> JournalProtocol changes required for introducing epoch and fencing
> ------------------------------------------------------------------
>
> Key: HDFS-3211
> URL: https://issues.apache.org/jira/browse/HDFS-3211
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: Shared journals (HDFS-3092)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HDFS-3211.txt, HDFS-3211.txt
>
>
> JournalProtocol changes to introduce epoch in every request. Adding new method fence for fencing a JournalService. On BackupNode fence is a no-op.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HDFS-3211) JournalProtocol changes required for
introducing epoch and fencing
Posted by "Suresh Srinivas (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas reassigned HDFS-3211:
-------------------------------------
Assignee: Suresh Srinivas
> JournalProtocol changes required for introducing epoch and fencing
> ------------------------------------------------------------------
>
> Key: HDFS-3211
> URL: https://issues.apache.org/jira/browse/HDFS-3211
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: Shared journals (HDFS-3092)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
>
> JournalProtocol changes to introduce epoch in every request. Adding new method fence for fencing a JournalService. On BackupNode fence is a no-op.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3211) JournalProtocol changes required for
introducing epoch and fencing
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249106#comment-13249106 ]
Hudson commented on HDFS-3211:
------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2101 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2101/])
HDFS-3211. Add fence(..) and replace NamenodeRegistration with JournalInfo and epoch in JournalProtocol. Contributed by suresh (Revision 1310649)
Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310649
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/UnregisteredNodeException.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/JournalProtocolServerSideTranslatorPB.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/JournalProtocolTranslatorPB.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelper.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/journalservice/JournalService.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupJournalManager.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EditLogBackupOutputStream.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/FenceResponse.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/FencedException.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/JournalInfo.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/JournalProtocol.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/proto/JournalProtocol.proto
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/journalservice/TestJournalService.java
> JournalProtocol changes required for introducing epoch and fencing
> ------------------------------------------------------------------
>
> Key: HDFS-3211
> URL: https://issues.apache.org/jira/browse/HDFS-3211
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: Shared journals (HDFS-3092)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 3.0.0
>
> Attachments: HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt
>
>
> JournalProtocol changes to introduce epoch in every request. Adding new method fence for fencing a JournalService. On BackupNode fence is a no-op.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3211) JournalProtocol changes required for
introducing epoch and fencing
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273991#comment-13273991 ]
Hudson commented on HDFS-3211:
------------------------------
Integrated in Hadoop-Hdfs-trunk #1041 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1041/])
Move HDFS-3211 to 2.0.0 in CHANGES.txt. (Revision 1337432)
Result = FAILURE
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1337432
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
> JournalProtocol changes required for introducing epoch and fencing
> ------------------------------------------------------------------
>
> Key: HDFS-3211
> URL: https://issues.apache.org/jira/browse/HDFS-3211
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: Shared journals (HDFS-3092)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 2.0.0, 3.0.0
>
> Attachments: HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, h3211_20120511_branch-2.patch
>
>
> JournalProtocol changes to introduce epoch in every request. Adding new method fence for fencing a JournalService. On BackupNode fence is a no-op.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3211) JournalProtocol changes required for
introducing epoch and fencing
Posted by "Suresh Srinivas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HDFS-3211:
----------------------------------
Affects Version/s: Shared journals (HDFS-3092)
> JournalProtocol changes required for introducing epoch and fencing
> ------------------------------------------------------------------
>
> Key: HDFS-3211
> URL: https://issues.apache.org/jira/browse/HDFS-3211
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: Shared journals (HDFS-3092)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
>
> JournalProtocol changes to introduce epoch in every request. Adding new method fence for fencing a JournalService. On BackupNode fence is a no-op.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3211) JournalProtocol changes required for
introducing epoch and fencing
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274013#comment-13274013 ]
Hudson commented on HDFS-3211:
------------------------------
Integrated in Hadoop-Mapreduce-trunk #1077 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1077/])
Move HDFS-3211 to 2.0.0 in CHANGES.txt. (Revision 1337432)
Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1337432
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
> JournalProtocol changes required for introducing epoch and fencing
> ------------------------------------------------------------------
>
> Key: HDFS-3211
> URL: https://issues.apache.org/jira/browse/HDFS-3211
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: Shared journals (HDFS-3092)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 2.0.0, 3.0.0
>
> Attachments: HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, h3211_20120511_branch-2.patch
>
>
> JournalProtocol changes to introduce epoch in every request. Adding new method fence for fencing a JournalService. On BackupNode fence is a no-op.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3211) JournalProtocol changes required for
introducing epoch and fencing
Posted by "Suresh Srinivas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HDFS-3211:
----------------------------------
Attachment: HDFS-3211.txt
The patch is complete and read for review. I added a test for fence mechanism and checking epoch.
> JournalProtocol changes required for introducing epoch and fencing
> ------------------------------------------------------------------
>
> Key: HDFS-3211
> URL: https://issues.apache.org/jira/browse/HDFS-3211
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: Shared journals (HDFS-3092)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt
>
>
> JournalProtocol changes to introduce epoch in every request. Adding new method fence for fencing a JournalService. On BackupNode fence is a no-op.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3211) JournalProtocol changes required for
introducing epoch and fencing
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249274#comment-13249274 ]
Hudson commented on HDFS-3211:
------------------------------
Integrated in Hadoop-Mapreduce-trunk #1042 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1042/])
HDFS-3211. Add fence(..) and replace NamenodeRegistration with JournalInfo and epoch in JournalProtocol. Contributed by suresh (Revision 1310649)
Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310649
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/UnregisteredNodeException.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/JournalProtocolServerSideTranslatorPB.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/JournalProtocolTranslatorPB.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelper.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/journalservice/JournalService.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupJournalManager.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EditLogBackupOutputStream.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/FenceResponse.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/FencedException.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/JournalInfo.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/JournalProtocol.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/proto/JournalProtocol.proto
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/journalservice/TestJournalService.java
> JournalProtocol changes required for introducing epoch and fencing
> ------------------------------------------------------------------
>
> Key: HDFS-3211
> URL: https://issues.apache.org/jira/browse/HDFS-3211
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: Shared journals (HDFS-3092)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 3.0.0
>
> Attachments: HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt
>
>
> JournalProtocol changes to introduce epoch in every request. Adding new method fence for fencing a JournalService. On BackupNode fence is a no-op.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3211) JournalProtocol changes required for
introducing epoch and fencing
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249111#comment-13249111 ]
Hudson commented on HDFS-3211:
------------------------------
Integrated in Hadoop-Common-trunk-Commit #2026 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2026/])
HDFS-3211. Add fence(..) and replace NamenodeRegistration with JournalInfo and epoch in JournalProtocol. Contributed by suresh (Revision 1310649)
Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310649
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/UnregisteredNodeException.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/JournalProtocolServerSideTranslatorPB.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/JournalProtocolTranslatorPB.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelper.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/journalservice/JournalService.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupJournalManager.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EditLogBackupOutputStream.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/FenceResponse.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/FencedException.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/JournalInfo.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/JournalProtocol.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/proto/JournalProtocol.proto
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/journalservice/TestJournalService.java
> JournalProtocol changes required for introducing epoch and fencing
> ------------------------------------------------------------------
>
> Key: HDFS-3211
> URL: https://issues.apache.org/jira/browse/HDFS-3211
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: Shared journals (HDFS-3092)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 3.0.0
>
> Attachments: HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt
>
>
> JournalProtocol changes to introduce epoch in every request. Adding new method fence for fencing a JournalService. On BackupNode fence is a no-op.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3211) JournalProtocol changes required for
introducing epoch and fencing
Posted by "Todd Lipcon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247800#comment-13247800 ]
Todd Lipcon commented on HDFS-3211:
-----------------------------------
Hi Suresh. You need to store the epoch persistently on disk to handle the case of journal daemon restarts, I think. HDFS-3190 does a refactor to add a utility class you can use for this.
> JournalProtocol changes required for introducing epoch and fencing
> ------------------------------------------------------------------
>
> Key: HDFS-3211
> URL: https://issues.apache.org/jira/browse/HDFS-3211
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: Shared journals (HDFS-3092)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HDFS-3211.txt, HDFS-3211.txt
>
>
> JournalProtocol changes to introduce epoch in every request. Adding new method fence for fencing a JournalService. On BackupNode fence is a no-op.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3211) JournalProtocol changes required for
introducing epoch and fencing
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273817#comment-13273817 ]
Hudson commented on HDFS-3211:
------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2253 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2253/])
Move HDFS-3211 to 2.0.0 in CHANGES.txt. (Revision 1337432)
Result = ABORTED
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1337432
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
> JournalProtocol changes required for introducing epoch and fencing
> ------------------------------------------------------------------
>
> Key: HDFS-3211
> URL: https://issues.apache.org/jira/browse/HDFS-3211
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: Shared journals (HDFS-3092)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 2.0.0, 3.0.0
>
> Attachments: HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, h3211_20120511_branch-2.patch
>
>
> JournalProtocol changes to introduce epoch in every request. Adding new method fence for fencing a JournalService. On BackupNode fence is a no-op.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3211) JournalProtocol changes required for
introducing epoch and fencing
Posted by "Suresh Srinivas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HDFS-3211:
----------------------------------
Attachment: HDFS-3211.txt
Early version of the patch with changes:
# Changed JournalProtocol to use JournalInfo instead of NamenodeRegistration - continuing the work from HDFS-3204.
# All Journal methods are changed to include epoch
# Added fence method to JournalProtocol.
#* fence is allowed only if epoch is higher
#* In JournalService, in fence method the epoch is saved. Subsequently only the requests with that epoch succeeds.
Will add unit tests.
> JournalProtocol changes required for introducing epoch and fencing
> ------------------------------------------------------------------
>
> Key: HDFS-3211
> URL: https://issues.apache.org/jira/browse/HDFS-3211
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: Shared journals (HDFS-3092)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HDFS-3211.txt, HDFS-3211.txt
>
>
> JournalProtocol changes to introduce epoch in every request. Adding new method fence for fencing a JournalService. On BackupNode fence is a no-op.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3211) JournalProtocol changes required for
introducing epoch and fencing
Posted by "Suresh Srinivas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HDFS-3211:
----------------------------------
Attachment: HDFS-3211.txt
Updated patch with fixes to test failure.
> JournalProtocol changes required for introducing epoch and fencing
> ------------------------------------------------------------------
>
> Key: HDFS-3211
> URL: https://issues.apache.org/jira/browse/HDFS-3211
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: Shared journals (HDFS-3092)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt
>
>
> JournalProtocol changes to introduce epoch in every request. Adding new method fence for fencing a JournalService. On BackupNode fence is a no-op.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3211) JournalProtocol changes required for
introducing epoch and fencing
Posted by "Suresh Srinivas (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247814#comment-13247814 ]
Suresh Srinivas commented on HDFS-3211:
---------------------------------------
bq. You need to store the epoch persistently on disk to handle the case of journal daemon restarts, I think. HDFS-3190 does a refactor to add a utility class you can use for this
I think that can be done in another jira. I was thinking of doing that in startLogSegment. I think we are still discussing that. Once it is resolved, lets do a separate jira.
Also can you please look HDFS-3204. If you are busy, I will see if I can get it reviewed by Nicholas.
> JournalProtocol changes required for introducing epoch and fencing
> ------------------------------------------------------------------
>
> Key: HDFS-3211
> URL: https://issues.apache.org/jira/browse/HDFS-3211
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: Shared journals (HDFS-3092)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HDFS-3211.txt, HDFS-3211.txt
>
>
> JournalProtocol changes to introduce epoch in every request. Adding new method fence for fencing a JournalService. On BackupNode fence is a no-op.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3211) JournalProtocol changes required for
introducing epoch and fencing
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248886#comment-13248886 ]
Hadoop QA commented on HDFS-3211:
---------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12521730/HDFS-3211.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2217//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2217//console
This message is automatically generated.
> JournalProtocol changes required for introducing epoch and fencing
> ------------------------------------------------------------------
>
> Key: HDFS-3211
> URL: https://issues.apache.org/jira/browse/HDFS-3211
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: Shared journals (HDFS-3092)
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt, HDFS-3211.txt
>
>
> JournalProtocol changes to introduce epoch in every request. Adding new method fence for fencing a JournalService. On BackupNode fence is a no-op.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira