You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Isabel Jimenez <co...@isabeljimenez.com> on 2015/09/22 11:46:18 UTC

Review Request 38618: Changed executor HTTP API tests

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38618/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-2906
    https://issues.apache.org/jira/browse/MESOS-2906


Repository: mesos


Description
-------

The SUBSCRIBE Call is supposed to have a 'subscribe' message. This change is needed so test can pass tests after call validation.


Diffs
-----

  src/tests/executor_http_api_tests.cpp 9dbc519 

Diff: https://reviews.apache.org/r/38618/diff/


Testing
-------

make check


Thanks,

Isabel Jimenez


Re: Review Request 38618: Changed executor HTTP API tests

Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38618/#review99998
-----------------------------------------------------------

Ship it!


- Anand Mazumdar


On Sept. 22, 2015, 9:46 a.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38618/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2015, 9:46 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-2906
>     https://issues.apache.org/jira/browse/MESOS-2906
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The SUBSCRIBE Call is supposed to have a 'subscribe' message. This change is needed so test can pass tests after call validation.
> 
> 
> Diffs
> -----
> 
>   src/tests/executor_http_api_tests.cpp 9dbc519 
> 
> Diff: https://reviews.apache.org/r/38618/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>


Re: Review Request 38618: Changed executor HTTP API tests

Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38618/
-----------------------------------------------------------

(Updated Oct. 27, 2015, 12:09 a.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Changes
-------

rebase


Bugs: MESOS-2906
    https://issues.apache.org/jira/browse/MESOS-2906


Repository: mesos


Description
-------

The SUBSCRIBE Call is supposed to have a 'subscribe' message. This change is needed so test can pass tests after call validation.


Diffs (updated)
-----

  src/tests/executor_http_api_tests.cpp e429d84 

Diff: https://reviews.apache.org/r/38618/diff/


Testing
-------

make check


Thanks,

Isabel Jimenez


Re: Review Request 38618: Changed executor HTTP API tests

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38618/#review100658
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On Sept. 25, 2015, 6:57 p.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38618/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2015, 6:57 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-2906
>     https://issues.apache.org/jira/browse/MESOS-2906
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The SUBSCRIBE Call is supposed to have a 'subscribe' message. This change is needed so test can pass tests after call validation.
> 
> 
> Diffs
> -----
> 
>   src/tests/executor_http_api_tests.cpp c2c05f4 
> 
> Diff: https://reviews.apache.org/r/38618/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>


Re: Review Request 38618: Changed executor HTTP API tests

Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38618/
-----------------------------------------------------------

(Updated Sept. 25, 2015, 6:57 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-2906
    https://issues.apache.org/jira/browse/MESOS-2906


Repository: mesos


Description
-------

The SUBSCRIBE Call is supposed to have a 'subscribe' message. This change is needed so test can pass tests after call validation.


Diffs (updated)
-----

  src/tests/executor_http_api_tests.cpp c2c05f4 

Diff: https://reviews.apache.org/r/38618/diff/


Testing
-------

make check


Thanks,

Isabel Jimenez