[GitHub] [ozone] devmadhuu commented on pull request #4158: HDDS-6056. Recon /containers endpoint should return SCM container data instead of OM container data.

["devmadhuu (via GitHub)" <gi...@apache.org>]

devmadhuu commented on PR #4158:
URL: https://github.com/apache/ozone/pull/4158#issuecomment-1418999212

   > > @ArafatKhan2198 Please check failure in `TestReconWithOzoneManager`, it seems to be related.
   > > ```
   > > Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 34.526 s <<< FAILURE! - in org.apache.hadoop.ozone.recon.TestReconWithOzoneManager
   > > org.apache.hadoop.ozone.recon.TestReconWithOzoneManager.testOmDBSyncing  Time elapsed: 0.859 s  <<< FAILURE!
   > > java.lang.AssertionError: expected:<1> but was:<0>
   > > 	at org.junit.Assert.fail(Assert.java:89)
   > > 	at org.junit.Assert.failNotEquals(Assert.java:835)
   > > 	at org.junit.Assert.assertEquals(Assert.java:647)
   > > 	at org.junit.Assert.assertEquals(Assert.java:633)
   > > 	at org.apache.hadoop.ozone.recon.TestReconWithOzoneManager.testOmDBSyncing(TestReconWithOzoneManager.java:212)
   > > ```
   > > 
   > > 
   > >     
   > >       
   > >     
   > > 
   > >       
   > >     
   > > 
   > >     
   > >   
   > > https://github.com/apache/ozone/actions/runs/3984351091/jobs/6830477229#step:5:3162
   > 
   > Hi @adoroszlai The UT test testOmDBSyncing() in `TestReconWithOzoneManager` is testing whether the container data fetched from the `containerEndpoint` is in sync with its data source, which is the metadata from the **OM-DB Snapshot** that is maintained within recon. However, as per the recent JIRA, we have decided to switch from **OM-DB Snapshot** to **SCM DB Snapshots** for more reliable and up-to-date information about the containers. I have already written UT's in TestContainerEndpoint to test these changes. Thus, this Unit Test seems irrelevant as we are no longer using OM-DB for information. Should we discard this UT or write a similar one for SCM?
   
   @ArafatKhan2198 , Please verify if you can change the assertion source as per your container information from SCM, so that test case is passed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org