You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2016/10/13 08:39:56 UTC
Review Request 52820: LENS-1358: Lens server snapshotter failing when
there's a jdbc query running while snapshotting
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52820/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-1358
https://issues.apache.org/jira/browse/LENS-1358
Repository: lens
Description
-------
Diffs
-----
lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java dcddd1b78e2d01eab632f76a319c8381aeba7735
Diff: https://reviews.apache.org/r/52820/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 52820: LENS-1358: Lens server snapshotter failing
when there's a jdbc query running while snapshotting
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52820/#review152468
-----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java (line 28)
<https://reviews.apache.org/r/52820/#comment221479>
Really? do you want to make StatusUpdateListenter serializable ? I feel this should be transient.
- Amareshwari Sriramadasu
On Oct. 13, 2016, 8:42 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52820/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2016, 8:42 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1358
> https://issues.apache.org/jira/browse/LENS-1358
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java dcddd1b78e2d01eab632f76a319c8381aeba7735
>
> Diff: https://reviews.apache.org/r/52820/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 52820: LENS-1358: Lens server snapshotter failing
when there's a jdbc query running while snapshotting
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52820/#review152655
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Oct. 14, 2016, 9:59 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52820/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2016, 9:59 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1358
> https://issues.apache.org/jira/browse/LENS-1358
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java d0662f4ccfb71a2f56d3cb841c3c399a6cdf713c
> lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java 36cc8fa188f21d5f2e439e2121515799c3f70525
> lens-server-api/src/test/java/org/apache/lens/server/api/query/TestQueryContext.java a530e9d65e2c84e674b9260aaffbb68a0cbf2f94
>
> Diff: https://reviews.apache.org/r/52820/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 52820: LENS-1358: Lens server snapshotter failing
when there's a jdbc query running while snapshotting
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52820/
-----------------------------------------------------------
(Updated Oct. 17, 2016, 11:20 a.m.)
Review request for lens.
Bugs: LENS-1358
https://issues.apache.org/jira/browse/LENS-1358
Repository: lens
Description
-------
Diffs (updated)
-----
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 63d3539cc0a4ce4f707837b9cfd09c627834101d
lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java 36cc8fa188f21d5f2e439e2121515799c3f70525
lens-server-api/src/test/java/org/apache/lens/server/api/query/TestQueryContext.java 1560bf167de818e0724f752ea809557cf33f8145
Diff: https://reviews.apache.org/r/52820/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 52820: LENS-1358: Lens server snapshotter failing
when there's a jdbc query running while snapshotting
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52820/
-----------------------------------------------------------
(Updated Oct. 14, 2016, 3:29 p.m.)
Review request for lens.
Bugs: LENS-1358
https://issues.apache.org/jira/browse/LENS-1358
Repository: lens
Description
-------
Diffs (updated)
-----
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java d0662f4ccfb71a2f56d3cb841c3c399a6cdf713c
lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java 36cc8fa188f21d5f2e439e2121515799c3f70525
lens-server-api/src/test/java/org/apache/lens/server/api/query/TestQueryContext.java a530e9d65e2c84e674b9260aaffbb68a0cbf2f94
Diff: https://reviews.apache.org/r/52820/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 52820: LENS-1358: Lens server snapshotter failing
when there's a jdbc query running while snapshotting
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52820/#review152624
-----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java (line 203)
<https://reviews.apache.org/r/52820/#comment221717>
Can you update TestQueryContext by checking getter on this?
- Amareshwari Sriramadasu
On Oct. 13, 2016, 1:54 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52820/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2016, 1:54 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1358
> https://issues.apache.org/jira/browse/LENS-1358
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java d0662f4ccfb71a2f56d3cb841c3c399a6cdf713c
>
> Diff: https://reviews.apache.org/r/52820/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 52820: LENS-1358: Lens server snapshotter failing
when there's a jdbc query running while snapshotting
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52820/
-----------------------------------------------------------
(Updated Oct. 13, 2016, 7:24 p.m.)
Review request for lens.
Bugs: LENS-1358
https://issues.apache.org/jira/browse/LENS-1358
Repository: lens
Description
-------
Diffs (updated)
-----
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java d0662f4ccfb71a2f56d3cb841c3c399a6cdf713c
Diff: https://reviews.apache.org/r/52820/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 52820: LENS-1358: Lens server snapshotter failing
when there's a jdbc query running while snapshotting
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52820/
-----------------------------------------------------------
(Updated Oct. 13, 2016, 4:10 p.m.)
Review request for lens.
Bugs: LENS-1358
https://issues.apache.org/jira/browse/LENS-1358
Repository: lens
Description
-------
Diffs (updated)
-----
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java d0662f4ccfb71a2f56d3cb841c3c399a6cdf713c
Diff: https://reviews.apache.org/r/52820/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 52820: LENS-1358: Lens server snapshotter failing
when there's a jdbc query running while snapshotting
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52820/
-----------------------------------------------------------
(Updated Oct. 13, 2016, 2:12 p.m.)
Review request for lens.
Bugs: LENS-1358
https://issues.apache.org/jira/browse/LENS-1358
Repository: lens
Description
-------
Diffs (updated)
-----
lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java dcddd1b78e2d01eab632f76a319c8381aeba7735
Diff: https://reviews.apache.org/r/52820/diff/
Testing
-------
Thanks,
Rajat Khandelwal