You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by mhfrantz <gi...@git.apache.org> on 2015/05/14 23:44:39 UTC
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-670 tail step (v2)
GitHub user mhfrantz opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/61
TINKERPOP3-670 tail step (v2)
Replaces PR #60
Based on feedback on the initial PR:
* correctly (I hope) tested and implemented "bulk" support
* `ComputerVerificationStrategy` balks at mid-traversal global tail steps
* `__` (anonymous traversals) include `tail` methods
* deferred execution during MR (using `Bypassing`)
The hadoop-gremlin tests pass for me.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/RedSeal-co/incubator-tinkerpop TINKERPOP3-670-tail-step.v2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/61.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #61
----
commit 3204ee7cbeb3708f72d1bb3b75469fab299da83b
Author: mhfrantz <mf...@redsealnetworks.com>
Date: 2015-05-08T02:04:00Z
Implement RangeLocalStep.toString
commit ae6bd7b28271f3201c7e9fe9599b832c67eb1302
Author: mhfrantz <mf...@redsealnetworks.com>
Date: 2015-05-08T01:29:22Z
TINKERPOP3-670: Add 'tail' step
commit 3bd83e3b69bccb36bd81f39c0c8050a62ee4b6a4
Author: mhfrantz <mf...@redsealnetworks.com>
Date: 2015-05-08T13:30:43Z
TINKERPOP3-670: Avoid ID's in unit tests, since they're not vendor agnostic
commit 39900f2c27c6a6ba42a5639fad6b470278c0e6b1
Author: mhfrantz <mf...@redsealnetworks.com>
Date: 2015-05-08T13:52:09Z
TINKERPOP3-670: Add overloads to default tail limit to 1
commit 46a63e1476916e17384f564e90ec24c8db3424af
Author: mhfrantz <mf...@redsealnetworks.com>
Date: 2015-05-14T01:17:10Z
TINKERPOP3-670: Add tail step to __
commit f90f9301d80bd6cd1eb06dd04088c4bd7b51cddd
Author: mhfrantz <mf...@redsealnetworks.com>
Date: 2015-05-14T06:55:00Z
TINKERPOP3-670: Add repeat test for tail step
commit ed1b8dde07c43f89f3805327a5f0be71236eb339
Author: mhfrantz <mf...@redsealnetworks.com>
Date: 2015-05-14T07:45:12Z
TINKERPOP3-670: Cloned tail step should not include traverser buffer contents
commit e4692f8cec5d79145c22e6b59376bc6e6e2fb973
Author: mhfrantz <mf...@redsealnetworks.com>
Date: 2015-05-14T21:38:28Z
TINKERPOP3-670: Tail handles bulk and bypass during MapReduce
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-670 tail step (v2)
Posted by mhfrantz <gi...@git.apache.org>.
Github user mhfrantz commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/61#issuecomment-102527210
@okram Replaced by PR #64
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-670 tail step (v2)
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/61#issuecomment-102179790
Sweet. Did you make sure `SparkGraphComputer` integration tests pass? If that passes, Giraph will.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-670 tail step (v2)
Posted by mhfrantz <gi...@git.apache.org>.
Github user mhfrantz closed the pull request at:
https://github.com/apache/incubator-tinkerpop/pull/61
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-670 tail step (v2)
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/61#issuecomment-102526447
Can you merge master/ into your branch and then provide a PR. I will then merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-670 tail step (v2)
Posted by mhfrantz <gi...@git.apache.org>.
Github user mhfrantz commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/61#issuecomment-102197382
Yes, I see both SparkGraphComputerProcessIntegrateTest and GiraphGraphComputerProcessIntegrateTest mentioned in the test output. I'm using the GREMLIN_TESTS env var to run only the `tail` and `range` tests. Most of them are skipped by `ComputerVerificationStrategy`, but the one that you asked me to add does run on both Spark and Giraph:
```
...
Testing: g_V_repeatXbothX_timesX3X_tailX7X
...
Tests run: 18, Failures: 0, Errors: 0, Skipped: 12, Time elapsed: 24.016 sec - in org.apache.tinkerpop.gremlin.hadoop.process.computer.giraph.GiraphGraphComputerProcessIntegrateTest
...
Testing: g_V_repeatXbothX_timesX3X_tailX7X
...
Tests run: 18, Failures: 0, Errors: 0, Skipped: 12, Time elapsed: 12.464 sec - in org.apache.tinkerpop.gremlin.hadoop.process.computer.spark.SparkGraphComputerProcessIntegrateTest
```
Also, the same selected tinkergraph-gremlin tests still pass.
```
Tests run: 18, Failures: 0, Errors: 0, Skipped: 12, Time elapsed: 1.115 sec - in org.apache.tinkerpop.gremlin.tinkergraph.process.TinkerGraphProcessComputerTest
...
Tests run: 18, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.138 sec - in org.apache.tinkerpop.gremlin.tinkergraph.process.TinkerGraphProcessStandardTest
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-670 tail step (v2)
Posted by mhfrantz <gi...@git.apache.org>.
Github user mhfrantz commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/61#issuecomment-102524921
@okram Let me know if there's anything else you want on this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---