You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avalon.apache.org by Ken Geis <ke...@telocity.com> on 2001/06/09 02:10:01 UTC
[PATCH] minor connection pool changes
Attached is a patch that makes a couple minor changes to Excalibur JDBC
connection pooling.
a) I don't think that a symbol should be misspelled to prevent it from
conflicting with another symbol. I therefore changed "controler" to
"controllerConfig."
b) There was extraneous error information when the connection pool min
or max were less than 1.
c) JdbcConnectionFactory was ignoring the autocommit parameter. This
was acceptable because JdbcConnectionPool was setting the autoCommit
property. However, if JdbcConnectionFactory is used in some other
context, the behavior is unexpected.
Ken
Re: [PATCH] minor connection pool changes
Posted by Berin Loritsch <bl...@apache.org>.
Ken Geis wrote:
>
> Attached is a patch that makes a couple minor changes to Excalibur JDBC
> connection pooling.
>
> a) I don't think that a symbol should be misspelled to prevent it from
> conflicting with another symbol. I therefore changed "controler" to
> "controllerConfig."
>
> b) There was extraneous error information when the connection pool min
> or max were less than 1.
>
> c) JdbcConnectionFactory was ignoring the autocommit parameter. This
> was acceptable because JdbcConnectionPool was setting the autoCommit
> property. However, if JdbcConnectionFactory is used in some other
> context, the behavior is unexpected.
Changes made--some were not *exactly* as you specified, but the same
effect.
---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
Re: [PATCH] minor connection pool changes
Posted by Berin Loritsch <bl...@yahoo.com>.
--- Ken Geis <ke...@telocity.com> wrote:
> Attached is a patch that makes a couple minor
> changes to Excalibur JDBC
> connection pooling.
>
> a) I don't think that a symbol should be misspelled
> to prevent it from
> conflicting with another symbol. I therefore
> changed "controler" to
> "controllerConfig."
The spelling mistake was simply a mistake. Thanks
for the catch.
> b) There was extraneous error information when the
> connection pool min
> or max were less than 1.
Ok.
> c) JdbcConnectionFactory was ignoring the autocommit
> parameter. This
> was acceptable because JdbcConnectionPool was
> setting the autoCommit
> property. However, if JdbcConnectionFactory is used
> in some other
> context, the behavior is unexpected.
Using the factory in another context was not really
anticipated. There might be room for a factory based
JdbcConnectionComponent--but I haven't gotten to that
yet.
I will take care of these on Monday. Thanks again
__________________________________________________
Do You Yahoo!?
Get personalized email addresses from Yahoo! Mail - only $35
a year! http://personal.mail.yahoo.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org