You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Julian Reschke (Jira)" <ji...@apache.org> on 2020/01/13 15:38:00 UTC
[jira] [Comment Edited] (OAK-8624) oak-run: tests leak mapd temp
files
[ https://issues.apache.org/jira/browse/OAK-8624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931524#comment-16931524 ]
Julian Reschke edited comment on OAK-8624 at 1/13/20 3:37 PM:
--------------------------------------------------------------
trunk: (1.18.0) [r1867061|http://svn.apache.org/r1867061]
1.10: (1.10.6) [r1867841|http://svn.apache.org/r1867841]
1.8: (1.8.18) [r1869792|http://svn.apache.org/r1869792]
1.6: (1.6.19) [r1870709|http://svn.apache.org/r1870709]
1.4: [r1872713|http://svn.apache.org/r1872713]
was (Author: reschke):
trunk: (1.18.0) [r1867061|http://svn.apache.org/r1867061]
1.10: (1.10.6) [r1867841|http://svn.apache.org/r1867841]
1.8: (1.8.18) [r1869792|http://svn.apache.org/r1869792]
1.6: [r1870709|http://svn.apache.org/r1870709]
> oak-run: tests leak mapd temp files
> -----------------------------------
>
> Key: OAK-8624
> URL: https://issues.apache.org/jira/browse/OAK-8624
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: run
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Priority: Minor
> Fix For: 1.4.25, 1.18.0, 1.8.18, 1.10.6, 1.6.19
>
> Attachments: OAK-8624.diff
>
>
> This is because {{MapDBMapFactory}} is backed by temporary DB, but that one is never closed.
> Fix:
> - make it {{closeable}}
> - adapt test case and use in {{RecoveryCommand}}
> However, {{RecoveryCommand}} sets the {{MapFactory}} instance globally, and never resets it. Thus, if the factory is indeed closed, subsequent tests will fail. So, in {{RecoveryCommand}}, restore the default factory when done.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)