You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "slachiewicz (via GitHub)" <gi...@apache.org> on 2026/08/14 20:43:32 UTC
[I] Expose MultiPageSinkFactory in doxia-site-renderer so reports can render subpages outside the site [maven-doxia-sitetools]
slachiewicz opened a new issue, #671:
URL: https://github.com/apache/maven-doxia-sitetools/issues/671
`MultiPageSinkFactory` and `MultiPageSubSink` are private nested classes of maven-site-plugin's `ReportDocumentRenderer`. apache/maven-reporting-impl#244 needs the same behaviour in `AbstractMavenReport.reportToSite()` — a multipage report invoked directly as a goal should produce the same set of pages it produces under `mvn site` — and had to copy both classes verbatim, because maven-site-plugin is not a dependency of maven-reporting-impl.
Both projects already depend on doxia-site-renderer, and both classes are built on `SiteRendererSink` and `DocumentRenderingContext`, so that is their natural home.
Proposal: move them into `org.apache.maven.doxia.siterenderer` as public API, and let `ReportDocumentRenderer` and `AbstractMavenReport` share the one copy.
One defect to fix once in the shared class rather than twice: `createSink(File, String)` does `document.substring(0, document.lastIndexOf('.'))`, which throws `StringIndexOutOfBoundsException` for an `outputName` without an extension.
Requested by @michael-o in apache/maven-reporting-impl#244, which fixes apache/maven-reporting-impl#217.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Expose MultiPageSinkFactory in doxia-site-renderer so reports can render subpages outside the site [maven-doxia-sitetools]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz closed issue #671: Expose MultiPageSinkFactory in doxia-site-renderer so reports can render subpages outside the site
URL: https://github.com/apache/maven-doxia-sitetools/issues/671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org