[GitHub] [dolphinscheduler] rickchengx commented on pull request #11589: [Feature-10498] Mask the password in the log of sqoop task

[GitBox <gi...@apache.org>]

rickchengx commented on PR #11589:
URL: https://github.com/apache/dolphinscheduler/pull/11589#issuecomment-1277175211

    
   > 1. Use `SensitiveDataConverter` to uniformly mask sensitive information in task logs.
   > 2. Each task plugin can add its own regular match expressions to `SensitiveDataConverter` through `addMaskPattern()`. E.g., `Sqoop` task adds its own regular expression in `init()`:
   > 
   > ```
   > SensitiveDataConverter.addMaskPattern(SqoopConstants.SQOOP_PASSWORD_REGEX);
   > ```
   > 
   > This PR solves the problem of the mysql password in the sqoop task log. If others find that other task types will output sensitive information in the log, they only need to add their own regular expression through `addMaskPattern()` in the `init()` of the task plugin.
   
   Hi, @ruanwenjun , could you please help review this? I've rebased to remove conflicts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org