You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "wyr8899 (via GitHub)" <gi...@apache.org> on 2024/01/29 02:25:41 UTC
[PR] It should be possible to use ping without rptun being enabled, so striped rptun_ping out of rptun and rename to rpmsg_ping. [nuttx]
wyr8899 opened a new pull request, #11618:
URL: https://github.com/apache/nuttx/pull/11618
## Summary
It should be possible to use ping without rptun being enabled., so striped rptun_ping out of rptun and rename to rpmsg_ping.
## Impact
Ping can also be used without rptun enabled.
## Testing
Tested in sim vela and 86panel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] It should be possible to use ping without rptun being enabled, so striped rptun_ping out of rptun and rename to rpmsg_ping. [nuttx]
Posted by "wyr8899 (via GitHub)" <gi...@apache.org>.
wyr8899 commented on PR #11618:
URL: https://github.com/apache/nuttx/pull/11618#issuecomment-1915928276
In order to ensure that CI passes, definitions such as RPTUNIOC_START are temporarily retained.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] It should be possible to use ping without rptun being enabled, so striped rptun_ping out of rptun and rename to rpmsg_ping. [nuttx]
Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao commented on code in PR #11618:
URL: https://github.com/apache/nuttx/pull/11618#discussion_r1469062218
##########
drivers/rpmsg/rpmsg.c:
##########
@@ -91,12 +93,32 @@ rpmsg_get_by_rdev(FAR struct rpmsg_device *rdev)
return metal_container_of(rdev, struct rpmsg_s, rdev);
}
+static int rpmsg_dev_ioctl_(FAR struct rpmsg_s *rpmsg, int cmd,
+ unsigned long arg)
+{
+ int ret = OK;
Review Comment:
```suggestion
int ret;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] It should be possible to use ping without rptun being enabled, so striped rptun_ping out of rptun and rename to rpmsg_ping. [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #11618:
URL: https://github.com/apache/nuttx/pull/11618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org