You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shindig.apache.org by li...@apache.org on 2010/06/12 02:50:34 UTC
svn commit: r953916 - in /shindig/trunk/java/gadgets/src:
main/java/org/apache/shindig/gadgets/rewrite/ConcatVisitor.java
test/java/org/apache/shindig/gadgets/variables/BidiSubstituterTest.java
Author: lindner
Date: Sat Jun 12 00:50:34 2010
New Revision: 953916
URL: http://svn.apache.org/viewvc?rev=953916&view=rev
Log:
unused import / java5 loop
Modified:
shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/ConcatVisitor.java
shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/variables/BidiSubstituterTest.java
Modified: shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/ConcatVisitor.java
URL: http://svn.apache.org/viewvc/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/ConcatVisitor.java?rev=953916&r1=953915&r2=953916&view=diff
==============================================================================
--- shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/ConcatVisitor.java (original)
+++ shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/ConcatVisitor.java Sat Jun 12 00:50:34 2010
@@ -177,16 +177,14 @@ public class ConcatVisitor implements Do
private void splitBatchOnMedia(List<Element> elements, List<List<Element>> output) {
// Multimap to hold the ordered list of elements encountered for a given media type.
Multimap<String, Element> mediaBatchMap = LinkedHashMultimap.create();
- Iterator<Element> elemIter = elements.iterator();
- while (elemIter.hasNext()) {
- Element next = elemIter.next();
+ for (Element element : elements) {
+ Element next = element;
mediaBatchMap.put(next.getAttribute("media"), next);
}
Set<String> mediaTypes = mediaBatchMap.keySet();
- Iterator<String> mediaTypesIter = mediaTypes.iterator();
- while (mediaTypesIter.hasNext()) {
- Collection<Element> elems = mediaBatchMap.get(mediaTypesIter.next());
- output.add(new LinkedList<Element>(elems));
+ for (String mediaType : mediaTypes) {
+ Collection<Element> elems = mediaBatchMap.get(mediaType);
+ output.add(new LinkedList<Element>(elems));
}
}
Modified: shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/variables/BidiSubstituterTest.java
URL: http://svn.apache.org/viewvc/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/variables/BidiSubstituterTest.java?rev=953916&r1=953915&r2=953916&view=diff
==============================================================================
--- shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/variables/BidiSubstituterTest.java (original)
+++ shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/variables/BidiSubstituterTest.java Sat Jun 12 00:50:34 2010
@@ -23,7 +23,6 @@ import org.apache.shindig.gadgets.render
import org.apache.shindig.gadgets.spec.GadgetSpec;
import org.apache.shindig.gadgets.spec.SpecParserException;
import org.junit.Assert;
-import org.junit.Ignore;
import org.junit.Test;
public class BidiSubstituterTest extends Assert {