You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fury.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/12/29 09:54:26 UTC
[I] [CODE HEADERS] Can we remove the author tags from the Fury code covered by the code grant? [incubator-fury]
pjfanning opened a new issue, #1281:
URL: https://github.com/apache/incubator-fury/issues/1281
It appears to be unusual to have author tags in ASF code bases. There are exceptions for code that is borrowed from 3rd party sources - if it was not explicitly granted to the ASF.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [I] [CODE HEADERS] Can we remove the author tags from the Fury code covered by the code grant? [incubator-fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on issue #1281:
URL: https://github.com/apache/incubator-fury/issues/1281#issuecomment-1871899198
Will be removed in #1282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [I] [CODE HEADERS] Can we remove the author tags from the Fury code covered by the code grant? [incubator-fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on issue #1281:
URL: https://github.com/apache/incubator-fury/issues/1281#issuecomment-1871894091
Hi PJ, do you mean the java doc author tag like:
```java
/**
* Thread safe serializer interface. {@link Fury} is not thread-safe, the implementation of this
* interface will be thread-safe. And support switch classloader dynamically.
*
* @author chaokunyang
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [I] [CODE HEADERS] Can we remove the author tags from the Fury code covered by the code grant? [incubator-fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on issue #1281:
URL: https://github.com/apache/incubator-fury/issues/1281#issuecomment-1871894626
We have such tags before joining ASF. If it's not recommanded, I can create a PR to remove it all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [I] [CODE HEADERS] Can we remove the author tags from the Fury code covered by the code grant? [incubator-fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang closed issue #1281: [CODE HEADERS] Can we remove the author tags from the Fury code covered by the code grant?
URL: https://github.com/apache/incubator-fury/issues/1281
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [I] [CODE HEADERS] Can we remove the author tags from the Fury code covered by the code grant? [incubator-fury]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #1281:
URL: https://github.com/apache/incubator-fury/issues/1281#issuecomment-1871897810
Yes - it is the `@author` tags is what I am referring to.
The ASF likes the idea of collective code owenership. The git history and git blame give a good idea of authorship anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [I] [CODE HEADERS] Can we remove the author tags from the Fury code covered by the code grant? [incubator-fury]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #1281:
URL: https://github.com/apache/incubator-fury/issues/1281#issuecomment-1871903202
https://whimsy.apache.org/board/minutes/Confirming_that_the_current_stance_on__author_tags_as.html
It is a recommendation (strong one) that the tags are removed but the PPMC could decide to allow them, if people are very attached to them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [I] [CODE HEADERS] Can we remove the author tags from the Fury code covered by the code grant? [incubator-fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on issue #1281:
URL: https://github.com/apache/incubator-fury/issues/1281#issuecomment-1871911405
I think tags can be removed. Currently only java code contains `@author`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org