You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "adamsaghy (via GitHub)" <gi...@apache.org> on 2023/05/10 09:56:04 UTC
[GitHub] [fineract] adamsaghy commented on a diff in pull request #3158: FINERACT-1912 Savings Account Transactions query -Advanced
adamsaghy commented on code in PR #3158:
URL: https://github.com/apache/fineract/pull/3158#discussion_r1189665245
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/api/SavingsAccountTransactionsApiResourceSwagger.java:
##########
@@ -20,11 +20,172 @@
import io.swagger.v3.oas.annotations.media.Schema;
import java.math.BigDecimal;
+import java.time.LocalDate;
+import java.util.HashSet;
+import java.util.Set;
final class SavingsAccountTransactionsApiResourceSwagger {
private SavingsAccountTransactionsApiResourceSwagger() {}
+ @Schema(description = "GetSavingsAccountTransactionsResponse")
+ public static final class GetSavingsAccountTransactionsResponse {
+
+ private GetSavingsAccountTransactionsResponse() {}
+
+ static final class GetSavingsAccountTransactionsPageItem {
+
+ private GetSavingsAccountTransactionsPageItem() {}
+
+ static final class GetTranscationEnumData {
+
+ private GetTranscationEnumData() {}
+
+ @Schema(example = "1")
+ public Long id;
+ @Schema(example = "savingsAccountTransactionType.deposit")
+ public String code;
+ @Schema(example = "Deposit")
+ public String value;
+
+ @Schema(example = "true")
+ public boolean deposit;
+ @Schema(example = "false")
+ public boolean dividendPayout;
+ @Schema(example = "false")
+ public boolean withdrawal;
+ @Schema(example = "false")
+ public boolean interestPosting;
+ @Schema(example = "false")
+ public boolean feeDeduction;
+ @Schema(example = "false")
+ public boolean initiateTransfer;
+ @Schema(example = "false")
+ public boolean approveTransfer;
+ @Schema(example = "false")
+ public boolean withdrawTransfer;
+ @Schema(example = "false")
+ public boolean rejectTransfer;
+ @Schema(example = "false")
+ public boolean overdraftInterest;
+ @Schema(example = "false")
+ public boolean writtenoff;
+ @Schema(example = "true")
+ public boolean overdraftFee;
+ @Schema(example = "false")
+ public boolean withholdTax;
+ @Schema(example = "false")
+ public boolean escheat;
+ @Schema(example = "false")
+ public boolean amountHold;
+ @Schema(example = "false")
+ public boolean amountRelease;
+ }
+
+ static final class GetTransactionsCurrency {
+
+ private GetTransactionsCurrency() {}
+
+ @Schema(example = "USD")
+ public String code;
+ @Schema(example = "US Dollar")
+ public String name;
+ @Schema(example = "2")
+ public Integer decimalPlaces;
+ @Schema(example = "0")
+ public Integer isMultiplesOf;
+ @Schema(example = "$")
+ public String displaySymbol;
+ @Schema(example = "currency.USD")
+ public String nameCode;
+ @Schema(example = "US Dollar ($)")
+ public String displayLabel;
+ }
+
+ static final class GetTransactionsPaymentDetailData {
+
+ private GetTransactionsPaymentDetailData() {}
+
+ static final class GetPaymentTypeData {
+
+ private GetPaymentTypeData() {}
+
+ @Schema(example = "1")
+ public Long id;
+ @Schema(example = "Money Transfer")
+ public String name;
+ @Schema(example = "false")
+ public Boolean isSystemDefined;
+
+ }
+
+ @Schema(example = "1")
+ public Long id;
+ public GetPaymentTypeData paymentType;
+ @Schema(example = "acc123")
+ public String accountNumber;
+ @Schema(example = "che123")
+ public String checkNumber;
+ @Schema(example = "rou123")
+ public String routingCode;
+ @Schema(example = "rec123")
+ public String receiptNumber;
+ @Schema(example = "ban123")
+ public String bankNumber;
+ }
+
+ static final class GetSavingsAccountChargesPaidByData {
+
+ private GetSavingsAccountChargesPaidByData() {}
+
+ @Schema(example = "1")
+ public Long chargeId;
+ @Schema(example = "0")
+ public BigDecimal amount;
+ }
+
+ @Schema(example = "1")
+ public Long id;
+ public GetTranscationEnumData transactionType;
+ @Schema(example = "1")
+ public Long accountId;
+ @Schema(example = "000000001")
+ public String accountNo;
+ @Schema(example = "[2023, 05, 01]")
+ public LocalDate date;
+ public GetTransactionsCurrency currency;
+ public GetTransactionsPaymentDetailData paymentDetailData;
+ @Schema(example = "500")
+ public BigDecimal amount;
+ @Schema(example = "500")
+ public BigDecimal runningBalance;
+ @Schema(example = "false")
+ public boolean reversed;
+ @Schema(example = "[2023, 05, 01]")
+ public LocalDate submittedOnDate;
+ @Schema(example = "false")
+ public boolean interestedPostedAsOn;
+ @Schema(example = "mifos")
+ public String submittedByUsername;
+ @Schema(example = "false")
+ public boolean isManualTransaction;
Review Comment:
use `Boolean` class instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org