You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by yuhc <gi...@git.apache.org> on 2015/03/22 14:18:20 UTC
[GitHub] spark pull request: [SPARK-6455] [docs] Correct some mistakes and ...
GitHub user yuhc opened a pull request:
https://github.com/apache/spark/pull/5128
[SPARK-6455] [docs] Correct some mistakes and typos
Correct some typos. Correct a mistake in lib/PageRank.scala. The first PageRank implementation uses standalone Graph interface, but the second uses Pregel interface. It may mislead the code viewers.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yuhc/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5128.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5128
----
commit 206f2dc6d81387be4d55a50cfb602393f2497184
Author: Hangchen Yu <yu...@gitcafe.com>
Date: 2015-03-22T12:53:59Z
Correct some mistakes and typos.
commit 67b77b568bdfde02af0807c78106d5922f1c2379
Author: Hangchen Yu <yu...@gitcafe.com>
Date: 2015-03-22T12:53:59Z
[SPARK-6455] [docs] Correct some mistakes and typos
commit 53e5432b633d2451297e47acdc649251742dcd2d
Author: Hangchen Yu <yu...@gitcafe.com>
Date: 2015-03-22T13:14:08Z
Merge branch 'master' of https://github.com/yuhc/spark
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6455] [docs] Correct some mistakes and ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5128
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6455] [docs] Correct some mistakes and ...
Posted by yuhc <gi...@git.apache.org>.
Github user yuhc commented on the pull request:
https://github.com/apache/spark/pull/5128#issuecomment-84862704
Thank you for the fix! I forgot to check the length. I'll pay attention to it in future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6455] [docs] Correct some mistakes and ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5128#issuecomment-84606388
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6455] [docs] Correct some mistakes and ...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/5128#issuecomment-84679719
Sean this broke the build!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6455] [docs] Correct some mistakes and ...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5128#issuecomment-84681443
Ah! of course the line length now fails the style check; it didn't line-break. Well that'll teach me to eye-ball even a trivial doc change. Very sorry about that and thank you for the fix. Just waiting for Jenkins to come back would probably have been smarter, but running the style check locally was also an option, to double-check. I should have at least done that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6455] [docs] Correct some mistakes and ...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5128#issuecomment-84612782
LGTM. Just trivial doc fixes and so I don't think they even deserve a Jenkins test (which is having a bit of trouble at the moment.) I verified that the example comment is now correct.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6455] [docs] Correct some mistakes and ...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/5128#issuecomment-84680484
I fixed the build here : https://github.com/apache/spark/commit/7a0da47708b0e6b117b5c1a35aa3e93b8a914d5f
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org