You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2016/07/08 12:30:52 UTC

[GitHub] zeppelin pull request #1154: [ZEPPELIN-1136] NPE in Zeppelin Logs

GitHub user prabhjyotsingh opened a pull request:

    https://github.com/apache/zeppelin/pull/1154

    [ZEPPELIN-1136] NPE in Zeppelin Logs

    ### What is this PR for?
    Access Zeppelin without configuring any security, Zeppelin shows anoymous user and notice the NPE in Zeppelin logs.
    
    ```
    ERROR [2016-07-08 17:45:17,879] ({qtp1800659519-45} SecurityRestApi.java[getUserList]:120) - Exception in retrieving Users from realms 
    java.lang.NullPointerException
    	at org.apache.zeppelin.rest.GetUserList.getUserList(GetUserList.java:60)
    	at org.apache.zeppelin.rest.SecurityRestApi.getUserList(SecurityRestApi.java:108)
    	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    	at java.lang.reflect.Method.invoke(Method.java:497)
    	at org.apache.cxf.service.invoker.AbstractInvoker.performInvocation(AbstractInvoker.java:180)
    	at org.apache.cxf.service.invoker.AbstractInvoker.invoke(AbstractInvoker.java:96)
    ```
    
    ### What type of PR is it?
    [Bug Fix]
    
    
    ### What is the Jira issue?
    * [ZEPPELIN-1136](https://issues.apache.org/jira/browse/ZEPPELIN-1136)
    
    ### How should this be tested?
    Have shiro.ini with just following (minimal) content
    
    ```
    [urls]
    /api/version = anon
    /** = anon
    #/** = authc
    ```
    
    and observe in logs, there should be no error logs.
    
    
    ### Questions:
    * Does the licenses files need update? n/a
    * Is there breaking changes for older versions? n/a
    * Does this needs documentation? n/a
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-1136

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1154.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1154
    
----
commit af461f0a4fb52e5824c688fbf499fbfaa8795cdf
Author: Prabhjyot Singh <pr...@gmail.com>
Date:   2016-07-08T12:25:27Z

    ZEPPELIN-1136 NPE in Zeppelin Logs

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1154: [ZEPPELIN-1136] NPE in Zeppelin Logs

Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/1154
  
    Yes, agreed, added a unit test case for getUserList `userlist/{searchText}` API.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1154: [ZEPPELIN-1136] NPE in Zeppelin Logs

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1154


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1154: [ZEPPELIN-1136] NPE in Zeppelin Logs

Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/1154
  
    CI fails for `Job #5690.1` 
    
    ```
    13:05:55,335  INFO org.apache.zeppelin.notebook.Paragraph:254 - run paragraph 20160708-130555_1605317382 using r org.apache.zeppelin.interpreter.LazyOpenInterpreter@3a3dd369
    
    
    No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself.
    
    The build has been terminated
    ```
    
    Will merge this if no more discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1154: [ZEPPELIN-1136] NPE in Zeppelin Logs

Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/1154
  
    Merging this if no more discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1154: [ZEPPELIN-1136] NPE in Zeppelin Logs

Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/1154
  
    I think we need to add test case for this. How about you?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---